Bjorn Pettersson e7acf09de4 [ScalarEvolution] Fix base condition in isNormalAddRecPHI. ...

Summary:
The function is meant to recurse until it comes upon the
phi it's looking for. However, with the current condition,
it will recurse until it finds anything _but_ the phi.

The function will even fail for simple cases like:
  %i = phi i32 [ %inc, %loop ], ...
  ...
  %inc = add i32 %i, 1

because the base condition will not happen when the phi
is recursed to, and the recursion will end with a 'false'
result since the previous instruction is a phi.

Reviewers: sanjoy, atrick

Reviewed By: sanjoy

Subscribers: Ka-Ka, bjope, llvm-commits

Committing on behalf of: Bevin Hansson (bevinh)

Differential Revision: https://reviews.llvm.org/D40946

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@320700 91177308-0d34-0410-b5e6-96231b3b80d8

2017-12-14 14:47:52 +00:00

..

AMDGPU

AMDGPU: Mark all unspecified CC functions in tests as amdgpu_kernel

2017-03-21 21:39:51 +00:00

NVPTX

[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction

2015-02-27 19:29:02 +00:00

2002-09-09-PointerIndVar.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

2003-04-16-ExprAnalysis.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

2003-09-23-NotAtTop.ll

Tests: rewrite 'opt ... %s' to 'opt ... < %s' so that opt does not emit a ModuleID

2012-12-30 01:28:40 +00:00

2003-12-10-RemoveInstrCrash.ll

Teach ScalarEvolution how to compute a tripcount for a loop with

2010-02-19 18:12:07 +00:00

2003-12-15-Crash.ll

Teach ScalarEvolution how to compute a tripcount for a loop with

2010-02-19 18:12:07 +00:00

2004-03-10-PHIInsertionBug.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

2004-04-05-InvokeCastCrash.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

2004-04-07-ScalarEvolutionCrash.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

2005-02-11-InvokeCrash.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

2005-02-17-TruncateExprCrash.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

2005-02-26-ExitValueCompute.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

2005-06-15-InstMoveCrash.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

2005-11-18-Crash.ll

[opaque pointer type] Add textual IR support for explicit type parameter to gep operator

2015-03-13 18:20:45 +00:00

2006-03-31-NegativeStride.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

2006-06-16-Indvar-LCSSA-Crash.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

2006-09-20-LFTR-Crash.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

2006-12-10-BitCast.ll

Teach ScalarEvolution how to compute a tripcount for a loop with

2010-02-19 18:12:07 +00:00

2007-01-06-TripCount.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

2007-06-06-DeleteDanglesPtr.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

2007-11-23-BitcastCrash.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

2008-06-15-SCEVExpanderBug.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

2008-09-02-IVType.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

2008-10-03-CouldNotCompute.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

2008-11-25-APFloatAssert.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

2009-04-14-shorten_iv_vars.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

2009-04-15-shorten-iv-vars-2.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

2009-04-22-IndvarCrash.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

2009-04-27-Floating.ll

Make DataLayout Non-Optional in the Module

2015-03-04 18:43:29 +00:00

2009-05-24-useafterfree.ll

Correct bogus module triple specifications.

2010-08-30 10:48:29 +00:00

2011-09-10-widen-nsw.ll

This patch teaches IndVarSimplify to add nuw and nsw to certain kinds

2015-01-06 19:02:56 +00:00

2011-09-19-vectoriv.ll

[indvars] Fix PR10946: SCEV cannot handle Vector IVs.

2011-09-19 17:54:39 +00:00

2011-09-27-hoistsext.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

2011-10-27-lftrnull.ll

ConstantFold: Fold getelementptr (i32, i32* null, i64 undef) to null.

2017-05-08 17:37:29 +00:00

2011-11-01-lftrptr.ll

opt: Rename -default-data-layout flag to -data-layout and make it always override the layout.

2017-02-17 17:36:52 +00:00

2011-11-15-multiexit.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

2011-11-17-selfphi.ll

Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.

2013-07-14 01:42:54 +00:00

2012-07-17-lftr-undef.ll

[opaque pointer type] Add textual IR support for explicit type parameter to the call instruction

2015-04-16 23:24:18 +00:00

2012-10-19-congruent-constant.ll

Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.

2013-07-14 01:42:54 +00:00

2014-06-21-congruent-constant.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

ada-loops.ll

[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction

2015-02-27 19:29:02 +00:00

ashr-tripcount.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

avoid-i0.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

backedge-on-min-max.ll

[PM] Port IndVarSimplify to the new pass manager

2016-06-05 18:01:19 +00:00

bec-cmp.ll

Make ScalarEvolution::isKnownPredicate a little smarter

2015-08-19 01:51:51 +00:00

canonicalize-cmp.ll

Re-enable "[IndVars] Canonicalize comparisons between non-negative values and indvars"

2017-07-08 17:17:30 +00:00

casted-argument.ll

[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction

2015-02-27 19:29:02 +00:00

const_phi.ll

Fix PR25372 - teach replaceCongruentPHIs to handle cases where SE evaluates a PHI to a SCEVConstant

2015-11-03 16:27:04 +00:00

constant-fold.ll

[SimplifyIndVar] Do not fail when we constant fold an IV user to ConstantPointerNull

2017-09-29 16:32:12 +00:00

crash.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

dangling-use.ll

[opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction

2015-02-27 19:29:02 +00:00

divide-pointer.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

dont-recompute.ll

Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.

2013-07-14 01:42:54 +00:00

elim-extend.ll

Extend trip count instead of truncating IV in LFTR, when legal

2016-08-11 21:31:40 +00:00

eliminate-comparison.ll

Re-enable "[IndVars] Canonicalize comparisons between non-negative values and indvars"

2017-07-08 17:17:30 +00:00

eliminate-max.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

eliminate-rem.ll

[SimplifyIndvar] Replace the srem used by IV if we can prove both of its operands are non-negative

2017-09-25 17:39:40 +00:00

exit_value_test2.ll

[SCEV/IndVars] Always compute loop exiting values if the backedge count is 0

2017-08-01 22:37:58 +00:00

exit_value_test3.ll

Enable exitValue rewrite only when the cost of expansion is low.

2015-05-28 21:49:07 +00:00

exit_value_tests.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

floating-point-iv.ll

Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.

2013-07-14 01:42:54 +00:00

huge_muls.ll

[SCEV] Make MulOpsInlineThreshold lower to avoid excessive compilation time

2017-06-21 07:28:13 +00:00

indirectbr.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

interesting-invoke-use.ll

Move the personality function from LandingPadInst to Function

2015-06-17 20:52:32 +00:00

iterationCount_zext_or_trunc.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

iv-fold.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

iv-sext.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

iv-widen-elim-ext.ll

[IndVars] Change the order to compute WidenAddRec in widenIVUse.

2016-11-15 17:34:52 +00:00

iv-widen.ll

[IndVars] Change the order to compute WidenAddRec in widenIVUse.

2016-11-15 17:34:52 +00:00

iv-zext.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

lcssa-preservation.ll

Enable exitValue rewrite only when the cost of expansion is low.

2015-05-28 21:49:07 +00:00

lftr_disabled.ll

[IndVars] Add an option to be able to disable LFTR

2017-06-09 06:11:59 +00:00

lftr_simple.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

lftr-address-space-pointers.ll

[SCEV] Try to reuse existing value during SCEV expansion

2016-02-04 01:27:38 +00:00

lftr-extend-const.ll

Make DataLayout Non-Optional in the Module

2015-03-04 18:43:29 +00:00

lftr-other-uses.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

lftr-promote.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

lftr-reuse.ll

Revert some changes that were made to fix PR20680.

2015-03-02 21:41:07 +00:00

lftr-udiv-tripcount.ll

[SCEV] Strengthen SCEVExpander::isHighCostExpansion.

2015-04-14 03:20:32 +00:00

lftr-wide-trip-count.ll

Extend trip count instead of truncating IV in LFTR, when legal

2016-08-11 21:31:40 +00:00

lftr-zext.ll

[opaque pointer type] Add textual IR support for explicit type parameter to gep operator

2015-03-13 18:20:45 +00:00

loop_evaluate7.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

loop_evaluate8.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

loop_evaluate9.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

loop_evaluate10.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

loop_evaluate11.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

loop_evaluate_1.ll

Add test case for PR12377, it was fixed by r194116.

2013-11-06 11:55:41 +00:00

loop_evaluate_2.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

loop_evaluate_3.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

loop_evaluate_4.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

loop_evaluate_5.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

loop_evaluate_6.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

loop-invariant-conditions.ll

[IndVars] Fix a bug introduced in r317012

2017-12-01 20:57:19 +00:00

lrev-existing-umin.ll

[IndVars] Try to use existing values in RewriteLoopExitValues.

2015-07-09 18:46:12 +00:00

masked-iv.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

no-iv-rewrite.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

overflow-intrinsics.ll

[IndVars] Eliminate op.with.overflow when possible (re-apply)

2016-05-29 00:36:25 +00:00

phi-uses-value-multiple-times.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

polynomial-expand.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

post-inc-range.ll

[IndVarSimplify] Teach calculatePostIncRange to take guards into account

2016-10-19 19:43:54 +00:00

pr18223.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

pr20680.ll

Make DataLayout Non-Optional in the Module

2015-03-04 18:43:29 +00:00

pr22222.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

pr24356.ll

[IndVars] Fix PR24356.

2015-08-06 20:43:41 +00:00

pr24783.ll

[SCEV] Try to reuse existing value during SCEV expansion

2016-02-04 01:27:38 +00:00

pr24804.ll

[SCEVExpander] Have hoistIVInc preserve LCSSA

2015-12-08 00:13:17 +00:00

pr24952.ll

[SCEV] identical instructions don't compute equal values

2015-09-27 21:09:48 +00:00

pr24956.ll

[SCEV] Don't crash on pointer comparisons

2015-09-28 21:14:32 +00:00

pr25047.ll

[IndVars] Preserve LCSSA in eliminateIdentitySCEV

2015-10-07 17:38:31 +00:00

pr25051.ll

[IndVars] Don't break dominance in eliminateIdentitySCEV

2015-10-06 21:44:49 +00:00

pr25060.ll

[SCEV] Pick backedge values for phi nodes correctly

2015-10-08 18:28:36 +00:00

pr25360.ll

[SCEV] Don't create SCEV expressions that break LCSSA

2015-10-31 23:21:40 +00:00

pr25421.ll

Re-apply r251050 with a for PR25421

2015-11-05 23:45:38 +00:00

pr25576.ll

[IndVars] Fix PR25576

2016-01-17 18:12:52 +00:00

pr25578.ll

[IndVars] Have getInsertPointForUses preserve LCSSA

2015-12-08 00:13:21 +00:00

pr26207.ll

[SCEV] Fix PR26207

2016-01-19 20:53:51 +00:00

pr26973.ll

[IndVars] Pass the right loop to isLoopInvariantPredicate

2016-03-18 20:37:07 +00:00

pr26974.ll

[IndVars] Fix PR26974: make sure replaceCongruentIVs doesn't break LCSSA

2016-03-21 12:44:29 +00:00

pr27133.ll

[IndVarSimplify] Don't insert after a catchswitch

2016-03-30 21:12:06 +00:00

pr28935.ll

[IndVars] Ignore (s|z)exts that don't extend the induction variable

2016-08-13 00:58:31 +00:00

pr32045.ll

[ValueTracking] Don't do an unchecked shift in ComputeNumSignBits

2017-02-25 20:30:45 +00:00

preserve-signed-wrap.ll

Make DataLayout Non-Optional in the Module

2015-03-04 18:43:29 +00:00

promote-iv-to-eliminate-casts.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

replace-iv-with-loop-invariant.ll

[SimplifyIndVar] Replace IVUsers with loop invariant whenever possible

2017-10-12 02:54:11 +00:00

replace-sdiv-by-udiv.ll

[SimplifyIndvar] Replace the sdiv used by IV if we can prove both of its operands are non-negative

2017-03-30 21:56:56 +00:00

replace-srem-by-urem.ll

[SimplifyIndVar] Constant fold IV users

2017-09-27 03:11:46 +00:00

rewrite-loop-exit-value.ll

[IndVarSimplify] Rewrite loop exit values with their initial values from loop preheader

2016-01-27 07:40:41 +00:00

scev-phi-debug-info.ll

IndVarSimplify: preserve debug information attached to widened PHI nodes.

2017-11-02 23:17:06 +00:00

scevexpander-phi-base-case.ll

[ScalarEvolution] Fix base condition in isNormalAddRecPHI.

2017-12-14 14:47:52 +00:00

sharpen-range.ll

[PM] Port IndVarSimplify to the new pass manager

2016-06-05 18:01:19 +00:00

shrunk-constant.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

signed-trip-count.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

single-element-range.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

sink-alloca.ll

[opaque pointer type] Add textual IR support for explicit type parameter to the call instruction

2015-04-16 23:24:18 +00:00

sink-trapping.ll

[LLVM] Remove unwanted --check-prefix=CHECK from unit tests. NFC.

2016-04-19 23:51:52 +00:00

strengthen-overflow.ll

[IndVarSimplify] Add AShr exact flags using induction variables ranges.

2017-07-05 13:25:58 +00:00

tripcount_compute.ll

Fix PR18449: SCEV needs more precise max BECount for multi-exit loop.

2014-01-15 06:42:11 +00:00

tripcount_infinite.ll

FileCheck'ify some wc/grep based tests; NFCI.

2015-07-28 03:50:09 +00:00

udiv-invariant-but-traps.ll

Update Transforms tests to use CHECK-LABEL for easier debugging. No functionality change.

2013-07-14 01:42:54 +00:00

udiv.ll

Revert rL316568 because of sudden performance drop on ARM

2017-10-27 04:17:44 +00:00

uglygep.ll

[IndVars] Un-grepify test; NFC

2016-08-03 20:53:23 +00:00

ult-sub-to-eq.ll

Extend trip count instead of truncating IV in LFTR, when legal

2016-08-11 21:31:40 +00:00

use-range-metadata.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

variable-stride-ivs-0.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

variable-stride-ivs-1.ll

Change tests from "opt %s" to "opt < %s" so that opt doesn't see the

2009-09-11 18:01:28 +00:00

verify-scev.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

widen-loop-comp.ll

Re-enable "[IndVars] Canonicalize comparisons between non-negative values and indvars"

2017-07-08 17:17:30 +00:00

widen-nsw.ll

[opaque pointer type] Add textual IR support for explicit type parameter to load instruction

2015-02-27 21:17:42 +00:00

zext-nuw.ll

ScalarEvolution: do not set nuw when creating exprs of form <expr> + <all-ones>.

2015-11-20 01:26:13 +00:00