Hiroshi Yamauchi d5f27946f1 Split IndirectBr critical edges before PGO gen/use passes. ...

Summary:
The PGO gen/use passes currently fail with an assert failure if there's a
critical edge whose source is an IndirectBr instruction and that edge
needs to be instrumented.

To avoid this in certain cases, split IndirectBr critical edges in the PGO
gen/use passes. This works for blocks with single indirectbr predecessors,
but not for those with multiple indirectbr predecessors (splitting an
IndirectBr critical edge isn't always possible.)

Reviewers: davidxl, xur

Reviewed By: davidxl

Subscribers: efriedma, llvm-commits, mehdi_amini

Differential Revision: https://reviews.llvm.org/D40699

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@320511 91177308-0d34-0410-b5e6-96231b3b80d8

2017-12-12 19:07:43 +00:00

..

Inputs

Split IndirectBr critical edges before PGO gen/use passes.

2017-12-12 19:07:43 +00:00

X86

[PGO] resubmit r268969

2016-05-10 17:45:33 +00:00

branch1.ll

[PGO] Move the PGOInstrumentation pass to new OptRemark API.

2017-07-20 20:43:05 +00:00

branch2.ll

[PM]: port IR based profUse pass to new pass manager

2016-05-10 21:59:52 +00:00

comdat_internal.ll

Resubmit r297897: [PGO] Value profile for size of memory intrinsic calls

2017-03-16 21:15:48 +00:00

comdat_rename.ll

Resubmit "[PGO] Turn off comdat renaming in IR PGO by default"

2017-01-11 20:19:41 +00:00

counter_promo_exit_merge.ll

[PGO] Enhance pgo counter promotion

2017-07-12 23:27:44 +00:00

counter_promo_mexits.ll

[PGO] Enhance pgo counter promotion

2017-07-12 23:27:44 +00:00

counter_promo_nest.ll

[PGO] Enhance pgo counter promotion

2017-07-12 23:27:44 +00:00

counter_promo.ll

[PGO] Implementate profile counter regiser promotion

2017-06-25 00:26:43 +00:00

criticaledge.ll

[PM]: port IR based profUse pass to new pass manager

2016-05-10 21:59:52 +00:00

diag_FE_profile.ll

[PM]: port IR based profUse pass to new pass manager

2016-05-10 21:59:52 +00:00

diag_mismatch.ll

[PM]: port IR based profUse pass to new pass manager

2016-05-10 21:59:52 +00:00

diag_no_funcprofdata.ll

[Profile] improve warning control option

2016-08-11 05:09:30 +00:00

diag_no_profile.ll

[PM]: port IR based profUse pass to new pass manager

2016-05-10 21:59:52 +00:00

do-not-instrument.ll

[PM] port IR based PGO prof-gen pass to new pass manager

2016-05-06 05:49:19 +00:00

icp_covariant_call_return.ll

Create PHI node for the return value only when the return value has uses.

2017-08-28 18:57:00 +00:00

icp_covariant_invoke_return.ll

[PM] Port indirect call promotion pass to new pass manager

2016-05-16 16:31:07 +00:00

icp_invoke_nouse.ll

Create PHI node for the return value only when the return value has uses.

2017-08-28 18:57:00 +00:00

icp_invoke.ll

Make ICP uses PSI to check for hotness.

2017-08-08 20:57:33 +00:00

icp_mismatch_msg.ll

[ICP] Migrate to OptimizationRemarkEmitter

2017-07-27 16:54:15 +00:00

icp_sample.ll

Add null check for promoted direct call

2017-08-29 15:28:12 +00:00

icp_vararg.ll

[PM] Port indirect call promotion pass to new pass manager

2016-05-16 16:31:07 +00:00

indirect_call_annotation.ll

[PM]: port IR based profUse pass to new pass manager

2016-05-10 21:59:52 +00:00

indirect_call_profile.ll

Resubmit "[PGO] Turn off comdat renaming in IR PGO by default"

2017-01-11 20:19:41 +00:00

indirect_call_promotion.ll

Make ICP uses PSI to check for hotness.

2017-08-08 20:57:33 +00:00

indirectbr.ll

Split IndirectBr critical edges before PGO gen/use passes.

2017-12-12 19:07:43 +00:00

infinite_loop.ll

[PGO] Skip counter promotion for infinite loops

2017-11-30 19:16:25 +00:00

irreducible.ll

Add heuristics for irreducible loop metadata under PGO

2017-11-20 21:03:38 +00:00

landingpad.ll

[PM]: port IR based profUse pass to new pass manager

2016-05-10 21:59:52 +00:00

loop1.ll

[PM]: port IR based profUse pass to new pass manager

2016-05-10 21:59:52 +00:00

loop2.ll

[PM]: port IR based profUse pass to new pass manager

2016-05-10 21:59:52 +00:00

memcpy.ll

[PGO] Add omitted test cases.

2017-03-17 20:05:13 +00:00

memop_clone.ll

[PGO] Fixed assertion due to mismatched memcpy size type.

2017-08-18 19:17:08 +00:00

memop_size_annotation.ll

[PGO] Value profile for size of memory intrinsic calls

2017-03-17 18:07:26 +00:00

memop_size_from_strlen.ll

[PATCH] [PGO] Fixed cast operation in emIntrinsicVisitor::instrumentOneMemIntrinsic.

2017-06-19 20:04:33 +00:00

memop_size_opt_zero.ll

Memory intrinsic value profile optimization: Avoid divide by 0

2017-04-28 14:30:54 +00:00

memop_size_opt.ll

Keep Optimization Remark Yaml in NewPM

2017-08-20 01:30:45 +00:00

multiple_hash_profile.ll

Fix some broken CHECK lines.

2017-01-22 20:28:56 +00:00

noreturncall.ll

Fix the test cases committed in r289521.

2016-12-13 17:34:29 +00:00

PR28219.ll

Fix PR28219: Use profile summary from reader and not compute it

2016-06-21 19:29:49 +00:00

preinline.ll

[Profile] Use explicit flag to enable IR PGO

2016-07-23 04:28:52 +00:00

select1.ll

[Profile] Implement select instruction instrumentation in IR PGO

2016-09-18 18:34:07 +00:00

select2.ll

[PGO] Fix select instruction annotation

2016-10-25 21:47:24 +00:00

single_bb.ll

[PM] port IR based PGO prof-gen pass to new pass manager

2016-05-06 05:49:19 +00:00

split-indirectbr-critical-edges.ll

Split IndirectBr critical edges before PGO gen/use passes.

2017-12-12 19:07:43 +00:00

statics_counter_naming.ll

[PGO] Directory name stripping in global identifier for static functions

2017-02-25 00:00:36 +00:00

switch.ll

[PM]: port IR based profUse pass to new pass manager

2016-05-10 21:59:52 +00:00

thinlto_indirect_call_promotion.ll

Make ICP uses PSI to check for hotness.

2017-08-08 20:57:33 +00:00

thinlto_samplepgo_icp2.ll

[LTO][ThinLTO] Use the linker resolutions to mark global values as dso_local.

2017-11-04 17:04:39 +00:00

thinlto_samplepgo_icp3.ll

[ThinLTO] Fix dead stripping analysis for SamplePGO

2017-09-20 17:09:47 +00:00

thinlto_samplepgo_icp.ll

Make ICP uses PSI to check for hotness.

2017-08-08 20:57:33 +00:00

unreachable_bb.ll

[PGO] Fix PGO use ICE when there are unreachable BBs

2016-12-02 19:10:29 +00:00