mirror of
https://github.com/RPCS3/llvm.git
synced 2024-12-14 07:31:53 +00:00
70b69dcc75
Before, Key was a StringRef to avoid unnecessary copies. This commit changes that to a std::string. This was okay previously because when people called emit for remarks before, they would create the remark *within* the call to emit. However, if you build the remark up and call emit *afterward*, it's possible to end up freeing the memory assigned to the StringRef before the call to emit. This caused a test failure with https://reviews.llvm.org/D37085 on Linux. Since building remarks before a call to emit is a valid use-case, it makes sense to replace this with a std::string. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@312277 91177308-0d34-0410-b5e6-96231b3b80d8 |
||
---|---|---|
.. | ||
llvm | ||
llvm-c |