Javed Absar 9dd9f4f8b4 [ConstantFold] Fix defect in constant folding computation for GEP ...

When the array indexes are all determined by GVN to be constants,
a call is made to constant-folding to optimize/simplify the address
computation.

The constant-folding, however, makes a mistake in that it sometimes reads
back stale Idxs instead of NewIdxs, that it re-computed in previous iteration.
This leads to incorrect addresses coming out of constant-folding to GEP.
A test case is included. The error is only triggered when indexes have particular
patterns that the stale/new index updates interplay matters.

Reviewers: Daniel Berlin
Differential Revision: https://reviews.llvm.org/D30642



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@297317 91177308-0d34-0410-b5e6-96231b3b80d8

2017-03-08 23:01:50 +00:00

..

AliasSet

[AliasSetTracker] Make AST smarter about assume intrinsics that don't actually affect memory.

2016-11-07 14:11:45 +00:00

AssumptionCache

Add files I seem to have dropped in my revert (r290086).

2016-12-19 08:32:13 +00:00

BasicAA

[BasicAA] Take attributes into account when requesting modref info for a call site

2017-03-01 13:19:51 +00:00

BlockFrequencyInfo

[BFI] Add new LazyBFI analysis pass

2016-07-13 05:01:48 +00:00

BranchProbabilityInfo

Enhance calcColdCallHeuristics for InvokeInst

2016-09-23 17:26:14 +00:00

CallGraph

[CG] Add a new pass manager printer pass for the old call graph and

2016-03-10 11:24:11 +00:00

CFLAliasAnalysis

[Verifier] Add verification for TBAA metadata

2016-12-11 20:07:15 +00:00

ConstantFolding

[ConstantFold] Fix defect in constant folding computation for GEP

2017-03-08 23:01:50 +00:00

CostModel

[PPC] Give unaligned memory access lower cost on processor that supports it

2017-02-17 22:29:39 +00:00

Delinearization

[ValueTracking] Make poison propagation more aggressive

2017-02-22 06:52:32 +00:00

DemandedBits

Port DemandedBits to the new pass manager.

2016-04-18 23:55:01 +00:00

DependenceAnalysis

[DependenceAnalysis] Check if result of getConstantPart is null

2016-04-04 18:13:18 +00:00

DivergenceAnalysis

AMDGPU: Remove SI_fs_constant and SI_fs_interp intrinsics

2017-02-16 02:01:13 +00:00

DominanceFrontier

Another fix the testcase introduced by r261903 - Add the missing matches

2016-02-26 03:41:47 +00:00

Dominators

Remove useless pass from the pipeline in test/Analysis/Dominators/2007-01-14-BreakCritEdges.ll.

2016-07-25 16:27:34 +00:00

GlobalsModRef

Fix regression from my recent GlobalsAA fix.

2016-10-24 21:47:44 +00:00

IVUsers

[PM] Teach the LoopPassManager to automatically canonicalize loops by

2017-01-17 19:18:12 +00:00

LazyCallGraph

[LCG] Spell the printing pass pipeline name for the lazy call graph

2016-03-10 11:24:06 +00:00

LazyValueAnalysis

[PM] Teach LVI to correctly invalidate itself when its dependencies

2017-01-23 06:35:12 +00:00

Lint

[WinEH] Delete the old landingpad implementation of Windows EH

2015-10-09 23:34:53 +00:00

LoopAccessAnalysis

[LV/LoopAccess] Check statically if an unknown dependence distance can be

2017-02-12 09:32:53 +00:00

LoopInfo

[PM] Port LoopInfo to the new pass manager, adding both a LoopAnalysis

2015-01-20 10:58:50 +00:00

MemoryDependenceAnalysis

[PM] The assumption cache is fundamentally designed to be self-updating,

2017-01-15 00:26:18 +00:00

PostDominators

Revert "Fix PR 24415 (at least), by making our post-dominator tree behavior sane."

2017-03-02 21:08:37 +00:00

ProfileSummary

Reapply r271728 after adding move cobstructor for ProfileSummaryInfo

2016-06-03 22:54:26 +00:00

RegionInfo

Fix minor typo introduce in r297014

2017-03-06 16:03:26 +00:00

ScalarEvolution

[ValueTracking] Make poison propagation more aggressive

2017-02-22 06:52:32 +00:00

ScopedNoAliasAA

[ScopedNoAliasAA] Make test basic.ll less confusing

2016-03-07 17:49:10 +00:00

TypeBasedAliasAnalysis

[TBAAVerifier] Be stricter around verifying scalar nodes

2016-12-29 15:47:05 +00:00

ValueTracking

[ValueTracking] use nonnull argument attribute to eliminate null checks

2017-02-12 15:35:34 +00:00

alias-analysis-uses.ll

Add an "addUsedAAAnalyses" helper function

2016-02-09 01:21:57 +00:00