llvm/lib/ExecutionEngine
Lang Hames 7acaefabf6 [MCJIT] Clean up RuntimeDyld's quirky object-ownership/modification scheme.
Previously, when loading an object file, RuntimeDyld (1) took ownership of the
ObjectFile instance (and associated MemoryBuffer), (2) potentially modified the
object in-place, and (3) returned an ObjectImage that managed ownership of the
now-modified object and provided some convenience methods. This scheme accreted
over several years as features were tacked on to RuntimeDyld, and was both
unintuitive and unsafe (See e.g. http://llvm.org/PR20722).

This patch fixes the issue by removing all ownership and in-place modification
of object files from RuntimeDyld. Existing behavior, including debugger
registration, is preserved.

Noteworthy changes include:

(1) ObjectFile instances are now passed to RuntimeDyld by const-ref.
(2) The ObjectImage and ObjectBuffer classes have been removed entirely, they
    existed to model ownership within RuntimeDyld, and so are no longer needed.
(3) RuntimeDyld::loadObject now returns an instance of a new class,
    RuntimeDyld::LoadedObjectInfo, which can be used to construct a modified
    object suitable for registration with the debugger, following the existing
    debugger registration scheme.
(4) The JITRegistrar class has been removed, and the GDBRegistrar class has been
    re-written as a JITEventListener.

This should fix http://llvm.org/PR20722 .



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@222810 91177308-0d34-0410-b5e6-96231b3b80d8
2014-11-26 06:53:26 +00:00
..
IntelJITEvents [MCJIT] Clean up RuntimeDyld's quirky object-ownership/modification scheme. 2014-11-26 06:53:26 +00:00
Interpreter Converting FuncNames to a ManagedStatic to avoid static constructors and destructors. 2014-09-19 21:07:01 +00:00
MCJIT [MCJIT] Clean up RuntimeDyld's quirky object-ownership/modification scheme. 2014-11-26 06:53:26 +00:00
OProfileJIT [MCJIT] Clean up RuntimeDyld's quirky object-ownership/modification scheme. 2014-11-26 06:53:26 +00:00
RuntimeDyld [MCJIT] Clean up RuntimeDyld's quirky object-ownership/modification scheme. 2014-11-26 06:53:26 +00:00
CMakeLists.txt [MCJIT] Clean up RuntimeDyld's quirky object-ownership/modification scheme. 2014-11-26 06:53:26 +00:00
EventListenerCommon.h [Layering] Move DebugInfo.h into the IR library where its implementation 2014-03-06 00:46:21 +00:00
ExecutionEngine.cpp [MCJIT] Clean up RuntimeDyld's quirky object-ownership/modification scheme. 2014-11-26 06:53:26 +00:00
ExecutionEngineBindings.cpp Reinstate "Nuke the old JIT." 2014-09-02 22:28:02 +00:00
LLVMBuild.txt Reinstate "Nuke the old JIT." 2014-09-02 22:28:02 +00:00
Makefile Reinstate "Nuke the old JIT." 2014-09-02 22:28:02 +00:00
RTDyldMemoryManager.cpp [MCJIT] Turn the getSymbolAddress free function created in r218626 into a static 2014-10-01 04:11:13 +00:00
TargetSelect.cpp Reinstate "Nuke the old JIT." 2014-09-02 22:28:02 +00:00