mirror of
https://github.com/RPCS3/llvm.git
synced 2026-07-19 23:23:38 -04:00
George Rimar
26db7fb2ec
Currently, YAML has the following syntax for describing the symbols:
Symbols:
Local:
LocalSymbol1:
...
LocalSymbol2:
...
...
Global:
GlobalSymbol1:
...
Weak:
...
GNUUnique:
I.e. symbols are grouped by their bindings. That is not very convenient,
because:
It does not allow to set a custom binding, what can be useful for producing
broken/special outputs for test cases. Adding a new binding would require to
change a syntax (what we observed when added GNUUnique recently).
It does not allow to change the order of the symbols in .symtab/.dynsym,
i.e. currently all Local symbols are placed first, then Global, Weak and GNUUnique
are following, but we are not able to change the order.
It is not consistent. Binding is just one of the properties of the symbol,
we do not group them by other properties.
It makes the code more complex that it can be. This patch shows it can be simplified
with the change performed.
The patch changes the syntax to just:
Symbols:
Symbol1:
...
Symbol2:
...
...
With that, we are able to work with the binding field just like with any other symbol property.
Differential revision: https://reviews.llvm.org/D60122
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@357595 91177308-0d34-0410-b5e6-96231b3b80d8
57 lines
1.8 KiB
Plaintext
57 lines
1.8 KiB
Plaintext
# RUN: yaml2obj %s > %t
|
|
# RUN: llvm-objcopy --remove-section=.text.bar %t %t2
|
|
# RUN: llvm-readobj --elf-section-groups %t2 | FileCheck %s
|
|
|
|
# In this test the section .text.bar is getting removed, as a result,
|
|
# the indices of the sections which go after .text.bar will change,
|
|
# thus the fields Link, Info and the content of .group should be updated.
|
|
|
|
# CHECK: Name: .group
|
|
# CHECK-NEXT: Index: 1
|
|
# CHECK-NEXT: Link: 3
|
|
# CHECK-NEXT: Info: 2
|
|
# CHECK-NEXT: Type: COMDAT (0x1)
|
|
# CHECK-NEXT: Signature: foo
|
|
# CHECK: .text.foo (2)
|
|
|
|
--- !ELF
|
|
FileHeader:
|
|
Class: ELFCLASS64
|
|
Data: ELFDATA2LSB
|
|
Type: ET_REL
|
|
Machine: EM_X86_64
|
|
Sections:
|
|
- Name: .group
|
|
Type: SHT_GROUP
|
|
Link: .symtab
|
|
AddressAlign: 0x0000000000000004
|
|
Info: foo
|
|
Members:
|
|
- SectionOrType: GRP_COMDAT
|
|
- SectionOrType: .text.foo
|
|
- Name: .text.bar
|
|
Type: SHT_PROGBITS
|
|
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
|
|
AddressAlign: 0x0000000000000010
|
|
- Name: .text.foo
|
|
Type: SHT_PROGBITS
|
|
Flags: [ SHF_ALLOC, SHF_EXECINSTR, SHF_GROUP ]
|
|
AddressAlign: 0x0000000000000010
|
|
Symbols:
|
|
- Name: .text.bar
|
|
Type: STT_SECTION
|
|
Section: .text.bar
|
|
- Name: .text.foo
|
|
Type: STT_SECTION
|
|
Section: .text.foo
|
|
- Name: bar
|
|
Type: STT_FUNC
|
|
Section: .text.bar
|
|
Size: 0x0000000000000000
|
|
Binding: STB_WEAK
|
|
- Name: foo
|
|
Type: STT_FUNC
|
|
Section: .text.foo
|
|
Size: 0x0000000000000000
|
|
Binding: STB_WEAK
|