mirror of
https://github.com/RPCS3/llvm.git
synced 2024-12-19 09:57:42 +00:00
d0dbe02fd2
The C and C++ semantics for compare_exchange require it to return a bool
indicating success. This gets mapped to LLVM IR which follows each cmpxchg with
an icmp of the value loaded against the desired value.
When lowered to ldxr/stxr loops, this extra comparison is redundant: its
results are implicit in the control-flow of the function.
This commit makes two changes: it replaces that icmp with appropriate PHI
nodes, and then makes sure earlyCSE is called after expansion to actually make
use of the opportunities revealed.
I've also added -{arm,aarch64}-enable-atomic-tidy options, so that
existing fragile tests aren't perturbed too much by the change. Many
of them either rely on undef/unreachable too pervasively to be
restored to something well-defined (particularly while making sure
they test the same obscure assert from many years ago), or depend on a
particular CFG shape, which is disrupted by SimplifyCFG.
rdar://problem/16227836
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@209883 91177308-0d34-0410-b5e6-96231b3b80d8
32 lines
1.1 KiB
LLVM
32 lines
1.1 KiB
LLVM
; RUN: llc %s -o - -aarch64-atomic-cfg-tidy=0 | FileCheck %s
|
|
; Check that ANDS (tst) is not merged with ADD when the immediate
|
|
; is not 0.
|
|
; <rdar://problem/16693089>
|
|
target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"
|
|
target triple = "arm64-apple-ios"
|
|
|
|
; CHECK-LABEL: tst1:
|
|
; CHECK: add [[REG:w[0-9]+]], w{{[0-9]+}}, #1
|
|
; CHECK: tst [[REG]], #0x1
|
|
define void @tst1(i1 %tst, i32 %true) {
|
|
entry:
|
|
br i1 %tst, label %for.end, label %for.body
|
|
|
|
for.body: ; preds = %for.body, %entry
|
|
%result.09 = phi i32 [ %add2.result.0, %for.body ], [ 1, %entry ]
|
|
%i.08 = phi i32 [ %inc, %for.body ], [ 2, %entry ]
|
|
%and = and i32 %i.08, 1
|
|
%cmp1 = icmp eq i32 %and, 0
|
|
%add2.result.0 = select i1 %cmp1, i32 %true, i32 %result.09
|
|
%inc = add nsw i32 %i.08, 1
|
|
%cmp = icmp slt i32 %i.08, %true
|
|
br i1 %cmp, label %for.body, label %for.cond.for.end_crit_edge
|
|
|
|
for.cond.for.end_crit_edge: ; preds = %for.body
|
|
%add2.result.0.lcssa = phi i32 [ %add2.result.0, %for.body ]
|
|
br label %for.end
|
|
|
|
for.end: ; preds = %for.cond.for.end_crit_edge, %entry
|
|
ret void
|
|
}
|