mirror of
https://github.com/RPCS3/llvm.git
synced 2025-01-19 00:14:20 +00:00
f1f27bb03e
Split out a new, low-level intrusive list type with clear semantics.
Unlike iplist (and ilist), all operations on simple_ilist are intrusive,
and simple_ilist never takes ownership of its nodes. This enables an
intuitive API that has the right defaults for intrusive lists.
- insert() takes references (not pointers!) to nodes (in iplist/ilist,
passing a reference will cause the node to be copied).
- erase() takes only iterators (like std::list), and does not destroy
the nodes.
- remove() takes only references and has the same behaviour as erase().
- clear() does not destroy the nodes.
- The destructor does not destroy the nodes.
- New API {erase,remove,clear}AndDispose() take an extra Disposer
functor for callsites that want to call some disposal routine (e.g.,
std::default_delete).
This list is not currently configurable, and has no callbacks.
The initial motivation was to fix iplist<>::sort to work correctly (even
with callbacks in ilist_traits<>). iplist<> uses simple_ilist<>::sort
directly. The new test in unittests/IR/ModuleTest.cpp crashes without
this commit.
Fixing sort() via a low-level layer provided a good opportunity to:
- Unit test the low-level functionality thoroughly.
- Modernize the API, largely inspired by other intrusive list
implementations.
Here's a sketch of a longer-term plan:
- Create BumpPtrList<>, a non-intrusive list implemented using
simple_ilist<>, and use it for the Token list in
lib/Support/YAMLParser.cpp. This will factor out the only real use of
createNode().
- Evolve the iplist<> and ilist<> APIs in the direction of
simple_ilist<>, making allocation/deallocation explicit at call sites
(similar to simple_ilist<>::eraseAndDispose()).
- Factor out remaining calls to createNode() and deleteNode() and remove
the customization from ilist_traits<>.
- Transition uses of iplist<>/ilist<> that don't need callbacks over to
simple_ilist<>.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@280107 91177308-0d34-0410-b5e6-96231b3b80d8
67 lines
1.3 KiB
CMake
67 lines
1.3 KiB
CMake
set(LLVM_LINK_COMPONENTS
|
|
Support
|
|
)
|
|
|
|
set(ADTSources
|
|
APFloatTest.cpp
|
|
APIntTest.cpp
|
|
APSIntTest.cpp
|
|
ArrayRefTest.cpp
|
|
BitmaskEnumTest.cpp
|
|
BitVectorTest.cpp
|
|
DAGDeltaAlgorithmTest.cpp
|
|
DeltaAlgorithmTest.cpp
|
|
DenseMapTest.cpp
|
|
DenseSetTest.cpp
|
|
DepthFirstIteratorTest.cpp
|
|
FoldingSet.cpp
|
|
FunctionRefTest.cpp
|
|
HashingTest.cpp
|
|
IListBaseTest.cpp
|
|
IListIteratorTest.cpp
|
|
IListNodeBaseTest.cpp
|
|
IListSentinelTest.cpp
|
|
IListTest.cpp
|
|
ImmutableMapTest.cpp
|
|
ImmutableSetTest.cpp
|
|
IntEqClassesTest.cpp
|
|
IntervalMapTest.cpp
|
|
IntrusiveRefCntPtrTest.cpp
|
|
IteratorTest.cpp
|
|
MakeUniqueTest.cpp
|
|
MapVectorTest.cpp
|
|
OptionalTest.cpp
|
|
PackedVectorTest.cpp
|
|
PointerEmbeddedIntTest.cpp
|
|
PointerIntPairTest.cpp
|
|
PointerSumTypeTest.cpp
|
|
PointerUnionTest.cpp
|
|
PostOrderIteratorTest.cpp
|
|
PriorityWorklistTest.cpp
|
|
RangeAdapterTest.cpp
|
|
SCCIteratorTest.cpp
|
|
STLExtrasTest.cpp
|
|
ScopeExitTest.cpp
|
|
SequenceTest.cpp
|
|
SetVectorTest.cpp
|
|
SimpleIListTest.cpp
|
|
SmallPtrSetTest.cpp
|
|
SmallStringTest.cpp
|
|
SmallVectorTest.cpp
|
|
SparseBitVectorTest.cpp
|
|
SparseMultiSetTest.cpp
|
|
SparseSetTest.cpp
|
|
StringMapTest.cpp
|
|
StringRefTest.cpp
|
|
TinyPtrVectorTest.cpp
|
|
TripleTest.cpp
|
|
TwineTest.cpp
|
|
VariadicFunctionTest.cpp
|
|
)
|
|
|
|
add_llvm_unittest(ADTTests
|
|
${ADTSources}
|
|
)
|
|
|
|
add_dependencies(ADTTests intrinsics_gen)
|