mirror of
https://github.com/RPCS3/llvm.git
synced 2025-05-16 02:16:23 +00:00
1ea77ad586
The hash table is a list of buckets, and the *value* stored in the bucket cannot be 0 since that is reserved. However, the code here was incorrectly skipping over the 0'th bucket entirely. The 0'th bucket is perfectly fine, just none of these buckets can contain the value 0. As a result, whenever there was a string where hash(S) % Size was equal to 0, we would write the value in the next bucket instead. We never caught this in our tests due to *another* bug, which is that we would iterate the entire list of buckets looking for the value, only using the hash value as a starting point. However, the real algorithm stops when it finds 0 in a bucket since it takes that to mean "the item is not in the hash table". The unit test is updated to carefully construct a set of hash values that will cause one item to hash to 0 mod bucket count, and the reader is also updated to return an error indicating that the item is not found when it encounters a 0 bucket. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@328162 91177308-0d34-0410-b5e6-96231b3b80d8
82 lines
3.2 KiB
C++
82 lines
3.2 KiB
C++
//===- StringTableBuilderTest.cpp -----------------------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/DebugInfo/PDB/Native/PDBStringTable.h"
|
|
#include "llvm/DebugInfo/PDB/Native/PDBStringTableBuilder.h"
|
|
#include "llvm/Support/BinaryByteStream.h"
|
|
#include "llvm/Support/BinaryStreamReader.h"
|
|
#include "llvm/Support/BinaryStreamWriter.h"
|
|
#include "llvm/Testing/Support/Error.h"
|
|
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace llvm;
|
|
using namespace llvm::pdb;
|
|
using namespace llvm::support;
|
|
|
|
namespace {
|
|
class StringTableBuilderTest : public ::testing::Test {};
|
|
}
|
|
|
|
TEST_F(StringTableBuilderTest, Simple) {
|
|
// Create /names table contents.
|
|
PDBStringTableBuilder Builder;
|
|
|
|
// This test case is carefully constructed to ensure that at least one
|
|
// string gets bucketed into slot 0, *and* to ensure that at least one
|
|
// has a hash collision at the end of the bucket list so it has to
|
|
// wrap around.
|
|
uint32_t FooID = Builder.insert("foo");
|
|
uint32_t BarID = Builder.insert("bar");
|
|
uint32_t BazID = Builder.insert("baz");
|
|
uint32_t BuzzID = Builder.insert("buzz");
|
|
uint32_t BazzID = Builder.insert("bazz");
|
|
uint32_t BarrID = Builder.insert("barr");
|
|
|
|
// Re-inserting the same item should return the same id.
|
|
EXPECT_EQ(FooID, Builder.insert("foo"));
|
|
EXPECT_EQ(BarID, Builder.insert("bar"));
|
|
EXPECT_EQ(BazID, Builder.insert("baz"));
|
|
EXPECT_EQ(BuzzID, Builder.insert("buzz"));
|
|
EXPECT_EQ(BazzID, Builder.insert("bazz"));
|
|
EXPECT_EQ(BarrID, Builder.insert("barr"));
|
|
|
|
// Each ID should be distinct.
|
|
std::set<uint32_t> Distinct{FooID, BarID, BazID, BuzzID, BazzID, BarrID};
|
|
EXPECT_EQ(6U, Distinct.size());
|
|
|
|
std::vector<uint8_t> Buffer(Builder.calculateSerializedSize());
|
|
MutableBinaryByteStream OutStream(Buffer, little);
|
|
BinaryStreamWriter Writer(OutStream);
|
|
EXPECT_THAT_ERROR(Builder.commit(Writer), Succeeded());
|
|
|
|
// Reads the contents back.
|
|
BinaryByteStream InStream(Buffer, little);
|
|
BinaryStreamReader Reader(InStream);
|
|
PDBStringTable Table;
|
|
EXPECT_THAT_ERROR(Table.reload(Reader), Succeeded());
|
|
|
|
EXPECT_EQ(6U, Table.getNameCount());
|
|
EXPECT_EQ(1U, Table.getHashVersion());
|
|
|
|
EXPECT_THAT_EXPECTED(Table.getStringForID(FooID), HasValue("foo"));
|
|
EXPECT_THAT_EXPECTED(Table.getStringForID(BarID), HasValue("bar"));
|
|
EXPECT_THAT_EXPECTED(Table.getStringForID(BazID), HasValue("baz"));
|
|
EXPECT_THAT_EXPECTED(Table.getStringForID(BuzzID), HasValue("buzz"));
|
|
EXPECT_THAT_EXPECTED(Table.getStringForID(BazzID), HasValue("bazz"));
|
|
EXPECT_THAT_EXPECTED(Table.getStringForID(BarrID), HasValue("barr"));
|
|
|
|
EXPECT_THAT_EXPECTED(Table.getIDForString("foo"), HasValue(FooID));
|
|
EXPECT_THAT_EXPECTED(Table.getIDForString("bar"), HasValue(BarID));
|
|
EXPECT_THAT_EXPECTED(Table.getIDForString("baz"), HasValue(BazID));
|
|
EXPECT_THAT_EXPECTED(Table.getIDForString("buzz"), HasValue(BuzzID));
|
|
EXPECT_THAT_EXPECTED(Table.getIDForString("bazz"), HasValue(BazzID));
|
|
EXPECT_THAT_EXPECTED(Table.getIDForString("barr"), HasValue(BarrID));
|
|
}
|