Chandler Carruth f41971f6e7 [ADT] Fix a confusing interface spec and some annoying peculiarities ...

with the StringRef::split method when used with a MaxSplit argument
other than '-1' (which nobody really does today, but which should
actually work).

The spec claimed both to split up to MaxSplit times, but also to append
<= MaxSplit strings to the vector. One of these doesn't make sense.
Given the name "MaxSplit", let's go with it being a max over how many
*splits* occur, which means the max on how many strings get appended is
MaxSplit+1. I'm not actually sure the implementation correctly provided
this logic either, as it used a really opaque loop structure.

The implementation was also playing weird games with nullptr in the data
field to try to rely on a totally opaque hidden property of the split
method that returns a pair. Nasty IMO.

Replace all of this with what is (IMO) simpler code that doesn't use the
pair returning split method, and instead just finds each separator and
appends directly. I think this is a lot easier to read, and it most
definitely matches the spec. Added some tests that exercise the corner
cases around StringRef() and StringRef("") that all now pass.

I'll start using this in code in the next commit.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247249 91177308-0d34-0410-b5e6-96231b3b80d8

2015-09-10 07:51:37 +00:00

..

APFloatTest.cpp

Drop the hacks used for partial C99 math libraries.

2015-03-09 18:35:18 +00:00

APIntTest.cpp

Fix APInt value initialization to give a zero value as any sane integer type

2015-09-04 04:08:36 +00:00

APSIntTest.cpp

ADTTests: merge #ifdef checks from r240436.

2015-06-24 17:05:04 +00:00

ArrayRefTest.cpp

Add makeArrayRef() overload for ArrayRef input (no-op/identity) NFC

2015-09-10 00:05:04 +00:00

BitVectorTest.cpp

Fix a buffer overrun detected by AddressSanitizer.

2013-12-19 02:35:26 +00:00

CMakeLists.txt

Reapply "Add reverse(ContainerTy) range adapter."

2015-07-29 22:19:09 +00:00

DAGDeltaAlgorithmTest.cpp

Use 'override/final' instead of 'virtual' for overridden methods

2015-04-11 02:11:45 +00:00

DeltaAlgorithmTest.cpp

Use 'override/final' instead of 'virtual' for overridden methods

2015-04-11 02:11:45 +00:00

DenseMapTest.cpp

[ADT] Teach DenseMap to support StringRef keys.

2015-06-24 10:06:29 +00:00

DenseSetTest.cpp

[ADT] Add a 'find_as' operation to DenseSet.

2014-10-19 19:36:33 +00:00

FoldingSet.cpp

Adding full stops to comments

2015-09-04 15:28:13 +00:00

FunctionRefTest.cpp

Ensure function_refs are copyable even from non-const references

2014-11-12 02:06:08 +00:00

HashingTest.cpp

Remove no-op dtor so that use of the implicit copy ctor/assignment operator are not deprecated.

2015-03-03 19:52:59 +00:00

ilistTest.cpp

Explicitly default ilistTest::Node's copy constructor

2015-03-04 17:01:18 +00:00

ImmutableMapTest.cpp

[C++11] Use 'nullptr'.

2014-06-08 22:29:17 +00:00

ImmutableSetTest.cpp

…

IntEqClassesTest.cpp

…

IntervalMapTest.cpp

…

IntrusiveRefCntPtrTest.cpp

[weak vtables] Place class definitions into anonymous namespaces to prevent weak vtables.

2013-11-19 03:08:35 +00:00

Makefile

…

MakeUniqueTest.cpp

[C++11] Add llvm::make_unique, according to N3656.

2014-03-09 11:20:17 +00:00

MapVectorTest.cpp

[ADT] Teach MapVector to support a swap member. Will be used in

2015-03-25 00:50:21 +00:00

OptionalTest.cpp

Allow Optionals to be compared to None

2015-08-19 23:07:27 +00:00

PackedVectorTest.cpp

Simplify PackedVector by removing user-defined special members that aren't any different than the defaults

2015-08-12 23:26:12 +00:00

PointerIntPairTest.cpp

ADT/PointerIntPairTest.cpp: Prune obsolete #if. We don't support msc17 anymore.

2015-02-17 15:36:01 +00:00

PointerUnionTest.cpp

[C++11] Use 'nullptr'.

2014-06-08 22:29:17 +00:00

PostOrderIteratorTest.cpp

Compilation test for PostOrderIterator.

2014-11-20 19:33:33 +00:00

RangeAdapterTest.cpp

Reapply "Add reverse(ContainerTy) range adapter."

2015-07-29 22:19:09 +00:00

SCCIteratorTest.cpp

[llvm] Replacing asserts with static_asserts where appropriate

2015-03-16 09:53:42 +00:00

SmallPtrSetTest.cpp

[C++11] Switch all uses of the llvm_move macro to use std::move

2014-03-02 04:08:41 +00:00

SmallStringTest.cpp

Add SmallString test trying to exercise the realloc() code path

2015-08-11 17:35:49 +00:00

SmallVectorTest.cpp

Use 'override/final' instead of 'virtual' for overridden methods

2015-04-11 02:11:45 +00:00

SparseBitVectorTest.cpp

Miscellaneous Fixes for SparseBitVector

2015-07-20 18:26:23 +00:00

SparseMultiSetTest.cpp

ADT/SparseMultiSetTest.cpp: Try to appease cygwin-clang on stage2, take two. [-Wsign-compare]

2013-01-22 10:39:31 +00:00

SparseSetTest.cpp

SparseSet: Add support for key-derived indexes and arbitrary key types.

2012-04-20 20:05:28 +00:00

StringMapTest.cpp

Removing LLVM_DELETED_FUNCTION, as MSVC 2012 was the last reason for requiring the macro. NFC; LLVM edition.

2015-02-15 22:54:22 +00:00

StringRefTest.cpp

[ADT] Fix a confusing interface spec and some annoying peculiarities

2015-09-10 07:51:37 +00:00

TinyPtrVectorTest.cpp

[tinyptrvector] Add in a MutableArrayRef implicit conversion operator to complement the ArrayRef implicit conversion operator.

2015-01-19 03:25:33 +00:00

TripleTest.cpp

Teach the target parsing framework to directly compute the length of all

2015-08-30 07:51:04 +00:00

TwineTest.cpp

Teach Twine to support SmallString.

2015-03-17 09:51:17 +00:00

VariadicFunctionTest.cpp

As Doug pointed out (and I really should know), it is perfectly easy to

2011-12-17 10:20:15 +00:00