mirror of
https://github.com/RPCS3/llvm.git
synced 2024-12-13 14:47:00 +00:00
3b15669938
Revision 220239 exposed a latent bug in method 'TargetInstrInfo::commuteInstruction'. When commuting the operands of a machine instruction, method 'commuteInstruction' didn't correctly propagate the 'IsUndef' flag to the register operands of the new (commuted) instruction. Before this patch, the following instruction: %vreg4<def> = VADDSDrr %vreg14, %vreg5<undef>; FR64:%vreg4,%vreg14,%vreg5 was wrongly converted by method 'commuteInstruction' into: %vreg4<def> = VADDSDrr %vreg5, %vreg14<undef>; FR64:%vreg4,%vreg5,%vreg14 The correct instruction should have been: %vreg4<def> = VADDSDrr %vreg5<undef>, %vreg14; FR64:%vreg4,%vreg5,%vreg14 This patch fixes the problem in method 'TargetInstrInfo::commuteInstruction'. When swapping the operands of a machine instruction, we now make sure that 'IsUndef' flags are correctly set. Added test case 'pr23103.ll'. Differential Revision: http://reviews.llvm.org/D9406 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@236258 91177308-0d34-0410-b5e6-96231b3b80d8
22 lines
805 B
LLVM
22 lines
805 B
LLVM
; RUN: llc -verify-machineinstrs -mtriple=x86_64-unknown-unknown -mcpu=generic -mattr=+avx < %s | FileCheck %s
|
|
|
|
; When commuting a VADDSDrr instruction, verify that the 'IsUndef' flag is
|
|
; correctly propagated to the operands of the resulting instruction.
|
|
; Test for PR23103;
|
|
|
|
declare zeroext i1 @foo(<1 x double>)
|
|
|
|
define <1 x double> @pr23103(<1 x double>* align 8 %Vp) {
|
|
; CHECK-LABEL: pr23103:
|
|
; CHECK: vmovsd (%rdi), %xmm0
|
|
; CHECK-NEXT: vmovsd %xmm0, {{.*}}(%rsp) {{.*#+}} 8-byte Spill
|
|
; CHECK-NEXT: callq foo
|
|
; CHECK-NEXT: vaddsd {{.*}}(%rsp), %xmm0, %xmm0 {{.*#+}} 8-byte Folded Reload
|
|
; CHECK: retq
|
|
entry:
|
|
%V = load <1 x double>, <1 x double>* %Vp, align 8
|
|
%call = call zeroext i1 @foo(<1 x double> %V)
|
|
%fadd = fadd <1 x double> %V, undef
|
|
ret <1 x double> %fadd
|
|
}
|