mirror of
https://github.com/RPCS3/llvm.git
synced 2025-02-25 21:33:25 +00:00

Currenly we can encode the 'st_other' field of symbol using 3 fields. 'Visibility' is used to encode STV_* values. 'Other' is used to encode everything except the visibility, but it can't handle arbitrary values. 'StOther' is used to encode arbitrary values when 'Visibility'/'Other' are not helpfull enough. 'st_other' field is used to encode symbol visibility and platform-dependent flags and values. Problem to encode it is that it consists of Visibility part (STV_* values) which are enumeration values and the Other part, which is different and inconsistent. For MIPS the Other part contains flags for all STO_MIPS_* values except STO_MIPS_MIPS16. (Like comment in ELFDumper says: "Someones in their infinite wisdom decided to make STO_MIPS_MIPS16 flag overlapped with other ST_MIPS_xxx flags."...) And for PPC64 the Other part might actually encode any value. This patch implements custom logic for handling the st_other and removes 'Visibility' and 'StOther' fields. Here is an example of a new YAML style this patch allows: - Name: foo Other: [ 0x4 ] - Name: bar Other: [ STV_PROTECTED, 4 ] - Name: zed Other: [ STV_PROTECTED, STO_MIPS_OPTIONAL, 0xf8 ] Differential revision: https://reviews.llvm.org/D66886 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@370472 91177308-0d34-0410-b5e6-96231b3b80d8
36 lines
903 B
YAML
36 lines
903 B
YAML
## Check obj2yaml is able to dump the Visibility field correctly.
|
|
|
|
# RUN: yaml2obj %s | obj2yaml - | FileCheck %s
|
|
|
|
# CHECK: --- !ELF
|
|
# CHECK-NEXT: FileHeader:
|
|
# CHECK-NEXT: Class: ELFCLASS64
|
|
# CHECK-NEXT: Data: ELFDATA2LSB
|
|
# CHECK-NEXT: Type: ET_REL
|
|
# CHECK-NEXT: Machine: EM_X86_64
|
|
# CHECK-NEXT: Symbols:
|
|
# CHECK-NEXT: - Name: default
|
|
# CHECK-NEXT: - Name: internal
|
|
# CHECK-NEXT: Other: [ STV_INTERNAL ]
|
|
# CHECK-NEXT: - Name: hidden
|
|
# CHECK-NEXT: Other: [ STV_HIDDEN ]
|
|
# CHECK-NEXT: - Name: protected
|
|
# CHECK-NEXT: Other: [ STV_PROTECTED ]
|
|
# CHECK-NEXT: ...
|
|
|
|
--- !ELF
|
|
FileHeader:
|
|
Class: ELFCLASS64
|
|
Data: ELFDATA2LSB
|
|
Type: ET_REL
|
|
Machine: EM_X86_64
|
|
Symbols:
|
|
- Name: default
|
|
Other: [ STV_DEFAULT ]
|
|
- Name: internal
|
|
Other: [ STV_INTERNAL ]
|
|
- Name: hidden
|
|
Other: [ STV_HIDDEN ]
|
|
- Name: protected
|
|
Other: [ STV_PROTECTED ]
|