mirror of
https://github.com/RPCS3/llvm.git
synced 2025-04-07 07:41:54 +00:00

Running tests with expensive checks enabled exhibits some problems with verification of pass results. First, the pass verification may require results of analysis that are not available. For instance, verification of loop info requires results of dominator tree analysis. A pass may be marked as conserving loop info but does not need to be dependent on DominatorTreePass. When a pass manager tries to verify that loop info is valid, it needs dominator tree, but corresponding analysis may be already destroyed as no user of it remained. Another case is a pass that is skipped. For instance, entities with linkage available_externally do not need code generation and such passes are skipped for them. In this case result verification must also be skipped. To solve these problems this change introduces a special flag to the Pass structure to mark passes that have valid results. If this flag is reset, verifications dependent on the pass result are skipped. Differential Revision: https://reviews.llvm.org/D27190 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@291882 91177308-0d34-0410-b5e6-96231b3b80d8
158 lines
5.0 KiB
C++
158 lines
5.0 KiB
C++
//===- MachineDominators.cpp - Machine Dominator Calculation --------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file implements simple dominator construction algorithms for finding
|
|
// forward dominators on machine functions.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/CodeGen/MachineDominators.h"
|
|
#include "llvm/CodeGen/Passes.h"
|
|
#include "llvm/ADT/SmallBitVector.h"
|
|
#include "llvm/Support/CommandLine.h"
|
|
|
|
using namespace llvm;
|
|
|
|
// Always verify dominfo if expensive checking is enabled.
|
|
#ifdef EXPENSIVE_CHECKS
|
|
static bool VerifyMachineDomInfo = true;
|
|
#else
|
|
static bool VerifyMachineDomInfo = false;
|
|
#endif
|
|
static cl::opt<bool, true> VerifyMachineDomInfoX(
|
|
"verify-machine-dom-info", cl::location(VerifyMachineDomInfo),
|
|
cl::desc("Verify machine dominator info (time consuming)"));
|
|
|
|
namespace llvm {
|
|
template class DomTreeNodeBase<MachineBasicBlock>;
|
|
template class DominatorTreeBase<MachineBasicBlock>;
|
|
}
|
|
|
|
char MachineDominatorTree::ID = 0;
|
|
|
|
INITIALIZE_PASS(MachineDominatorTree, "machinedomtree",
|
|
"MachineDominator Tree Construction", true, true)
|
|
|
|
char &llvm::MachineDominatorsID = MachineDominatorTree::ID;
|
|
|
|
void MachineDominatorTree::getAnalysisUsage(AnalysisUsage &AU) const {
|
|
AU.setPreservesAll();
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
}
|
|
|
|
bool MachineDominatorTree::runOnMachineFunction(MachineFunction &F) {
|
|
CriticalEdgesToSplit.clear();
|
|
NewBBs.clear();
|
|
DT->recalculate(F);
|
|
|
|
return false;
|
|
}
|
|
|
|
MachineDominatorTree::MachineDominatorTree()
|
|
: MachineFunctionPass(ID) {
|
|
initializeMachineDominatorTreePass(*PassRegistry::getPassRegistry());
|
|
DT = new DominatorTreeBase<MachineBasicBlock>(false);
|
|
}
|
|
|
|
MachineDominatorTree::~MachineDominatorTree() {
|
|
delete DT;
|
|
}
|
|
|
|
void MachineDominatorTree::releaseMemory() {
|
|
DT->releaseMemory();
|
|
}
|
|
|
|
void MachineDominatorTree::verifyAnalysis() const {
|
|
if (VerifyMachineDomInfo && isExecuted())
|
|
verifyDomTree();
|
|
}
|
|
|
|
void MachineDominatorTree::print(raw_ostream &OS, const Module*) const {
|
|
DT->print(OS);
|
|
}
|
|
|
|
void MachineDominatorTree::applySplitCriticalEdges() const {
|
|
// Bail out early if there is nothing to do.
|
|
if (CriticalEdgesToSplit.empty())
|
|
return;
|
|
|
|
// For each element in CriticalEdgesToSplit, remember whether or not element
|
|
// is the new immediate domminator of its successor. The mapping is done by
|
|
// index, i.e., the information for the ith element of CriticalEdgesToSplit is
|
|
// the ith element of IsNewIDom.
|
|
SmallBitVector IsNewIDom(CriticalEdgesToSplit.size(), true);
|
|
size_t Idx = 0;
|
|
|
|
// Collect all the dominance properties info, before invalidating
|
|
// the underlying DT.
|
|
for (CriticalEdge &Edge : CriticalEdgesToSplit) {
|
|
// Update dominator information.
|
|
MachineBasicBlock *Succ = Edge.ToBB;
|
|
MachineDomTreeNode *SuccDTNode = DT->getNode(Succ);
|
|
|
|
for (MachineBasicBlock *PredBB : Succ->predecessors()) {
|
|
if (PredBB == Edge.NewBB)
|
|
continue;
|
|
// If we are in this situation:
|
|
// FromBB1 FromBB2
|
|
// + +
|
|
// + + + +
|
|
// + + + +
|
|
// ... Split1 Split2 ...
|
|
// + +
|
|
// + +
|
|
// +
|
|
// Succ
|
|
// Instead of checking the domiance property with Split2, we check it with
|
|
// FromBB2 since Split2 is still unknown of the underlying DT structure.
|
|
if (NewBBs.count(PredBB)) {
|
|
assert(PredBB->pred_size() == 1 && "A basic block resulting from a "
|
|
"critical edge split has more "
|
|
"than one predecessor!");
|
|
PredBB = *PredBB->pred_begin();
|
|
}
|
|
if (!DT->dominates(SuccDTNode, DT->getNode(PredBB))) {
|
|
IsNewIDom[Idx] = false;
|
|
break;
|
|
}
|
|
}
|
|
++Idx;
|
|
}
|
|
|
|
// Now, update DT with the collected dominance properties info.
|
|
Idx = 0;
|
|
for (CriticalEdge &Edge : CriticalEdgesToSplit) {
|
|
// We know FromBB dominates NewBB.
|
|
MachineDomTreeNode *NewDTNode = DT->addNewBlock(Edge.NewBB, Edge.FromBB);
|
|
|
|
// If all the other predecessors of "Succ" are dominated by "Succ" itself
|
|
// then the new block is the new immediate dominator of "Succ". Otherwise,
|
|
// the new block doesn't dominate anything.
|
|
if (IsNewIDom[Idx])
|
|
DT->changeImmediateDominator(DT->getNode(Edge.ToBB), NewDTNode);
|
|
++Idx;
|
|
}
|
|
NewBBs.clear();
|
|
CriticalEdgesToSplit.clear();
|
|
}
|
|
|
|
void MachineDominatorTree::verifyDomTree() const {
|
|
MachineFunction &F = *getRoot()->getParent();
|
|
|
|
MachineDominatorTree OtherDT;
|
|
OtherDT.DT->recalculate(F);
|
|
if (compare(OtherDT)) {
|
|
errs() << "MachineDominatorTree is not up to date!\nComputed:\n";
|
|
print(errs(), nullptr);
|
|
errs() << "\nActual:\n";
|
|
OtherDT.print(errs(), nullptr);
|
|
abort();
|
|
}
|
|
}
|