mirror of
https://github.com/RPCS3/llvm.git
synced 2024-12-11 21:56:15 +00:00
afa2e7e6a6
Summary: This is a resurrection of work first proposed and discussed in Aug 2015: http://lists.llvm.org/pipermail/llvm-dev/2015-August/089384.html and initially landed (but then backed out) in Nov 2015: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20151109/312083.html The @llvm.memcpy/memmove/memset intrinsics currently have an explicit argument which is required to be a constant integer. It represents the alignment of the dest (and source), and so must be the minimum of the actual alignment of the two. This change is the first in a series that allows source and dest to each have their own alignments by using the alignment attribute on their arguments. In this change we: 1) Remove the alignment argument. 2) Add alignment attributes to the source & dest arguments. We, temporarily, require that the alignments for source & dest be equal. For example, code which used to read: call void @llvm.memcpy.p0i8.p0i8.i32(i8* %dest, i8* %src, i32 100, i32 4, i1 false) will now read call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 4 %dest, i8* align 4 %src, i32 100, i1 false) Downstream users may have to update their lit tests that check for @llvm.memcpy/memmove/memset call/declaration patterns. The following extended sed script may help with updating the majority of your tests, but it does not catch all possible patterns so some manual checking and updating will be required. s~declare void @llvm\.mem(set|cpy|move)\.p([^(]*)\((.*), i32, i1\)~declare void @llvm.mem\1.p\2(\3, i1)~g s~call void @llvm\.memset\.p([^(]*)i8\(i8([^*]*)\* (.*), i8 (.*), i8 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i8(i8\2* \3, i8 \4, i8 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i16\(i8([^*]*)\* (.*), i8 (.*), i16 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i16(i8\2* \3, i8 \4, i16 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i32\(i8([^*]*)\* (.*), i8 (.*), i32 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i32(i8\2* \3, i8 \4, i32 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i64\(i8([^*]*)\* (.*), i8 (.*), i64 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i64(i8\2* \3, i8 \4, i64 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i128\(i8([^*]*)\* (.*), i8 (.*), i128 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i128(i8\2* \3, i8 \4, i128 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i8\(i8([^*]*)\* (.*), i8 (.*), i8 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i8(i8\2* align \6 \3, i8 \4, i8 \5, i1 \7)~g s~call void @llvm\.memset\.p([^(]*)i16\(i8([^*]*)\* (.*), i8 (.*), i16 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i16(i8\2* align \6 \3, i8 \4, i16 \5, i1 \7)~g s~call void @llvm\.memset\.p([^(]*)i32\(i8([^*]*)\* (.*), i8 (.*), i32 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i32(i8\2* align \6 \3, i8 \4, i32 \5, i1 \7)~g s~call void @llvm\.memset\.p([^(]*)i64\(i8([^*]*)\* (.*), i8 (.*), i64 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i64(i8\2* align \6 \3, i8 \4, i64 \5, i1 \7)~g s~call void @llvm\.memset\.p([^(]*)i128\(i8([^*]*)\* (.*), i8 (.*), i128 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i128(i8\2* align \6 \3, i8 \4, i128 \5, i1 \7)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i8\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i8 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i8(i8\3* \4, i8\5* \6, i8 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i16\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i16 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i16(i8\3* \4, i8\5* \6, i16 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i32\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i32 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i32(i8\3* \4, i8\5* \6, i32 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i64\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i64 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i64(i8\3* \4, i8\5* \6, i64 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i128\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i128 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i128(i8\3* \4, i8\5* \6, i128 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i8\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i8 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i8(i8\3* align \8 \4, i8\5* align \8 \6, i8 \7, i1 \9)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i16\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i16 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i16(i8\3* align \8 \4, i8\5* align \8 \6, i16 \7, i1 \9)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i32\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i32 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i32(i8\3* align \8 \4, i8\5* align \8 \6, i32 \7, i1 \9)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i64\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i64 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i64(i8\3* align \8 \4, i8\5* align \8 \6, i64 \7, i1 \9)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i128\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i128 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i128(i8\3* align \8 \4, i8\5* align \8 \6, i128 \7, i1 \9)~g The remaining changes in the series will: Step 2) Expand the IRBuilder API to allow creation of memcpy/memmove with differing source and dest alignments. Step 3) Update Clang to use the new IRBuilder API. Step 4) Update Polly to use the new IRBuilder API. Step 5) Update LLVM passes that create memcpy/memmove calls to use the new IRBuilder API, and those that use use MemIntrinsicInst::[get|set]Alignment() to use getDestAlignment() and getSourceAlignment() instead. Step 6) Remove the single-alignment IRBuilder API for memcpy/memmove, and the MemIntrinsicInst::[get|set]Alignment() methods. Reviewers: pete, hfinkel, lhames, reames, bollu Reviewed By: reames Subscribers: niosHD, reames, jholewinski, qcolombet, jfb, sanjoy, arsenm, dschuff, dylanmckay, mehdi_amini, sdardis, nemanjai, david2050, nhaehnle, javed.absar, sbc100, jgravelle-google, eraman, aheejin, kbarton, JDevlieghere, asb, rbar, johnrusso, simoncook, jordy.potman.lists, apazos, sabuasal, llvm-commits Differential Revision: https://reviews.llvm.org/D41675 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@322965 91177308-0d34-0410-b5e6-96231b3b80d8
189 lines
5.7 KiB
LLVM
189 lines
5.7 KiB
LLVM
; RUN: opt -basicaa -lint -disable-output < %s 2>&1 | FileCheck %s
|
|
target datalayout = "e-p:64:64:64"
|
|
|
|
declare fastcc void @bar()
|
|
declare void @llvm.stackrestore(i8*)
|
|
declare void @llvm.memcpy.p0i8.p0i8.i64(i8* nocapture, i8* nocapture, i64, i1) nounwind
|
|
declare void @has_sret(i8* sret %p)
|
|
declare void @has_noaliases(i32* noalias %p, i32* %q)
|
|
declare void @one_arg(i32)
|
|
|
|
@CG = constant i32 7
|
|
@E = external global i8
|
|
|
|
define i32 @foo() noreturn {
|
|
%buf = alloca i8
|
|
%buf2 = alloca {i8, i8}, align 2
|
|
; CHECK: Caller and callee calling convention differ
|
|
call void @bar()
|
|
; CHECK: Null pointer dereference
|
|
store i32 0, i32* null
|
|
; CHECK: Null pointer dereference
|
|
%t = load i32, i32* null
|
|
; CHECK: Undef pointer dereference
|
|
store i32 0, i32* undef
|
|
; CHECK: Undef pointer dereference
|
|
%u = load i32, i32* undef
|
|
; CHECK: All-ones pointer dereference
|
|
store i32 0, i32* inttoptr (i64 -1 to i32*)
|
|
; CHECK: Address one pointer dereference
|
|
store i32 0, i32* inttoptr (i64 1 to i32*)
|
|
; CHECK: Memory reference address is misaligned
|
|
store i8 0, i8* %buf, align 2
|
|
; CHECK: Memory reference address is misaligned
|
|
%gep = getelementptr {i8, i8}, {i8, i8}* %buf2, i32 0, i32 1
|
|
store i8 0, i8* %gep, align 2
|
|
; CHECK: Division by zero
|
|
%sd = sdiv i32 2, 0
|
|
; CHECK: Division by zero
|
|
%ud = udiv i32 2, 0
|
|
; CHECK: Division by zero
|
|
%sr = srem i32 2, 0
|
|
; CHECK: Division by zero
|
|
%ur = urem i32 2, 0
|
|
; CHECK: extractelement index out of range
|
|
%ee = extractelement <4 x i32> zeroinitializer, i32 4
|
|
; CHECK: insertelement index out of range
|
|
%ie = insertelement <4 x i32> zeroinitializer, i32 0, i32 4
|
|
; CHECK: Shift count out of range
|
|
%r = lshr i32 0, 32
|
|
; CHECK: Shift count out of range
|
|
%q = ashr i32 0, 32
|
|
; CHECK: Shift count out of range
|
|
%l = shl i32 0, 32
|
|
; CHECK: xor(undef, undef)
|
|
%xx = xor i32 undef, undef
|
|
; CHECK: sub(undef, undef)
|
|
%xs = sub i32 undef, undef
|
|
|
|
; CHECK: Write to read-only memory
|
|
store i32 8, i32* @CG
|
|
; CHECK: Write to text section
|
|
store i32 8, i32* bitcast (i32()* @foo to i32*)
|
|
; CHECK: Load from block address
|
|
%lb = load i32, i32* bitcast (i8* blockaddress(@foo, %next) to i32*)
|
|
; CHECK: Call to block address
|
|
call void() bitcast (i8* blockaddress(@foo, %next) to void()*)()
|
|
; CHECK: Undefined behavior: Null pointer dereference
|
|
call void @llvm.stackrestore(i8* null)
|
|
; CHECK: Undefined behavior: Null pointer dereference
|
|
call void @has_sret(i8* null)
|
|
; CHECK: Unusual: noalias argument aliases another argument
|
|
call void @has_noaliases(i32* @CG, i32* @CG)
|
|
; CHECK: Call argument count mismatches callee argument count
|
|
call void (i32, i32) bitcast (void (i32)* @one_arg to void (i32, i32)*)(i32 0, i32 0)
|
|
; CHECK: Call argument count mismatches callee argument count
|
|
call void () bitcast (void (i32)* @one_arg to void ()*)()
|
|
; CHECK: Call argument type mismatches callee parameter type
|
|
call void (float) bitcast (void (i32)* @one_arg to void (float)*)(float 0.0)
|
|
|
|
; CHECK: Write to read-only memory
|
|
call void @llvm.memcpy.p0i8.p0i8.i64(i8* bitcast (i32* @CG to i8*), i8* bitcast (i32* @CG to i8*), i64 1, i1 0)
|
|
|
|
; CHECK: Undefined behavior: Buffer overflow
|
|
%wider = bitcast i8* %buf to i16*
|
|
store i16 0, i16* %wider
|
|
; CHECK: Undefined behavior: Buffer overflow
|
|
%inner = getelementptr {i8, i8}, {i8, i8}* %buf2, i32 0, i32 1
|
|
%wider2 = bitcast i8* %inner to i16*
|
|
store i16 0, i16* %wider2
|
|
; CHECK: Undefined behavior: Buffer overflow
|
|
%before = getelementptr i8, i8* %buf, i32 -1
|
|
%wider3 = bitcast i8* %before to i16*
|
|
store i16 0, i16* %wider3
|
|
|
|
br label %next
|
|
|
|
next:
|
|
; CHECK: Static alloca outside of entry block
|
|
%a = alloca i32
|
|
; CHECK: Return statement in function with noreturn attribute
|
|
ret i32 0
|
|
|
|
foo:
|
|
; CHECK-NOT: Undefined behavior: Buffer overflow
|
|
; CHECK-NOT: Memory reference address is misaligned
|
|
%e = bitcast i8* @E to i64*
|
|
store i64 0, i64* %e
|
|
%z = add i32 0, 0
|
|
; CHECK: unreachable immediately preceded by instruction without side effects
|
|
unreachable
|
|
}
|
|
|
|
; CHECK: Unnamed function with non-local linkage
|
|
define void @0() nounwind {
|
|
ret void
|
|
}
|
|
|
|
; CHECK: va_start called in a non-varargs function
|
|
declare void @llvm.va_start(i8*)
|
|
define void @not_vararg(i8* %p) nounwind {
|
|
call void @llvm.va_start(i8* %p)
|
|
ret void
|
|
}
|
|
|
|
; CHECK: Undefined behavior: Branch to non-blockaddress
|
|
define void @use_indbr() {
|
|
indirectbr i8* bitcast (i32()* @foo to i8*), [label %block]
|
|
block:
|
|
unreachable
|
|
}
|
|
|
|
; CHECK: Undefined behavior: Call with "tail" keyword references alloca
|
|
declare void @tailcallee(i8*)
|
|
define void @use_tail(i8* %valist) {
|
|
%t = alloca i8
|
|
tail call void @tailcallee(i8* %t)
|
|
ret void
|
|
}
|
|
|
|
; CHECK: Unusual: Returning alloca value
|
|
define i8* @return_local(i32 %n, i32 %m) {
|
|
%t = alloca i8, i32 %n
|
|
%s = getelementptr i8, i8* %t, i32 %m
|
|
ret i8* %s
|
|
}
|
|
|
|
; CHECK: Unusual: Returning alloca value
|
|
define i32* @return_obscured_local() {
|
|
entry:
|
|
%retval = alloca i32*
|
|
%x = alloca i32
|
|
store i32* %x, i32** %retval
|
|
br label %next
|
|
next:
|
|
%t0 = load i32*, i32** %retval
|
|
%t1 = insertvalue { i32, i32, i32* } zeroinitializer, i32* %t0, 2
|
|
%t2 = extractvalue { i32, i32, i32* } %t1, 2
|
|
br label %exit
|
|
exit:
|
|
%t3 = phi i32* [ %t2, %next ]
|
|
%t4 = bitcast i32* %t3 to i32*
|
|
%t5 = ptrtoint i32* %t4 to i64
|
|
%t6 = add i64 %t5, 0
|
|
%t7 = inttoptr i64 %t6 to i32*
|
|
ret i32* %t7
|
|
}
|
|
|
|
; CHECK: Undefined behavior: Undef pointer dereference
|
|
define i32* @self_reference() {
|
|
entry:
|
|
unreachable
|
|
exit:
|
|
%t3 = phi i32* [ %t4, %exit ]
|
|
%t4 = bitcast i32* %t3 to i32*
|
|
%x = load volatile i32, i32* %t3
|
|
br label %exit
|
|
}
|
|
|
|
; CHECK: Call return type mismatches callee return type
|
|
%struct = type { double, double }
|
|
declare i32 @nonstruct_callee() nounwind
|
|
define void @struct_caller() nounwind {
|
|
entry:
|
|
call %struct bitcast (i32 ()* @foo to %struct ()*)()
|
|
|
|
; CHECK: Undefined behavior: indirectbr with no destinations
|
|
indirectbr i8* null, []
|
|
}
|