Duncan P. N. Exon Smith fbc0a7d38b Verifier: Avoid quadratic checking of aggregates for bad bitcasts ...

Avoid O(N^2) behaviour when checking for bad bitcasts in `ConstantExpr`s
buried inside of aggregate initializers to `GlobalVariable`s.  I've:
- centralized the "visited" set for recursing through `ConstantExpr`s so
  that expressions are only visited once per Verifier run,
- removed the duplicate logic for the stack visit, and
- avoided recursing into other `GlobalValue`s.

This recovers roughly a 100x time difference in clang compiles of a
particular input file (filled with large cross-referencing tables) that
depends on whether `-disable-llvm-verifier` is on.  This slowdown was
caused by r187506, which introduced these checks.

Now, avoiding `-disable-llvm-verifier` only causes a 2x slowdown for
this case.

(Interestingly, dumping the textual IR for this file starts at least
50GB of global variable initializers (I don't know the total, since I
killed the dump)...)

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@255269 91177308-0d34-0410-b5e6-96231b3b80d8

2015-12-10 17:56:06 +00:00

..

AsmWriter.cpp

Macro debug info support in LLVM IR

2015-12-10 12:56:35 +00:00

AttributeImpl.h

llvm/lib/IR/AttributeImpl.h: Move comment block not to cover typedef, introduced in r244164. [-Wdocumentation]

2015-08-06 09:49:17 +00:00

Attributes.cpp

[AttributeSet] Overload AttributeSet::addAttribute to reduce compile

2015-12-02 06:58:49 +00:00

AutoUpgrade.cpp

Revert "Change memcpy/memset/memmove to have dest and source alignments."

2015-11-19 05:56:52 +00:00

BasicBlock.cpp

IR: Remove implicit iterator conversions from lib/IR, NFC

2015-10-08 23:49:46 +00:00

CMakeLists.txt

Revert r252990.

2015-11-13 01:44:32 +00:00

Comdat.cpp

IR: Add COMDATs to the IR

2014-06-27 18:19:56 +00:00

ConstantFold.cpp

Remove roundingMode argument in APFloat::mod

2015-09-21 19:29:25 +00:00

ConstantFold.h

Revert r240137 (Fixed/added namespace ending comments using clang-tidy. NFC)

2015-06-23 09:49:53 +00:00

ConstantRange.cpp

[IR] Add a makeNoWrapRegion method to ConstantRange

2015-10-22 03:12:57 +00:00

Constants.cpp

IR: Make ConstantDataArray::getFP actually return a ConstantDataArray

2015-12-09 21:21:07 +00:00

ConstantsContext.h

[opaque pointer type] Avoid using pointee types to retrieve InlineAsm's function type

2015-07-28 00:06:38 +00:00

Core.cpp

IR: Remove implicit iterator conversions from lib/IR, NFC

2015-10-08 23:49:46 +00:00

DataLayout.cpp

Revert "Add const to a bunch of Type* in DataLayout. NFC."

2015-07-27 17:15:28 +00:00

DebugInfo.cpp

DI: Reverse direction of subprogram -> function edge.

2015-11-05 22:03:56 +00:00

DebugInfoMetadata.cpp

Macro debug info support in LLVM IR

2015-12-10 12:56:35 +00:00

DebugLoc.cpp

IR: Give 'DI' prefix to debug info metadata

2015-04-29 16:38:44 +00:00

DiagnosticInfo.cpp

[PGO] Resubmit "MST based PGO instrumentation infrastructure" (r254021)

2015-12-09 18:08:16 +00:00

DiagnosticPrinter.cpp

MIR Serialization: Connect the machine function analysis pass to the MIR parser.

2015-06-15 20:30:22 +00:00

DIBuilder.cpp

Macro debug info support in LLVM IR

2015-12-10 12:56:35 +00:00

Dominators.cpp

Constant propagation after hitting assume(cmp) bugfix

2015-09-02 19:59:59 +00:00

Function.cpp

Don't copy information from aliasee to alias.

2015-12-02 20:03:17 +00:00

FunctionInfo.cpp

[ThinLTO] Handle bitcode without function summary sections gracefully

2015-11-21 21:55:48 +00:00

GCOV.cpp

Rename one of our two llvm::GCOVOptions classes to llvm::GCOV::Options. We used

2015-10-14 00:04:19 +00:00

Globals.cpp

Don't copy information from aliasee to alias.

2015-12-02 20:03:17 +00:00

GVMaterializer.cpp

[Layering] Move GVMaterializer.h into the IR library where its

2014-03-06 03:50:29 +00:00

InlineAsm.cpp

Fix SEGV in InlineAsm::ConstraintInfo::Parse.

2015-09-03 15:41:37 +00:00

Instruction.cpp

Add Instruction::getFunction; NFC

2015-12-08 00:13:12 +00:00

Instructions.cpp

Add arg_begin() and arg_end() to CallInst and InvokeInst; NFCI

2015-12-10 06:39:02 +00:00

IntrinsicInst.cpp

IR: Split Metadata from Value

2014-12-09 18:38:53 +00:00

IRBuilder.cpp

Revert "Change memcpy/memset/memmove to have dest and source alignments."

2015-11-19 05:56:52 +00:00

IRPrintingPasses.cpp

Revert r240137 (Fixed/added namespace ending comments using clang-tidy. NFC)

2015-06-23 09:49:53 +00:00

LegacyPassManager.cpp

Remove debug output that snuck into 254957

2015-12-07 22:43:56 +00:00

LLVMBuild.txt

…

LLVMContext.cpp

Introduce deoptimization operand bundles

2015-11-11 21:38:02 +00:00

LLVMContextImpl.cpp

[IR] Manage TheNoneToken with a std::unique_ptr

2015-11-16 20:55:57 +00:00

LLVMContextImpl.h

Macro debug info support in LLVM IR

2015-12-10 12:56:35 +00:00

Makefile

Revert r252990.

2015-11-13 01:44:32 +00:00

Mangler.cpp

Remove unused arguments and move ManglerPrefixTy to the implementation.

2015-06-23 14:11:09 +00:00

MDBuilder.cpp

[MDBuilder] Simplify code using initializer lists. NFC.

2015-11-22 18:03:17 +00:00

Metadata.cpp

Preserve load alignment and dereferenceable metadata during some transformations

2015-11-02 17:53:51 +00:00

MetadataImpl.h

DI: Disallow uniquable DICompileUnits

2015-08-03 17:26:41 +00:00

MetadataTracking.cpp

IR: Store RAUW support and Context in the same pointer, NFC

2015-01-19 19:02:06 +00:00

Module.cpp

Interface to attach maximum function count from PGO to module as module flags.

2015-12-03 20:57:37 +00:00

module.modulemap

[modules] Add module maps for LLVM. These are not quite ready for prime-time

2014-05-21 02:46:14 +00:00

Operator.cpp

Revert r240137 (Fixed/added namespace ending comments using clang-tidy. NFC)

2015-06-23 09:49:53 +00:00

Pass.cpp

Revert r240137 (Fixed/added namespace ending comments using clang-tidy. NFC)

2015-06-23 09:49:53 +00:00

PassManager.cpp

[PM] Push the debug option for the new pass manager into the opt tool

2015-01-13 22:42:38 +00:00

PassRegistry.cpp

Revert r231276 (including r231277): Add a lock() function in PassRegistry to speed up multi-thread synchronization.

2015-03-05 17:53:00 +00:00

Statepoint.cpp

Add invoke related functionality into StatepointSite classes.

2015-02-19 11:02:11 +00:00

SymbolTableListTraitsImpl.h

IR: Remove implicit iterator conversions from lib/IR, NFC

2015-10-08 23:49:46 +00:00

Type.cpp

[IR] Simplify code. No functionality change.

2015-08-16 21:16:26 +00:00

TypeFinder.cpp

IR: Remove implicit iterator conversions from lib/IR, NFC

2015-10-08 23:49:46 +00:00

Use.cpp

Revert r240137 (Fixed/added namespace ending comments using clang-tidy. NFC)

2015-06-23 09:49:53 +00:00

User.cpp

[IR] Teach llvm::User to co-allocate a descriptor.

2015-09-24 01:00:49 +00:00

Value.cpp

Remove handling of AddrSpaceCast in stripAndAccumulateInBoundsConstantOffsets

2015-09-23 19:48:43 +00:00

ValueSymbolTable.cpp

Have a single way for creating unique value names.

2015-11-22 00:16:24 +00:00

ValueTypes.cpp

Add new vector types for 512-, 1024- and 2048-bit vectors

2015-11-24 13:07:35 +00:00

Verifier.cpp

Verifier: Avoid quadratic checking of aggregates for bad bitcasts

2015-12-10 17:56:06 +00:00