mirror of
https://github.com/RPCSX/SPIRV-Tools.git
synced 2026-01-31 01:05:19 +01:00
7183ad526e
Turn `Linker::Link()` into free functions As very little information was kept in the Linker class, we can get rid of the whole class and have the `Link()` as free functions instead; the environment target as well as the consumer are passed along through an `spv_context` object. The resulting linked_binary is passed as a pointer rather than a reference to follow the Google C++ Style guidelines. Addresses remaining comments from https://github.com/KhronosGroup/SPIRV-Tools/pull/693 about the SPIR-V linker. Fix variable naming in the linker Some of the variables were using mixed case, which did not follow the Google C++ Style guidelines. Linker: Use EXPECT_EQ when possible and update some test * Replace occurrences of ASSERT_EQ by EXPECT_EQ when possible; * Reformulated some of the error messages; * Added the symbol name in the error message when there is a type or decoration mismatch between the imported and exported declarations. Opt: List all duplicates removed by RemoveDuplicatePass in the header Opt: Make the const version of GetLabelInst() return a pointer For consistency with the non-const version, as well as other similar functions. Opt: Rename function_end to EndInst() As pointed out by dneto0 the previous name was quite confusing and could be mistaken with a function returning an end iterator. Also change the return type of the const version to a pointer rather than a reference, for consistency. Opt: Add performance comment to RemoveDuplicateTypes and decorations This comment was requested during the review of https://github.com/KhronosGroup/SPIRV-Tools/pull/693. Opt: Add comments and fix variable naming in RemoveDuplicatePass * Add missing comments to private functions; * Rename variables that were using mixed case; * Add TODO for moving AreTypesEqual out. Linker: Remove commented out code and add TODOs Linker: Merged together strings that were too much splitted Implement a C++ RAII wrapper around spv_context
80 lines
2.7 KiB
C++
80 lines
2.7 KiB
C++
// Copyright (c) 2016 Google Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "function.h"
|
|
|
|
#include "make_unique.h"
|
|
|
|
namespace spvtools {
|
|
namespace ir {
|
|
|
|
Function* Function::Clone(IRContext* context) const {
|
|
Function* clone =
|
|
new Function(std::unique_ptr<Instruction>(DefInst().Clone(context)));
|
|
clone->params_.reserve(params_.size());
|
|
ForEachParam(
|
|
[clone, context](const Instruction* inst) {
|
|
clone->AddParameter(std::unique_ptr<Instruction>(inst->Clone(context)));
|
|
},
|
|
true);
|
|
|
|
clone->blocks_.reserve(blocks_.size());
|
|
for (const auto& b : blocks_) {
|
|
std::unique_ptr<BasicBlock> bb(b->Clone(context));
|
|
bb->SetParent(clone);
|
|
clone->AddBasicBlock(std::move(bb));
|
|
}
|
|
|
|
clone->SetFunctionEnd(
|
|
std::unique_ptr<Instruction>(EndInst()->Clone(context)));
|
|
return clone;
|
|
}
|
|
|
|
void Function::ForEachInst(const std::function<void(Instruction*)>& f,
|
|
bool run_on_debug_line_insts) {
|
|
if (def_inst_) def_inst_->ForEachInst(f, run_on_debug_line_insts);
|
|
for (auto& param : params_) param->ForEachInst(f, run_on_debug_line_insts);
|
|
for (auto& bb : blocks_) bb->ForEachInst(f, run_on_debug_line_insts);
|
|
if (end_inst_) end_inst_->ForEachInst(f, run_on_debug_line_insts);
|
|
}
|
|
|
|
void Function::ForEachInst(const std::function<void(const Instruction*)>& f,
|
|
bool run_on_debug_line_insts) const {
|
|
if (def_inst_)
|
|
static_cast<const Instruction*>(def_inst_.get())
|
|
->ForEachInst(f, run_on_debug_line_insts);
|
|
|
|
for (const auto& param : params_)
|
|
static_cast<const Instruction*>(param.get())
|
|
->ForEachInst(f, run_on_debug_line_insts);
|
|
|
|
for (const auto& bb : blocks_)
|
|
static_cast<const BasicBlock*>(bb.get())->ForEachInst(
|
|
f, run_on_debug_line_insts);
|
|
|
|
if (end_inst_)
|
|
static_cast<const Instruction*>(end_inst_.get())
|
|
->ForEachInst(f, run_on_debug_line_insts);
|
|
}
|
|
|
|
void Function::ForEachParam(const std::function<void(const Instruction*)>& f,
|
|
bool run_on_debug_line_insts) const {
|
|
for (const auto& param : params_)
|
|
static_cast<const Instruction*>(param.get())
|
|
->ForEachInst(f, run_on_debug_line_insts);
|
|
}
|
|
|
|
} // namespace ir
|
|
} // namespace spvtools
|