mirror of
https://github.com/RPCSX/llvm.git
synced 2026-01-31 01:05:23 +01:00
parts of the AA interface out of the base class of every single AA result object. Because this logic reformulates the query in terms of some other aspect of the API, it would easily cause O(n^2) query patterns in alias analysis. These could in turn be magnified further based on the number of call arguments, and then further based on the number of AA queries made for a particular call. This ended up causing problems for Rust that were actually noticable enough to get a bug (PR26564) and probably other places as well. When originally re-working the AA infrastructure, the desire was to regularize the pattern of refinement without losing any generality. While I think it was successful, that is clearly proving to be too costly. And the cost is needless: we gain no actual improvement for this generality of making a direct query to tbaa actually be able to re-use some other alias analysis's refinement logic for one of the other APIs, or some such. In short, this is entirely wasted work. To the extent possible, delegation to other API surfaces should be done at the aggregation layer so that we can avoid re-walking the aggregation. In fact, this significantly simplifies the logic as we no longer need to smuggle the aggregation layer into each alias analysis (or the TargetLibraryInfo into each alias analysis just so we can form argument memory locations!). However, we also have some delegation logic inside of BasicAA and some of it even makes sense. When the delegation logic is baking in specific knowledge of aliasing properties of the LLVM IR, as opposed to simply reformulating the query to utilize a different alias analysis interface entry point, it makes a lot of sense to restrict that logic to a different layer such as BasicAA. So one aspect of the delegation that was in every AA base class is that when we don't have operand bundles, we re-use function AA results as a fallback for callsite alias results. This relies on the IR properties of calls and functions w.r.t. aliasing, and so seems a better fit to BasicAA. I've lifted the logic up to that point where it seems to be a natural fit. This still does a bit of redundant work (we query function attributes twice, once via the callsite and once via the function AA query) but it is *exactly* twice here, no more. The end result is that all of the delegation logic is hoisted out of the base class and into either the aggregation layer when it is a pure retargeting to a different API surface, or into BasicAA when it relies on the IR's aliasing properties. This should fix the quadratic query pattern reported in PR26564, although I don't have a stand-alone test case to reproduce it. It also seems general goodness. Now the numerous AAs that don't need target library info don't carry it around and depend on it. I think I can even rip out the general access to the aggregation layer and only expose that in BasicAA as it is the only place where we re-query in that manner. However, this is a non-trivial change to the AA infrastructure so I want to get some additional eyes on this before it lands. Sadly, it can't wait long because we should really cherry pick this into 3.8 if we're going to go this route. Differential Revision: http://reviews.llvm.org/D17329 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@262490 91177308-0d34-0410-b5e6-96231b3b80d8
216 lines
8.1 KiB
C++
216 lines
8.1 KiB
C++
//===- BasicAliasAnalysis.h - Stateless, local Alias Analysis ---*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
/// \file
|
|
/// This is the interface for LLVM's primary stateless and local alias analysis.
|
|
///
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_ANALYSIS_BASICALIASANALYSIS_H
|
|
#define LLVM_ANALYSIS_BASICALIASANALYSIS_H
|
|
|
|
#include "llvm/ADT/SmallPtrSet.h"
|
|
#include "llvm/Analysis/AliasAnalysis.h"
|
|
#include "llvm/Analysis/AssumptionCache.h"
|
|
#include "llvm/Analysis/TargetLibraryInfo.h"
|
|
#include "llvm/IR/Function.h"
|
|
#include "llvm/IR/GetElementPtrTypeIterator.h"
|
|
#include "llvm/IR/Instruction.h"
|
|
#include "llvm/IR/LLVMContext.h"
|
|
#include "llvm/IR/Module.h"
|
|
#include "llvm/IR/PassManager.h"
|
|
#include "llvm/Support/ErrorHandling.h"
|
|
|
|
namespace llvm {
|
|
class AssumptionCache;
|
|
class DominatorTree;
|
|
class LoopInfo;
|
|
|
|
/// This is the AA result object for the basic, local, and stateless alias
|
|
/// analysis. It implements the AA query interface in an entirely stateless
|
|
/// manner. As one consequence, it is never invalidated. While it does retain
|
|
/// some storage, that is used as an optimization and not to preserve
|
|
/// information from query to query.
|
|
class BasicAAResult : public AAResultBase<BasicAAResult> {
|
|
friend AAResultBase<BasicAAResult>;
|
|
|
|
const DataLayout &DL;
|
|
const TargetLibraryInfo &TLI;
|
|
AssumptionCache &AC;
|
|
DominatorTree *DT;
|
|
LoopInfo *LI;
|
|
|
|
public:
|
|
BasicAAResult(const DataLayout &DL, const TargetLibraryInfo &TLI,
|
|
AssumptionCache &AC, DominatorTree *DT = nullptr,
|
|
LoopInfo *LI = nullptr)
|
|
: AAResultBase(), DL(DL), TLI(TLI), AC(AC), DT(DT), LI(LI) {}
|
|
|
|
BasicAAResult(const BasicAAResult &Arg)
|
|
: AAResultBase(Arg), DL(Arg.DL), TLI(Arg.TLI), AC(Arg.AC), DT(Arg.DT),
|
|
LI(Arg.LI) {}
|
|
BasicAAResult(BasicAAResult &&Arg)
|
|
: AAResultBase(std::move(Arg)), DL(Arg.DL), TLI(Arg.TLI), AC(Arg.AC),
|
|
DT(Arg.DT), LI(Arg.LI) {}
|
|
|
|
/// Handle invalidation events from the new pass manager.
|
|
///
|
|
/// By definition, this result is stateless and so remains valid.
|
|
bool invalidate(Function &, const PreservedAnalyses &) { return false; }
|
|
|
|
AliasResult alias(const MemoryLocation &LocA, const MemoryLocation &LocB);
|
|
|
|
ModRefInfo getModRefInfo(ImmutableCallSite CS, const MemoryLocation &Loc);
|
|
|
|
ModRefInfo getModRefInfo(ImmutableCallSite CS1, ImmutableCallSite CS2);
|
|
|
|
/// Chases pointers until we find a (constant global) or not.
|
|
bool pointsToConstantMemory(const MemoryLocation &Loc, bool OrLocal);
|
|
|
|
/// Get the location associated with a pointer argument of a callsite.
|
|
ModRefInfo getArgModRefInfo(ImmutableCallSite CS, unsigned ArgIdx);
|
|
|
|
/// Returns the behavior when calling the given call site.
|
|
FunctionModRefBehavior getModRefBehavior(ImmutableCallSite CS);
|
|
|
|
/// Returns the behavior when calling the given function. For use when the
|
|
/// call site is not known.
|
|
FunctionModRefBehavior getModRefBehavior(const Function *F);
|
|
|
|
private:
|
|
// A linear transformation of a Value; this class represents ZExt(SExt(V,
|
|
// SExtBits), ZExtBits) * Scale + Offset.
|
|
struct VariableGEPIndex {
|
|
|
|
// An opaque Value - we can't decompose this further.
|
|
const Value *V;
|
|
|
|
// We need to track what extensions we've done as we consider the same Value
|
|
// with different extensions as different variables in a GEP's linear
|
|
// expression;
|
|
// e.g.: if V == -1, then sext(x) != zext(x).
|
|
unsigned ZExtBits;
|
|
unsigned SExtBits;
|
|
|
|
int64_t Scale;
|
|
|
|
bool operator==(const VariableGEPIndex &Other) const {
|
|
return V == Other.V && ZExtBits == Other.ZExtBits &&
|
|
SExtBits == Other.SExtBits && Scale == Other.Scale;
|
|
}
|
|
|
|
bool operator!=(const VariableGEPIndex &Other) const {
|
|
return !operator==(Other);
|
|
}
|
|
};
|
|
|
|
/// Track alias queries to guard against recursion.
|
|
typedef std::pair<MemoryLocation, MemoryLocation> LocPair;
|
|
typedef SmallDenseMap<LocPair, AliasResult, 8> AliasCacheTy;
|
|
AliasCacheTy AliasCache;
|
|
|
|
/// Tracks phi nodes we have visited.
|
|
///
|
|
/// When interpret "Value" pointer equality as value equality we need to make
|
|
/// sure that the "Value" is not part of a cycle. Otherwise, two uses could
|
|
/// come from different "iterations" of a cycle and see different values for
|
|
/// the same "Value" pointer.
|
|
///
|
|
/// The following example shows the problem:
|
|
/// %p = phi(%alloca1, %addr2)
|
|
/// %l = load %ptr
|
|
/// %addr1 = gep, %alloca2, 0, %l
|
|
/// %addr2 = gep %alloca2, 0, (%l + 1)
|
|
/// alias(%p, %addr1) -> MayAlias !
|
|
/// store %l, ...
|
|
SmallPtrSet<const BasicBlock *, 8> VisitedPhiBBs;
|
|
|
|
/// Tracks instructions visited by pointsToConstantMemory.
|
|
SmallPtrSet<const Value *, 16> Visited;
|
|
|
|
static const Value *
|
|
GetLinearExpression(const Value *V, APInt &Scale, APInt &Offset,
|
|
unsigned &ZExtBits, unsigned &SExtBits,
|
|
const DataLayout &DL, unsigned Depth, AssumptionCache *AC,
|
|
DominatorTree *DT, bool &NSW, bool &NUW);
|
|
|
|
static const Value *
|
|
DecomposeGEPExpression(const Value *V, int64_t &BaseOffs,
|
|
SmallVectorImpl<VariableGEPIndex> &VarIndices,
|
|
bool &MaxLookupReached, const DataLayout &DL,
|
|
AssumptionCache *AC, DominatorTree *DT);
|
|
/// \brief A Heuristic for aliasGEP that searches for a constant offset
|
|
/// between the variables.
|
|
///
|
|
/// GetLinearExpression has some limitations, as generally zext(%x + 1)
|
|
/// != zext(%x) + zext(1) if the arithmetic overflows. GetLinearExpression
|
|
/// will therefore conservatively refuse to decompose these expressions.
|
|
/// However, we know that, for all %x, zext(%x) != zext(%x + 1), even if
|
|
/// the addition overflows.
|
|
bool
|
|
constantOffsetHeuristic(const SmallVectorImpl<VariableGEPIndex> &VarIndices,
|
|
uint64_t V1Size, uint64_t V2Size, int64_t BaseOffset,
|
|
AssumptionCache *AC, DominatorTree *DT);
|
|
|
|
bool isValueEqualInPotentialCycles(const Value *V1, const Value *V2);
|
|
|
|
void GetIndexDifference(SmallVectorImpl<VariableGEPIndex> &Dest,
|
|
const SmallVectorImpl<VariableGEPIndex> &Src);
|
|
|
|
AliasResult aliasGEP(const GEPOperator *V1, uint64_t V1Size,
|
|
const AAMDNodes &V1AAInfo, const Value *V2,
|
|
uint64_t V2Size, const AAMDNodes &V2AAInfo,
|
|
const Value *UnderlyingV1, const Value *UnderlyingV2);
|
|
|
|
AliasResult aliasPHI(const PHINode *PN, uint64_t PNSize,
|
|
const AAMDNodes &PNAAInfo, const Value *V2,
|
|
uint64_t V2Size, const AAMDNodes &V2AAInfo);
|
|
|
|
AliasResult aliasSelect(const SelectInst *SI, uint64_t SISize,
|
|
const AAMDNodes &SIAAInfo, const Value *V2,
|
|
uint64_t V2Size, const AAMDNodes &V2AAInfo);
|
|
|
|
AliasResult aliasCheck(const Value *V1, uint64_t V1Size, AAMDNodes V1AATag,
|
|
const Value *V2, uint64_t V2Size, AAMDNodes V2AATag);
|
|
};
|
|
|
|
/// Analysis pass providing a never-invalidated alias analysis result.
|
|
struct BasicAA : AnalysisBase<BasicAA> {
|
|
typedef BasicAAResult Result;
|
|
|
|
BasicAAResult run(Function &F, AnalysisManager<Function> *AM);
|
|
};
|
|
|
|
/// Legacy wrapper pass to provide the BasicAAResult object.
|
|
class BasicAAWrapperPass : public FunctionPass {
|
|
std::unique_ptr<BasicAAResult> Result;
|
|
|
|
virtual void anchor();
|
|
|
|
public:
|
|
static char ID;
|
|
|
|
BasicAAWrapperPass();
|
|
|
|
BasicAAResult &getResult() { return *Result; }
|
|
const BasicAAResult &getResult() const { return *Result; }
|
|
|
|
bool runOnFunction(Function &F) override;
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override;
|
|
};
|
|
|
|
FunctionPass *createBasicAAWrapperPass();
|
|
|
|
/// A helper for the legacy pass manager to create a \c BasicAAResult object
|
|
/// populated to the best of our ability for a particular function when inside
|
|
/// of a \c ModulePass or a \c CallGraphSCCPass.
|
|
BasicAAResult createLegacyPMBasicAAResult(Pass &P, Function &F);
|
|
}
|
|
|
|
#endif
|