Revert test polarity to match comment and desired outcome. Remove undeserved bonus.

A GEP with all constant indices is already considered free by
analyzeBasicBlock(), so don't give it an extra bonus in
CountCodeReductionForAlloca().

This patch should remove a small positive bias toward inlining functions with
variable-index GEPs, and remove a smaller negative bias from functions with
all-constant index GEPs.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@94591 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Jakob Stoklund Olesen 2010-01-26 21:31:35 +00:00
parent 2cd455f363
commit 026ac3ada5

View File

@ -87,8 +87,8 @@ unsigned InlineCostAnalyzer::FunctionInfo::
Reduction += 10;
else if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(I)) {
// If the GEP has variable indices, we won't be able to do much with it.
if (!GEP->hasAllConstantIndices())
Reduction += CountCodeReductionForAlloca(GEP)+15;
if (GEP->hasAllConstantIndices())
Reduction += CountCodeReductionForAlloca(GEP);
} else {
// If there is some other strange instruction, we're not going to be able
// to do much if we inline this.