RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-12-12 06:06:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[StatepointLowering] Minor nfc refactoring

Browse Source 
Now that StatepointLoweringInfo represents base pointers, derived
pointers and gc relocates as SmallVectors and not ArrayRefs, we no
longer need to allocate "backing storage" on stack in LowerStatepoint.
So elide the backing storage, and inline the trivial body of
getIncomingStatepointGCValues.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@264128 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Sanjoy Das 2016-03-23 02:24:10 +00:00
parent 5fb8106b47
commit 0479e1aad2
1 changed files with 6 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
lib/CodeGen/SelectionDAG/StatepointLowering.cpp
View File

@ -317,26 +317,6 @@ static std::pair<SDValue, SDNode *> lowerCallFromStatepointLoweringInfo(
return std::make_pair(ReturnValue, CallEnd->getOperand(0).getNode()); return std::make_pair(ReturnValue, CallEnd->getOperand(0).getNode());
} }
/// Callect all gc pointers coming into statepoint intrinsic, clean them up,
/// and return two arrays:
/// Bases - base pointers incoming to this statepoint
/// Ptrs - derived pointers incoming to this statepoint
/// Relocs - the gc_relocate corresponding to each base/ptr pair
/// Elements of this arrays should be in one-to-one correspondence with each
/// other i.e Bases[i], Ptrs[i] are from the same gcrelocate call
static void getIncomingStatepointGCValues(
SmallVectorImpl<const Value *> &Bases, SmallVectorImpl<const Value *> &Ptrs,
SmallVectorImpl<const GCRelocateInst *> &Relocs,
ImmutableStatepoint StatepointSite, SelectionDAGBuilder &Builder) {
for (const GCRelocateInst *Relocate : StatepointSite.getRelocates()) {
Relocs.push_back(Relocate);
Bases.push_back(Relocate->getBasePtr());
Ptrs.push_back(Relocate->getDerivedPtr());
}
assert(Bases.size() == Ptrs.size() && Ptrs.size() == Relocs.size());
}
/// Spill a value incoming to the statepoint. It might be either part of /// Spill a value incoming to the statepoint. It might be either part of
/// vmstate /// vmstate
/// or gcstate. In both cases unconditionally spill it on the stack unless it /// or gcstate. In both cases unconditionally spill it on the stack unless it
@ -746,12 +726,6 @@ SDValue SelectionDAGBuilder::LowerAsSTATEPOINT(
void void
SelectionDAGBuilder::LowerStatepoint(ImmutableStatepoint ISP, SelectionDAGBuilder::LowerStatepoint(ImmutableStatepoint ISP,
const BasicBlock *EHPadBB /*= nullptr*/) { const BasicBlock *EHPadBB /*= nullptr*/) {
SmallVector<const Value *, 16> Bases;
SmallVector<const Value *, 16> Ptrs;
SmallVector<const GCRelocateInst *, 16> GCRelocates;
getIncomingStatepointGCValues(Bases, Ptrs, GCRelocates, ISP, *this);
assert(ISP.getCallSite().getCallingConv() != CallingConv::AnyReg && assert(ISP.getCallSite().getCallingConv() != CallingConv::AnyReg &&
"anyregcc is not supported on statepoints!"); "anyregcc is not supported on statepoints!");
@ -790,9 +764,12 @@ SelectionDAGBuilder::LowerStatepoint(ImmutableStatepoint ISP,
ISP.getNumCallArgs(), ActualCallee, ISP.getNumCallArgs(), ActualCallee,
ISP.getActualReturnType(), false /* IsPatchPoint */); ISP.getActualReturnType(), false /* IsPatchPoint */);
SI.Bases = Bases; for (const GCRelocateInst *Relocate : ISP.getRelocates()) {
SI.Ptrs = Ptrs; SI.GCRelocates.push_back(Relocate);
SI.GCRelocates = GCRelocates; SI.Bases.push_back(Relocate->getBasePtr());
SI.Ptrs.push_back(Relocate->getDerivedPtr());
}
SI.GCArgs = ArrayRef<const Use>(ISP.gc_args_begin(), ISP.gc_args_end()); SI.GCArgs = ArrayRef<const Use>(ISP.gc_args_begin(), ISP.gc_args_end());
SI.StatepointInstr = ISP.getInstruction(); SI.StatepointInstr = ISP.getInstruction();
SI.GCTransitionArgs = SI.GCTransitionArgs =