RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2025-02-13 17:20:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix accidental fallthrough in DebugLocEntry::hasSameValueOrLocation

Browse Source 
No test case (this would invoke UB by examining uninitialized members,
etc, at best - and this code is apparently untested anyway - I'm about
to fix that)

Code review feedback from Adrian Prantl on r205360.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@205367 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Blaikie 2014-04-01 22:25:09 +00:00
parent 2e33edd399
commit 0afa71ea91
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/CodeGen/AsmPrinter/DebugLocEntry.h
View File

@ -46,18 +46,23 @@ class DebugLocEntry {
if (EntryKind != Next.EntryKind)
return false;
bool EqualValues;
switch (EntryKind) {
case E_Location:
if (Loc != Next.Loc) return false;
EqualValues = Loc == Next.Loc;
break;
case E_Integer:
if (Constants.Int != Next.Constants.Int) return false;
EqualValues = Constants.Int == Next.Constants.Int;
break;
case E_ConstantFP:
if (Constants.CFP != Next.Constants.CFP) return false;
EqualValues = Constants.CFP == Next.Constants.CFP;
break;
case E_ConstantInt:
if (Constants.CIP != Next.Constants.CIP) return false;
EqualValues = Constants.CIP == Next.Constants.CIP;
break;
}
return true;
return EqualValues;
}
public: