RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-11-24 12:19:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make the getNamedFunction and getNamedGlobal methods be const. They don't

Browse Source 
change the module in any way and we should enforce that.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@28588 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Reid Spencer 2006-05-31 16:40:28 +00:00
parent e2e83c9994
commit 0b2375edfe
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/llvm/Module.h
View File

@ -179,7 +179,7 @@ public:
/// getNamedFunction - Return the first function in the module with the
/// specified name, of arbitrary type. This method returns null if a function
/// with the specified name is not found.
Function *getNamedFunction(const std::string &Name);
Function *getNamedFunction(const std::string &Name) const;
/// @}
/// @name Global Variable Accessors
@ -197,7 +197,7 @@ public:
/// getNamedGlobal - Return the first global variable in the module with the
/// specified name, of arbitrary type. This method returns null if a global
/// with the specified name is not found.
GlobalVariable *getNamedGlobal(const std::string &Name);
GlobalVariable *getNamedGlobal(const std::string &Name) const;
/// @}
/// @name Type Accessors

16
lib/VMCore/Module.cpp
View File

@ -250,16 +250,16 @@ Function *Module::getMainFunction() {
/// specified name, of arbitrary type. This method returns null if a function
/// with the specified name is not found.
///
Function *Module::getNamedFunction(const std::string &Name) {
Function *Module::getNamedFunction(const std::string &Name) const {
// Loop over all of the functions, looking for the function desired
Function *Found = 0;
for (iterator I = begin(), E = end(); I != E; ++I)
const Function *Found = 0;
for (const_iterator I = begin(), E = end(); I != E; ++I)
if (I->getName() == Name)
if (I->isExternal())
Found = I;
else
return I;
return Found; // Non-external function not found...
return const_cast<Function*>(&(*I));
return const_cast<Function*>(Found); // Non-external function not found...
}
//===----------------------------------------------------------------------===//
@ -287,13 +287,13 @@ GlobalVariable *Module::getGlobalVariable(const std::string &Name,
/// specified name, of arbitrary type. This method returns null if a global
/// with the specified name is not found.
///
GlobalVariable *Module::getNamedGlobal(const std::string &Name) {
GlobalVariable *Module::getNamedGlobal(const std::string &Name) const {
// FIXME: This would be much faster with a symbol table that doesn't
// discriminate based on type!
for (global_iterator I = global_begin(), E = global_end();
for (const_global_iterator I = global_begin(), E = global_end();
I != E; ++I)
if (I->getName() == Name)
return I;
return const_cast<GlobalVariable*>(&(*I));
return 0;
}