RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-12-14 15:39:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Prevent transformConstExprCastCall from generating conversions that assert

Browse Source 
elsewhere.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@35668 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Dale Johannesen 2007-04-04 19:16:42 +00:00
parent 8d8e1eb284
commit 16ff304e2c
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
lib/Transforms/Scalar/InstructionCombining.cpp
View File

@ -7469,6 +7469,7 @@ bool InstCombiner::transformConstExprCastCall(CallSite CS) {
const Type *ParamTy = FT->getParamType(i);
const Type *ActTy = (*AI)->getType();
ConstantInt *c = dyn_cast<ConstantInt>(*AI);
//Some conversions are safe even if we do not have a body.
//Either we can cast directly, or we can upconvert the argument
bool isConvertible = ActTy == ParamTy ||
(isa<PointerType>(ParamTy) && isa<PointerType>(ActTy)) ||
@ -7477,6 +7478,40 @@ bool InstCombiner::transformConstExprCastCall(CallSite CS) {
(c && ParamTy->getPrimitiveSizeInBits() >= ActTy->getPrimitiveSizeInBits()
&& c->getValue().isStrictlyPositive());
if (Callee->isDeclaration() && !isConvertible) return false;
// Most other conversions can be done if we have a body, even if these
// lose information, e.g. int->short.
// Some conversions cannot be done at all, e.g. float to pointer.
// Logic here parallels CastInst::getCastOpcode (the design there
// requires legality checks like this be done before calling it).
if (ParamTy->isInteger()) {
if (const VectorType *VActTy = dyn_cast<VectorType>(ActTy)) {
if (VActTy->getBitWidth() != ParamTy->getPrimitiveSizeInBits())
return false;
}
if (!ActTy->isInteger() && !ActTy->isFloatingPoint() &&
!isa<PointerType>(ActTy))
return false;
} else if (ParamTy->isFloatingPoint()) {
if (const VectorType *VActTy = dyn_cast<VectorType>(ActTy)) {
if (VActTy->getBitWidth() != ParamTy->getPrimitiveSizeInBits())
return false;
}
if (!ActTy->isInteger() && !ActTy->isFloatingPoint())
return false;
} else if (const VectorType *VParamTy = dyn_cast<VectorType>(ParamTy)) {
if (const VectorType *VActTy = dyn_cast<VectorType>(ActTy)) {
if (VActTy->getBitWidth() != VParamTy->getBitWidth())
return false;
}
if (VParamTy->getBitWidth() != ActTy->getPrimitiveSizeInBits())
return false;
} else if (isa<PointerType>(ParamTy)) {
if (!ActTy->isInteger() && !isa<PointerType>(ActTy))
return false;
} else {
return false;
}
}
if (FT->getNumParams() < NumActualArgs && !FT->isVarArg() &&