RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-12-27 22:55:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add kill flag verification.

Browse Source 
At least X86FloatingPoint requires correct kill flags after register allocation,
and targets using register scavenging benefit. Conservative kill flags are not
enough.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@117960 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Jakob Stoklund Olesen 2010-11-01 21:51:31 +00:00
parent 79cb53ce95
commit 1c163d2a06
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/CodeGen/MachineVerifier.cpp
View File

@ -589,7 +589,7 @@ MachineVerifier::visitMachineOperand(const MachineOperand *MO, unsigned MONum) {
unsigned DefReg = MI->getOperand(defIdx).getReg(); unsigned DefReg = MI->getOperand(defIdx).getReg();
if (Reg == DefReg) { if (Reg == DefReg) {
isKill = true; isKill = true;
// ANd in that case an explicit kill flag is not allowed. // And in that case an explicit kill flag is not allowed.
if (MO->isKill()) if (MO->isKill())
report("Illegal kill flag on two-address instruction operand", report("Illegal kill flag on two-address instruction operand",
MO, MONum); MO, MONum);
@ -622,7 +622,18 @@ MachineVerifier::visitMachineOperand(const MachineOperand *MO, unsigned MONum) {
report("No live range at use", MO, MONum); report("No live range at use", MO, MONum);
*OS << UseIdx << " is not live in " << LI << '\n'; *OS << UseIdx << " is not live in " << LI << '\n';
} }
// TODO: Verify isKill == LI.killedAt. // Verify isKill == LI.killedAt.
if (!MI->isRegTiedToDefOperand(MONum)) {
bool liKill = LI.killedAt(UseIdx.getDefIndex());
if (isKill && !liKill) {
report("Live range continues after kill flag", MO, MONum);
*OS << "Live range: " << LI << '\n';
}
if (!isKill && liKill) {
report("Live range ends without kill flag", MO, MONum);
*OS << "Live range: " << LI << '\n';
}
}
} else { } else {
report("Virtual register has no Live interval", MO, MONum); report("Virtual register has no Live interval", MO, MONum);
} }