RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2025-02-03 11:08:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[InstCombine] Don't insert instructions before a catch switch

Browse Source 
CatchSwitches are not splittable, we cannot insert casts, etc. before
them.

This fixes PR26992.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@263874 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Majnemer 2016-03-19 04:39:52 +00:00
parent 4392249e77
commit 20e3af6f8a
2 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/Transforms/InstCombine/InstCombineCompares.cpp
View File

@ -661,6 +661,9 @@ static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
}
if (auto *PN = dyn_cast<PHINode>(V)) {
// We cannot transform PHIs on unsplittable basic blocks.
if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
return false;
Explored.insert(PN);
PHIs.insert(PN);
}

37
test/Transforms/InstCombine/pr26992.ll Normal file
View File

@ -0,0 +1,37 @@
; RUN: opt -instcombine -S < %s | FileCheck %s
target triple = "x86_64-pc-windows-msvc"
define i1 @test1(i8* %p) personality i32 (...)* @__CxxFrameHandler3 {
entry:
%a = getelementptr i8, i8* %p, i64 1
invoke void @may_throw()
to label %invoke.cont unwind label %catch.dispatch
invoke.cont:
%b = getelementptr inbounds i8, i8* %a, i64 1
invoke void @may_throw()
to label %exit unwind label %catch.dispatch
catch.dispatch:
%c = phi i8* [ %b, %invoke.cont ], [ %a, %entry ]
%tmp1 = catchswitch within none [label %catch] unwind to caller
catch:
%tmp2 = catchpad within %tmp1 [i8* null, i32 64, i8* null]
catchret from %tmp2 to label %exit
exit:
%d = phi i8* [ %a, %invoke.cont ], [ %c, %catch ]
%cmp = icmp eq i8* %d, %a
ret i1 %cmp
}
; CHECK-LABEL: define i1 @test1(
; CHECK: %[[gep_a:.*]] = getelementptr i8, i8* %p, i64 1
; CHECK: %[[gep_b:.*]] = getelementptr inbounds i8, i8* %p, i64 2
; CHECK: phi i8* [ %[[gep_b]], {{.*}} ], [ %[[gep_a]], {{.*}} ]
; CHECK: %tmp1 = catchswitch within none [label %catch] unwind to caller
declare void @may_throw()
declare i32 @__CxxFrameHandler3(...)