RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2025-05-13 10:56:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use WeakVH instead of WeakTrackingVH in AliasSetTracker's UnkownInsts

Browse Source 
In cases where an instruction (a call site, say) is RAUW'ed with some
other value (this is possible via the `returned` attribute, for
instance), we want the slot in UnknownInsts to point to the original
Instruction we wanted to track, not the value it got replaced by.

Fixes PR32587.

This relands r301426.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@301814 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Sanjoy Das 2017-05-01 17:07:56 +00:00
parent 41673c62ec
commit 2602782e16
2 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/llvm/Analysis/AliasSetTracker.h
View File

@ -121,10 +121,10 @@ class AliasSet : public ilist_node<AliasSet> {
AliasSet *Forward;
/// All instructions without a specific address in this alias set.
/// In rare cases this vector can have a null'ed out WeakTrackingVH
/// In rare cases this vector can have a null'ed out WeakVH
/// instances (can happen if some other loop pass deletes an
/// instruction in this list).
std::vector<WeakTrackingVH> UnknownInsts;
std::vector<WeakVH> UnknownInsts;
/// Number of nodes pointing to this AliasSet plus the number of AliasSets
/// forwarding to it.

25
test/Analysis/AliasSet/unknown-inst-tracking.ll Normal file
View File

@ -0,0 +1,25 @@
; RUN: opt -S -licm -loop-unswitch < %s | FileCheck %s
; This test checks for a crash. See PR32587.
@global = external global i32
declare i32 @f_1(i8, i32 returned)
define i32 @f_0() {
; CHECK-LABEL: @f_0(
bb:
br label %bb1
bb1: ; preds = %bb3, %bb
%tmp = load i32, i32* @global
%tmp2 = select i1 false, i16 1, i16 0
br label %bb3
bb3: ; preds = %bb3, %bb1
%tmp4 = phi i8 [ 0, %bb1 ], [ %tmp6, %bb3 ]
%tmp5 = icmp eq i16 %tmp2, 0
%tmp6 = select i1 %tmp5, i8 %tmp4, i8 1
%tmp7 = tail call i32 @f_1(i8 %tmp6, i32 1)
br i1 false, label %bb1, label %bb3
}