RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2025-05-13 10:56:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[mips] Parse the 'bopt' and 'nobopt' directives in IAS.

Browse Source 
The GAS assembler supports the ".set bopt" directive but according
to the sources it doesn't do anything. It's supposed to optimize
branches by filling the delay slot of a branch with it's target.

This patch teaches the MIPS asm parser to accept both and warn in
the case of 'bopt' that the bopt directive is unsupported.

This resolves PR/31841.

Thanks to Sean Bruno for reporting the issue!



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@293798 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Simon Dardis 2017-02-01 18:50:24 +00:00
parent 8d4b01ecc0
commit 28f9c9871d
2 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/Target/Mips/AsmParser/MipsAsmParser.cpp
View File

@ -6030,6 +6030,14 @@ bool MipsAsmParser::parseDirectiveSet() {
return parseSetAtDirective();
} else if (Tok.getString() == "arch") {
return parseSetArchDirective();
} else if (Tok.getString() == "bopt") {
Warning(Tok.getLoc(), "'bopt' feature is unsupported");
getParser().Lex();
return false;
} else if (Tok.getString() == "nobopt") {
// We're already running in nobopt mode, so nothing to do.
getParser().Lex();
return false;
} else if (Tok.getString() == "fp") {
return parseSetFpDirective();
} else if (Tok.getString() == "oddspreg") {

16
test/MC/Mips/bopt-directive.s Normal file
View File

@ -0,0 +1,16 @@
# RUN: llvm-mc -arch=mips -mcpu=mips32 %s 2>&1 | FileCheck %s
# We don't support the bopt option in the integrated assembler. Given it's
# single pass nature, it would be quite difficult to implement currently.
# Ensure we parse the bopt & nobopt directives and warn in the bopt case.
# CHECK: warning: 'bopt' feature is unsupported
# CHECK: nop
.text
f:
.set bopt
g:
.set nobopt
nop