RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2025-02-02 10:32:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Simplify since this function never fails.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@254667 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Rafael Espindola 2015-12-03 23:56:42 +00:00
parent 922e9787e6
commit 34254063b5
2 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/llvm/LTO/LTOModule.h
View File

@ -170,7 +170,7 @@ private:
/// Parse the symbols from the module and model-level ASM and add them to
/// either the defined or undefined lists.
bool parseSymbols(std::string &errMsg);
void parseSymbols();
/// Add a symbol which isn't defined just yet to a list to be resolved later.
void addPotentialUndefinedSymbol(const object::BasicSymbolRef &Sym,

12
lib/LTO/LTOModule.cpp
View File

@ -252,11 +252,7 @@ LTOModule *LTOModule::makeLTOModule(MemoryBufferRef Buffer,
else
Ret = new LTOModule(std::move(IRObj), target);
if (Ret->parseSymbols(errMsg)) {
delete Ret;
return nullptr;
}
Ret->parseSymbols();
Ret->parseMetadata();
return Ret;
@ -592,9 +588,7 @@ void LTOModule::addPotentialUndefinedSymbol(const object::BasicSymbolRef &Sym,
info.symbol = decl;
}
/// parseSymbols - Parse the symbols from the module and model-level ASM and add
/// them to either the defined or undefined lists.
bool LTOModule::parseSymbols(std::string &errMsg) {
void LTOModule::parseSymbols() {
for (auto &Sym : IRFile->symbols()) {
const GlobalValue *GV = IRFile->getSymbolGV(Sym.getRawDataRefImpl());
uint32_t Flags = Sym.getFlags();
@ -649,8 +643,6 @@ bool LTOModule::parseSymbols(std::string &errMsg) {
NameAndAttributes info = u->getValue();
_symbols.push_back(info);
}
return false;
}
/// parseMetadata - Parse metadata from the module