RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-11-29 14:40:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert r122114 (CallbackVH observing use-list changes) because it caused severe slowdowns on the Linux self-host configuration.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@122279 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Owen Anderson 2010-12-20 22:28:03 +00:00
parent 672fb6225b
commit 3b77f56194
3 changed files with 1 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/llvm/Support/ValueHandle.h
View File

@ -105,7 +105,6 @@ private:
// Callbacks made from Value.
static void ValueIsDeleted(Value *V);
static void ValueIsRAUWd(Value *Old, Value *New);
static void ValueAddedUse(Use &U);
// Internal implementation details.
ValueHandleBase **getPrevPtr() const { return PrevPair.getPointer(); }
@ -390,11 +389,6 @@ public:
/// implemented as a CallbackVH, it would use this method to call
/// setValPtr(new_value). AssertingVH would do nothing in this method.
virtual void allUsesReplacedWith(Value *) {}
/// Called when a new Use is added to the use-list of this->getValPtr(),
/// after the Use has been appended to the list. Other VH kinds would ignore
/// this callback, but clients can use it to trigger re-analysis of Values.
virtual void addedUse(Use &) {}
};
// Specialize simplify_type to allow CallbackVH to participate in

2
include/llvm/Value.h
View File

@ -195,7 +195,7 @@ public:
/// addUse - This method should only be used by the Use class.
///
void addUse(Use &U);
void addUse(Use &U) { U.addToList(&UseList); }
/// An enumeration for keeping track of the concrete subclass of Value that
/// is actually instantiated. Values of this enumeration are kept in the

38
lib/VMCore/Value.cpp
View File

@ -281,16 +281,6 @@ void Value::takeName(Value *V) {
}
/// addUse - This method should only be used by the Use class.
///
void Value::addUse(Use &U) {
U.addToList(&UseList);
// Notify all ValueHandles (if present) that this value added a Use.
if (HasValueHandle)
ValueHandleBase::ValueAddedUse(U);
}
// uncheckedReplaceAllUsesWith - This is exactly the same as replaceAllUsesWith,
// except that it doesn't have all of the asserts. The asserts fail because we
// are half-way done resolving types, which causes some types to exist as two
@ -579,34 +569,6 @@ void ValueHandleBase::ValueIsDeleted(Value *V) {
}
}
void ValueHandleBase::ValueAddedUse(Use &U) {
assert(U->HasValueHandle && "Should only be called if ValueHandles present");
// Get the linked list base, which is guaranteed to exist since the
// HasValueHandle flag is set.
LLVMContextImpl *pImpl = U->getContext().pImpl;
ValueHandleBase *Entry = pImpl->ValueHandles[U.get()];
assert(Entry && "Value bit set but no entries exist");
// We use a local ValueHandleBase as an iterator so that
// ValueHandles can add and remove themselves from the list without
// breaking our iteration. This is not really an AssertingVH; we
// just have to give ValueHandleBase some kind.
for (ValueHandleBase Iterator(Assert, *Entry); Entry; Entry = Iterator.Next) {
Iterator.RemoveFromUseList();
Iterator.AddToExistingUseListAfter(Entry);
assert(Entry->Next == &Iterator && "Loop invariant broken.");
switch (Entry->getKind()) {
default:
break;
case Callback:
static_cast<CallbackVH*>(Entry)->addedUse(U);
break;
}
}
}
void ValueHandleBase::ValueIsRAUWd(Value *Old, Value *New) {
assert(Old->HasValueHandle &&"Should only be called if ValueHandles present");