RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-12-13 14:46:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Relax assert to avoid spurious failures with /dev/null.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@236106 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Rafael Espindola 2015-04-29 14:53:25 +00:00
parent 56d0e00515
commit 4389f0be73
2 changed files with 36 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
include/llvm/Support/raw_ostream.h
View File

@ -323,7 +323,13 @@ public:
explicit raw_pwrite_stream(bool Unbuffered = false)
: raw_ostream(Unbuffered) {}
void pwrite(const char *Ptr, size_t Size, uint64_t Offset) {
assert(Size + Offset <= tell() && "We don't support extending the stream");
#ifndef NDBEBUG
uint64_t Pos = tell();
// /dev/null always reports a pos of 0, so we cannot perform this check
// in that case.
if (Pos)
assert(Size + Offset <= Pos && "We don't support extending the stream");
#endif
pwrite_impl(Ptr, Size, Offset);
}
};

29
unittests/Support/raw_pwrite_stream_test.cpp
View File

@ -9,6 +9,7 @@
#include "gtest/gtest.h"
#include "llvm/ADT/SmallString.h"
#include "llvm/Support/FileSystem.h"
#include "llvm/Support/raw_ostream.h"
using namespace llvm;
@ -30,4 +31,32 @@ TEST(raw_pwrite_ostreamTest, TestSVector) {
#endif
#endif
}
TEST(raw_pwrite_ostreamTest, TestFD) {
SmallString<64> Path;
int FD;
sys::fs::createTemporaryFile("foo", "bar", FD, Path);
raw_fd_ostream OS(FD, true);
OS << "abcd";
StringRef Test = "test";
OS.pwrite(Test.data(), Test.size(), 0);
OS.pwrite(Test.data(), Test.size(), 0);
#ifdef GTEST_HAS_DEATH_TEST
#ifndef NDEBUG
EXPECT_DEATH(OS.pwrite("12345", 5, 0),
"We don't support extending the stream");
#endif
#endif
}
TEST(raw_pwrite_ostreamTest, TestDevNull) {
int FD;
sys::fs::openFileForWrite("/dev/null", FD, sys::fs::F_None);
raw_fd_ostream OS(FD, true);
OS << "abcd";
StringRef Test = "test";
OS.pwrite(Test.data(), Test.size(), 0);
OS.pwrite(Test.data(), Test.size(), 0);
}
}