RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-12-03 01:12:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Object/ELF] - Make getSymbol() return Error.

Browse Source 
That is consistent with other methods around
and helps to handle error on a caller side.

Differential revision: https://reviews.llvm.org/D26247

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@285886 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
George Rimar 2016-11-03 08:40:55 +00:00
parent 8186cc4fdc
commit 47d5d41c6b
3 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
include/llvm/Object/ELF.h
View File

@ -158,10 +158,11 @@ public:
ArrayRef<Elf_Word> ShndxTable) const;
ErrorOr<const Elf_Shdr *> getSection(uint32_t Index) const;
const Elf_Sym *getSymbol(const Elf_Shdr *Sec, uint32_t Index) const {
ErrorOr<const Elf_Sym *> getSymbol(const Elf_Shdr *Sec,
uint32_t Index) const {
Elf_Sym_Range Symbols = symbols(Sec);
if (Index >= Symbols.size())
report_fatal_error("Invalid symbol index");
return object_error::invalid_symbol_index;
return &Symbols[Index];
}

1
include/llvm/Object/Error.h
View File

@ -34,6 +34,7 @@ enum class object_error {
string_table_non_null_end,
invalid_section_index,
bitcode_section_not_found,
invalid_symbol_index,
};
inline std::error_code make_error_code(object_error e) {

2
lib/Object/Error.cpp
View File

@ -50,6 +50,8 @@ std::string _object_error_category::message(int EV) const {
return "Invalid section index";
case object_error::bitcode_section_not_found:
return "Bitcode section not found in object file";
case object_error::invalid_symbol_index:
return "Invalid symbol index";
}
llvm_unreachable("An enumerator of object_error does not have a message "
"defined.");