RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2025-02-03 19:15:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Coverage] Get rid of an input/output parameter (NFC)

Browse Source 
readFunctionRecords is used to iterate through the entries of the
coverage mapping section. Instead of expecting the function to update
the iterator through a `const char *&` parameter, just return the
updated iterator.

This will help us experiment with zlib-compressing coverage mapping
data.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@273052 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Vedant Kumar 2016-06-17 21:31:03 +00:00
parent 310a3752c0
commit 49f93f75af
1 changed files with 17 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
lib/ProfileData/Coverage/CoverageMappingReader.cpp
View File

@ -350,11 +350,15 @@ static Expected<bool> isCoverageMappingDummy(uint64_t Hash, StringRef Mapping) {
namespace {
struct CovMapFuncRecordReader {
// The interface to read coverage mapping function records for
// a module. \p Buf is a reference to the buffer pointer pointing
// to the \c CovHeader of coverage mapping data associated with
// the module.
virtual Error readFunctionRecords(const char *&Buf, const char *End) = 0;
// The interface to read coverage mapping function records for a module.
//
// \p Buf points to the buffer containing the \c CovHeader of the coverage
// mapping data associated with the module.
//
// Returns a pointer to the next \c CovHeader if it exists, or a pointer
// greater than \p End if not.
virtual Expected<const char *> readFunctionRecords(const char *Buf,
const char *End) = 0;
virtual ~CovMapFuncRecordReader() {}
template <class IntPtrT, support::endianness Endian>
static Expected<std::unique_ptr<CovMapFuncRecordReader>>
@ -430,7 +434,8 @@ public:
: ProfileNames(P), Filenames(F), Records(R) {}
~VersionedCovMapFuncRecordReader() override {}
Error readFunctionRecords(const char *&Buf, const char *End) override {
Expected<const char *> readFunctionRecords(const char *Buf,
const char *End) override {
using namespace support;
if (Buf + sizeof(CovMapHeader) > End)
return make_error<CoverageMapError>(coveragemap_error::malformed);
@ -452,7 +457,7 @@ public:
size_t FilenamesBegin = Filenames.size();
RawCoverageFilenamesReader Reader(StringRef(Buf, FilenamesSize), Filenames);
if (auto Err = Reader.read())
return Err;
return std::move(Err);
Buf += FilenamesSize;
// We'll read the coverage mapping records in the loop below.
@ -479,10 +484,10 @@ public:
if (Error Err =
insertFunctionRecordIfNeeded(CFR, Mapping, FilenamesBegin))
return Err;
return std::move(Err);
CFR++;
}
return Error::success();
return Buf;
}
};
} // end anonymous namespace
@ -526,8 +531,10 @@ static Error readCoverageMappingData(
return E;
auto Reader = std::move(ReaderExpected.get());
for (const char *Buf = Data.data(), *End = Buf + Data.size(); Buf < End;) {
if (Error E = Reader->readFunctionRecords(Buf, End))
auto NextHeaderOrErr = Reader->readFunctionRecords(Buf, End);
if (auto E = NextHeaderOrErr.takeError())
return E;
Buf = NextHeaderOrErr.get();
}
return Error::success();
}