X86: Do not produce GOT relocations on windows

Windows has no GOT relocations the way elf/darwin has. Some people use
x86_64-pc-win32-macho to build EFI firmware; Do not produce GOT
relocations for this target.

Differential Revision: https://reviews.llvm.org/D24627

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@283140 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Matthias Braun 2016-10-03 20:11:24 +00:00
parent f378e2727f
commit 4f52404044
2 changed files with 32 additions and 2 deletions

View File

@ -127,8 +127,11 @@ bool TargetMachine::shouldAssumeDSOLocal(const Module &M,
if (GV && GV->hasDLLImportStorageClass())
return false;
// Every other GV is local on COFF
if (TT.isOSBinFormatCOFF())
// Every other GV is local on COFF.
// Make an exception for windows OS in the triple: Some firmwares builds use
// *-win32-macho triples. This (accidentally?) produced windows relocations
// without GOT tables in older clang versions; Keep this behaviour.
if (TT.isOSBinFormatCOFF() || TT.isOSWindows())
return true;
if (GV && (GV->hasLocalLinkage() || !GV->hasDefaultVisibility()))

View File

@ -0,0 +1,27 @@
; RUN: llc -o - %s -relocation-model=pic | FileCheck %s
; Check that we do not get GOT relocations with the x86_64-pc-windows-macho
; triple.
target triple = "x86_64-pc-windows-macho"
@g = common global i32 0, align 4
declare i32 @extbar()
; CHECK-LABEL: bar:
; CHECK: callq _extbar
; CHECK: leaq _extbar(%rip),
; CHECK-NOT: @GOT
define i8* @bar() {
call i32 @extbar()
ret i8* bitcast (i32 ()* @extbar to i8*)
}
; CHECK-LABEL: foo:
; CHECK: callq _bar
; CHECK: movl _g(%rip),
; CHECK-NOT: @GOT
define i32 @foo() {
call i8* @bar()
%gval = load i32, i32* @g, align 4
ret i32 %gval
}