RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-11-26 13:10:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add a small gep optimization I noticed was missing while reading some IL.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@136585 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Rafael Espindola 2011-07-31 04:43:41 +00:00
parent c47690264a
commit 592ad6a82f
2 changed files with 33 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lib/Transforms/InstCombine/InstructionCombining.cpp
View File

@ -737,7 +737,15 @@ Type *InstCombiner::FindElementAtOffset(Type *Ty, int64_t Offset,
return Ty; return Ty;
} }
static bool shouldMergeGEPs(GEPOperator &GEP, GEPOperator &Src) {
// If this GEP has only 0 indices, it is the same pointer as
// Src. If Src is not a trivial GEP too, don't combine
// the indices.
if (GEP.hasAllZeroIndices() && !Src.hasAllZeroIndices() &&
!Src.hasOneUse())
return false;
return true;
}
Instruction *InstCombiner::visitGetElementPtrInst(GetElementPtrInst &GEP) { Instruction *InstCombiner::visitGetElementPtrInst(GetElementPtrInst &GEP) {
SmallVector<Value*, 8> Ops(GEP.op_begin(), GEP.op_end()); SmallVector<Value*, 8> Ops(GEP.op_begin(), GEP.op_end());
@ -785,21 +793,15 @@ Instruction *InstCombiner::visitGetElementPtrInst(GetElementPtrInst &GEP) {
// getelementptr instructions into a single instruction. // getelementptr instructions into a single instruction.
// //
if (GEPOperator *Src = dyn_cast<GEPOperator>(PtrOp)) { if (GEPOperator *Src = dyn_cast<GEPOperator>(PtrOp)) {
if (!shouldMergeGEPs(*cast<GEPOperator>(&GEP), *Src))
// If this GEP has only 0 indices, it is the same pointer as
// Src. If Src is not a trivial GEP too, don't combine
// the indices.
if (GEP.hasAllZeroIndices() && !Src->hasAllZeroIndices() &&
!Src->hasOneUse())
return 0; return 0;
// Note that if our source is a gep chain itself that we wait for that // Note that if our source is a gep chain itself that we wait for that
// chain to be resolved before we perform this transformation. This // chain to be resolved before we perform this transformation. This
// avoids us creating a TON of code in some cases. // avoids us creating a TON of code in some cases.
// if (GEPOperator *SrcGEP =
if (GetElementPtrInst *SrcGEP = dyn_cast<GEPOperator>(Src->getOperand(0)))
dyn_cast<GetElementPtrInst>(Src->getOperand(0))) if (SrcGEP->getNumOperands() == 2 && shouldMergeGEPs(*Src, *SrcGEP))
if (SrcGEP->getNumOperands() == 2)
return 0; // Wait until our source is folded to completion. return 0; // Wait until our source is folded to completion.
SmallVector<Value*, 8> Indices; SmallVector<Value*, 8> Indices;

20
test/Transforms/InstCombine/getelementptr.ll
View File

@ -472,3 +472,23 @@ entry:
; CHECK: @pr10322_f1 ; CHECK: @pr10322_f1
; CHECK: %tmp2 = getelementptr inbounds %pr10322_t* %arrayidx8, i64 0, i32 0 ; CHECK: %tmp2 = getelementptr inbounds %pr10322_t* %arrayidx8, i64 0, i32 0
} }
; Test that we combine the last two geps in this sequence, before we
; would wait for gep1 and gep2 to be combined and never combine 2 and 3.
%three_gep_t = type {i32}
%three_gep_t2 = type {%three_gep_t}
define void @three_gep_f(%three_gep_t2* %x) {
%gep1 = getelementptr %three_gep_t2* %x, i64 2
call void @three_gep_h(%three_gep_t2* %gep1)
%gep2 = getelementptr %three_gep_t2* %gep1, i64 0, i32 0
%gep3 = getelementptr %three_gep_t* %gep2, i64 0, i32 0
call void @three_gep_g(i32* %gep3)
; CHECK: @three_gep_f
; CHECK: %gep3 = getelementptr %three_gep_t2* %gep1, i64 0, i32 0, i32 0
ret void
}
declare void @three_gep_g(i32*)
declare void @three_gep_h(%three_gep_t2*)