API gardening: Rename FindAllocaDbgValue to findDbgValue (NFC)

and use have it use SmallVectorImpl.

There is nothing specific about allocas in this function.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@297643 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Adrian Prantl 2017-03-13 17:20:47 +00:00
parent 8b1d5b7371
commit 5a7c5f7c89
2 changed files with 8 additions and 12 deletions

View File

@ -49,8 +49,6 @@ class LazyValueInfo;
template<typename T> class SmallVectorImpl;
typedef SmallVector<DbgValueInst *, 1> DbgValueList;
//===----------------------------------------------------------------------===//
// Local constant propagation.
//
@ -284,8 +282,8 @@ bool LowerDbgDeclare(Function &F);
/// Finds the llvm.dbg.declare intrinsic corresponding to an alloca, if any.
DbgDeclareInst *FindAllocaDbgDeclare(Value *V);
/// Finds the llvm.dbg.value intrinsics corresponding to an alloca, if any.
void FindAllocaDbgValues(DbgValueList &DbgValues, Value *V);
/// Finds the llvm.dbg.value intrinsics describing a value, if any.
void findDbgValues(SmallVectorImpl<DbgValueInst *> &DbgValues, Value *V);
/// Replaces llvm.dbg.declare instruction when the address it describes
/// is replaced with a new value. If Deref is true, an additional DW_OP_deref is

View File

@ -1085,11 +1085,11 @@ static bool PhiHasDebugValue(DILocalVariable *DIVar,
// Since we can't guarantee that the original dbg.declare instrinsic
// is removed by LowerDbgDeclare(), we need to make sure that we are
// not inserting the same dbg.value intrinsic over and over.
DbgValueList DbgValues;
FindAllocaDbgValues(DbgValues, APN);
for (auto DVI : DbgValues) {
assert (DVI->getValue() == APN);
assert (DVI->getOffset() == 0);
SmallVector<DbgValueInst *, 1> DbgValues;
findDbgValues(DbgValues, APN);
for (auto *DVI : DbgValues) {
assert(DVI->getValue() == APN);
assert(DVI->getOffset() == 0);
if ((DVI->getVariable() == DIVar) && (DVI->getExpression() == DIExpr))
return true;
}
@ -1251,9 +1251,7 @@ DbgDeclareInst *llvm::FindAllocaDbgDeclare(Value *V) {
return nullptr;
}
/// FindAllocaDbgValues - Finds the llvm.dbg.value intrinsics describing the
/// alloca 'V', if any.
void llvm::FindAllocaDbgValues(DbgValueList &DbgValues, Value *V) {
void llvm::findDbgValues(SmallVectorImpl<DbgValueInst *> &DbgValues, Value *V) {
if (auto *L = LocalAsMetadata::getIfExists(V))
if (auto *MDV = MetadataAsValue::getIfExists(V->getContext(), L))
for (User *U : MDV->users())