mirror of
https://github.com/RPCSX/llvm.git
synced 2025-01-05 19:29:01 +00:00
Fix returned value for GVN: could return "false" even after modifying the IR
This bug would manifest in some very specific cases where all the following conditions are fullfilled: - GVN didn't remove block - The regular GVN iteration didn't change the IR - PRE is enabled - PRE will not split critical edge - The last instruction processed by PRE didn't change the IR Because the CallGraph PassManager relies on this returned value to decide if it needs to recompute a node after the execution of Function passes, not returning the right value can lead to unexpected results. Fix for: https://llvm.org/bugs/show_bug.cgi?id=24715 Patch by Wenxiang Qiu <vincentqiuuu@gmail.com> From: Mehdi Amini <mehdi.amini@apple.com> git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@253518 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
8fa8f201ac
commit
5b7b529be0
@ -2709,7 +2709,7 @@ bool GVN::performPRE(Function &F) {
|
||||
BE = CurrentBlock->end();
|
||||
BI != BE;) {
|
||||
Instruction *CurInst = &*BI++;
|
||||
Changed = performScalarPRE(CurInst);
|
||||
Changed |= performScalarPRE(CurInst);
|
||||
}
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user