diff --git a/lib/Target/PowerPC/PPCFastISel.cpp b/lib/Target/PowerPC/PPCFastISel.cpp index 91646ad5a5f..99aa4eaf643 100644 --- a/lib/Target/PowerPC/PPCFastISel.cpp +++ b/lib/Target/PowerPC/PPCFastISel.cpp @@ -152,7 +152,7 @@ class PPCFastISel final : public FastISel { unsigned DestReg, bool IsZExt); unsigned PPCMaterializeFP(const ConstantFP *CFP, MVT VT); unsigned PPCMaterializeGV(const GlobalValue *GV, MVT VT); - unsigned PPCMaterializeInt(const Constant *C, MVT VT); + unsigned PPCMaterializeInt(const Constant *C, MVT VT, bool UseSExt = true); unsigned PPCMaterialize32BitInt(int64_t Imm, const TargetRegisterClass *RC); unsigned PPCMaterialize64BitInt(int64_t Imm, @@ -1547,13 +1547,23 @@ bool PPCFastISel::SelectRet(const Instruction *I) { // Special case for returning a constant integer of any size. // Materialize the constant as an i64 and copy it to the return - // register. This avoids an unnecessary extend or truncate. + // register. We still need to worry about properly extending the sign. E.g: + // If the constant has only one bit, it means it is a boolean. Therefore + // we can't use PPCMaterializeInt because it extends the sign which will + // cause negations of the returned value to be incorrect as they are + // implemented as the flip of the least significant bit. if (isa(*RV)) { const Constant *C = cast(RV); - unsigned SrcReg = PPCMaterializeInt(C, MVT::i64); - unsigned RetReg = ValLocs[0].getLocReg(); + + CCValAssign &VA = ValLocs[0]; + + unsigned RetReg = VA.getLocReg(); + unsigned SrcReg = PPCMaterializeInt(C, MVT::i64, + VA.getLocInfo() == CCValAssign::SExt); + BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, DbgLoc, - TII.get(TargetOpcode::COPY), RetReg).addReg(SrcReg); + TII.get(TargetOpcode::COPY), RetReg).addReg(SrcReg); + RetRegs.push_back(RetReg); } else { @@ -2013,7 +2023,8 @@ unsigned PPCFastISel::PPCMaterialize64BitInt(int64_t Imm, // Materialize an integer constant into a register, and return // the register number (or zero if we failed to handle it). -unsigned PPCFastISel::PPCMaterializeInt(const Constant *C, MVT VT) { +unsigned PPCFastISel::PPCMaterializeInt(const Constant *C, MVT VT, + bool UseSExt) { // If we're using CR bit registers for i1 values, handle that as a special // case first. if (VT == MVT::i1 && PPCSubTarget->useCRBits()) { @@ -2037,7 +2048,7 @@ unsigned PPCFastISel::PPCMaterializeInt(const Constant *C, MVT VT) { unsigned Opc = (VT == MVT::i64) ? PPC::LI8 : PPC::LI; unsigned ImmReg = createResultReg(RC); BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, DbgLoc, TII.get(Opc), ImmReg) - .addImm(CI->getSExtValue()); + .addImm( (UseSExt) ? CI->getSExtValue() : CI->getZExtValue() ); return ImmReg; } diff --git a/test/CodeGen/PowerPC/fast-isel-ret.ll b/test/CodeGen/PowerPC/fast-isel-ret.ll index fa19f8b11fd..f82de70c928 100644 --- a/test/CodeGen/PowerPC/fast-isel-ret.ll +++ b/test/CodeGen/PowerPC/fast-isel-ret.ll @@ -1,8 +1,40 @@ ; RUN: llc < %s -O0 -verify-machineinstrs -fast-isel-abort -mtriple=powerpc64-unknown-linux-gnu -mcpu=pwr7 | FileCheck %s --check-prefix=ELF64 +define zeroext i1 @rettrue() nounwind uwtable ssp { +entry: +; ELF64-LABEL: rettrue +; ELF64: li 3, 1 +; ELF64: blr + ret i1 true +} + +define zeroext i1 @retfalse() nounwind uwtable ssp { +entry: +; ELF64-LABEL: retfalse +; ELF64: li 3, 0 +; ELF64: blr + ret i1 false +} + +define signext i1 @retstrue() nounwind uwtable ssp { +entry: +; ELF64-LABEL: retstrue +; ELF64: li 3, -1 +; ELF64: blr + ret i1 true +} + +define signext i1 @retsfalse() nounwind uwtable ssp { +entry: +; ELF64-LABEL: retsfalse +; ELF64: li 3, 0 +; ELF64: blr + ret i1 false +} + define signext i8 @ret2(i8 signext %a) nounwind uwtable ssp { entry: -; ELF64: ret2 +; ELF64-LABEL: ret2 ; ELF64: extsb ; ELF64: blr ret i8 %a @@ -10,7 +42,7 @@ entry: define zeroext i8 @ret3(i8 signext %a) nounwind uwtable ssp { entry: -; ELF64: ret3 +; ELF64-LABEL: ret3 ; ELF64: rldicl {{[0-9]+}}, {{[0-9]+}}, 0, 56 ; ELF64: blr ret i8 %a @@ -18,7 +50,7 @@ entry: define signext i16 @ret4(i16 signext %a) nounwind uwtable ssp { entry: -; ELF64: ret4 +; ELF64-LABEL: ret4 ; ELF64: extsh ; ELF64: blr ret i16 %a @@ -26,7 +58,7 @@ entry: define zeroext i16 @ret5(i16 signext %a) nounwind uwtable ssp { entry: -; ELF64: ret5 +; ELF64-LABEL: ret5 ; ELF64: rldicl {{[0-9]+}}, {{[0-9]+}}, 0, 48 ; ELF64: blr ret i16 %a @@ -34,7 +66,7 @@ entry: define i16 @ret6(i16 %a) nounwind uwtable ssp { entry: -; ELF64: ret6 +; ELF64-LABEL: ret6 ; ELF64: rldicl {{[0-9]+}}, {{[0-9]+}}, 0, 48 ; ELF64: blr ret i16 %a @@ -42,7 +74,7 @@ entry: define signext i32 @ret7(i32 signext %a) nounwind uwtable ssp { entry: -; ELF64: ret7 +; ELF64-LABEL: ret7 ; ELF64: extsw ; ELF64: blr ret i32 %a @@ -50,7 +82,7 @@ entry: define zeroext i32 @ret8(i32 signext %a) nounwind uwtable ssp { entry: -; ELF64: ret8 +; ELF64-LABEL: ret8 ; ELF64: rldicl {{[0-9]+}}, {{[0-9]+}}, 0, 32 ; ELF64: blr ret i32 %a @@ -58,7 +90,7 @@ entry: define i32 @ret9(i32 %a) nounwind uwtable ssp { entry: -; ELF64: ret9 +; ELF64-LABEL: ret9 ; ELF64: rldicl {{[0-9]+}}, {{[0-9]+}}, 0, 32 ; ELF64: blr ret i32 %a @@ -66,7 +98,7 @@ entry: define i64 @ret10(i64 %a) nounwind uwtable ssp { entry: -; ELF64: ret10 +; ELF64-LABEL: ret10 ; ELF64-NOT: exts ; ELF64-NOT: rldicl ; ELF64: blr @@ -75,21 +107,21 @@ entry: define float @ret11(float %a) nounwind uwtable ssp { entry: -; ELF64: ret11 +; ELF64-LABEL: ret11 ; ELF64: blr ret float %a } define double @ret12(double %a) nounwind uwtable ssp { entry: -; ELF64: ret12 +; ELF64-LABEL: ret12 ; ELF64: blr ret double %a } define i8 @ret13() nounwind uwtable ssp { entry: -; ELF64: ret13 +; ELF64-LABEL: ret13 ; ELF64: li ; ELF64: blr ret i8 15; @@ -97,7 +129,7 @@ entry: define i16 @ret14() nounwind uwtable ssp { entry: -; ELF64: ret14 +; ELF64-LABEL: ret14 ; ELF64: li ; ELF64: blr ret i16 -225; @@ -105,7 +137,7 @@ entry: define i32 @ret15() nounwind uwtable ssp { entry: -; ELF64: ret15 +; ELF64-LABEL: ret15 ; ELF64: lis ; ELF64: ori ; ELF64: blr @@ -114,7 +146,7 @@ entry: define i64 @ret16() nounwind uwtable ssp { entry: -; ELF64: ret16 +; ELF64-LABEL: ret16 ; ELF64: li ; ELF64: sldi ; ELF64: oris @@ -125,7 +157,7 @@ entry: define float @ret17() nounwind uwtable ssp { entry: -; ELF64: ret17 +; ELF64-LABEL: ret17 ; ELF64: addis ; ELF64: lfs ; ELF64: blr @@ -134,7 +166,7 @@ entry: define double @ret18() nounwind uwtable ssp { entry: -; ELF64: ret18 +; ELF64-LABEL: ret18 ; ELF64: addis ; ELF64: lfd ; ELF64: blr