RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2025-02-25 07:31:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Hexagon] Address ASAN and UBSAN failures after r294226

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@294256 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Krzysztof Parzyszek 2017-02-06 23:11:32 +00:00
parent fbc0a5331d
commit 769338ac57
3 changed files with 15 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/Target/Hexagon/MCTargetDesc/HexagonMCInstrInfo.cpp
View File

@ -78,7 +78,7 @@ bool HexagonMCInstrInfo::canonicalizePacket(MCInstrInfo const &MCII,
}
// Examines packet and pad the packet, if needed, when an
// end-loop is in the bundle.
HexagonMCInstrInfo::padEndloop(MCB);
HexagonMCInstrInfo::padEndloop(MCB, Context);
// If compounding and duplexing didn't reduce the size below
// 4 or less we have a packet that is too big.
if (HexagonMCInstrInfo::bundleSize(MCB) > HEXAGON_PACKET_SIZE)
@ -273,9 +273,8 @@ int HexagonMCInstrInfo::getMaxValue(MCInstrInfo const &MCII,
HexagonMCInstrInfo::isExtended(MCII, MCI));
if (S) // if value is signed
return ~(-1 << (HexagonMCInstrInfo::getExtentBits(MCII, MCI) - 1));
else
return ~(-1 << HexagonMCInstrInfo::getExtentBits(MCII, MCI));
return (1 << (HexagonMCInstrInfo::getExtentBits(MCII, MCI) - 1)) - 1;
return (1 << HexagonMCInstrInfo::getExtentBits(MCII, MCI)) - 1;
}
/// Return the minimum value of an extendable operand.
@ -288,8 +287,7 @@ int HexagonMCInstrInfo::getMinValue(MCInstrInfo const &MCII,
HexagonMCInstrInfo::isExtended(MCII, MCI));
if (S) // if value is signed
return -1 << (HexagonMCInstrInfo::getExtentBits(MCII, MCI) - 1);
else
return -(1 << (HexagonMCInstrInfo::getExtentBits(MCII, MCI) - 1));
return 0;
}
@ -747,7 +745,7 @@ bool HexagonMCInstrInfo::s23_2_reloc(MCExpr const &Expr) {
return HExpr->s23_2_reloc();
}
void HexagonMCInstrInfo::padEndloop(MCInst &MCB) {
void HexagonMCInstrInfo::padEndloop(MCInst &MCB, MCContext &Context) {
MCInst Nop;
Nop.setOpcode(Hexagon::A2_nop);
assert(isBundle(MCB));
@ -755,7 +753,7 @@ void HexagonMCInstrInfo::padEndloop(MCInst &MCB) {
(HexagonMCInstrInfo::bundleSize(MCB) < HEXAGON_PACKET_INNER_SIZE)) ||
((HexagonMCInstrInfo::isOuterLoop(MCB) &&
(HexagonMCInstrInfo::bundleSize(MCB) < HEXAGON_PACKET_OUTER_SIZE))))
MCB.addOperand(MCOperand::createInst(new MCInst(Nop)));
MCB.addOperand(MCOperand::createInst(new (Context) MCInst(Nop)));
}
bool HexagonMCInstrInfo::prefersSlot3(MCInstrInfo const &MCII,

2
lib/Target/Hexagon/MCTargetDesc/HexagonMCInstrInfo.h
View File

@ -256,7 +256,7 @@ bool mustExtend(MCExpr const &Expr);
bool mustNotExtend(MCExpr const &Expr);
// Pad the bundle with nops to satisfy endloop requirements
void padEndloop(MCInst &MCI);
void padEndloop(MCInst &MCI, MCContext &Context);
bool prefersSlot3(MCInstrInfo const &MCII, MCInst const &MCI);
// Replace the instructions inside MCB, represented by Candidate

10
lib/Target/Hexagon/MCTargetDesc/HexagonShuffler.cpp
View File

@ -80,15 +80,19 @@ public:
unsigned HexagonResource::setWeight(unsigned s) {
const unsigned SlotWeight = 8;
const unsigned MaskWeight = SlotWeight - 1;
bool Key = (1 << s) & getUnits();
unsigned Units = getUnits();
unsigned Key = ((1u << s) & Units) != 0;
// Calculate relative weight of the insn for the given slot, weighing it the
// heavier the more restrictive the insn is and the lowest the slots that the
// insn may be executed in.
if (Key == 0 || Units == 0 || (SlotWeight*s > 32))
return 0;
Weight =
(Key << (SlotWeight * s)) * ((MaskWeight - countPopulation(getUnits()))
(1u << (SlotWeight * s)) * ((MaskWeight - countPopulation(getUnits()))
<< countTrailingZeros(getUnits()));
return (Weight);
return Weight;
}
void HexagonCVIResource::SetupTUL(TypeUnitsAndLanes *TUL, StringRef CPU) {