RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2025-02-20 04:55:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add a FIXME explaining the move to a single indirect call bonus per function

Browse Source 
that we can change from indirect to direct.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@124045 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Eric Christopher 2011-01-22 21:56:53 +00:00
parent 7020f12ee8
commit 7ea118de46
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Analysis/InlineCost.cpp
View File

@ -189,6 +189,11 @@ unsigned CodeMetrics::CountBonusForConstant(Value *V) {
} }
} }
// FIXME: The only reason we're applying the bonus once is while it's great
// to devirtualize calls the magnitude of the bonus x number of call sites
// can lead to a huge code explosion when we prefer to inline 1000 instruction
// functions that have 10 call sites. This should be made a function of the
// estimated inline penalty/benefit + the indirect call bonus.
if (indirectCallBonus) Bonus += InlineConstants::IndirectCallBonus; if (indirectCallBonus) Bonus += InlineConstants::IndirectCallBonus;
return Bonus; return Bonus;