RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2025-01-31 17:42:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[ThinLTO] Rename doPromoteLocalToGlobal to shouldPromoteLocalToGlobal (NFC)

Browse Source 
Rename as suggested in code review for D26063.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@285508 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Teresa Johnson 2016-10-29 21:52:23 +00:00
parent 8c54a79285
commit 8108a04696
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/llvm/Transforms/Utils/FunctionImportUtils.h
View File

@ -41,7 +41,7 @@ class FunctionImportGlobalProcessing {
bool HasExportedFunctions = false; bool HasExportedFunctions = false;
/// Check if we should promote the given local value to global scope. /// Check if we should promote the given local value to global scope.
bool doPromoteLocalToGlobal(const GlobalValue *SGV); bool shouldPromoteLocalToGlobal(const GlobalValue *SGV);
/// Helper methods to check if we are importing from or potentially /// Helper methods to check if we are importing from or potentially
/// exporting from the current source module. /// exporting from the current source module.

6
lib/Transforms/Utils/FunctionImportUtils.cpp
View File

@ -48,7 +48,7 @@ bool FunctionImportGlobalProcessing::doImportAsDefinition(
GlobalsToImport); GlobalsToImport);
} }
bool FunctionImportGlobalProcessing::doPromoteLocalToGlobal( bool FunctionImportGlobalProcessing::shouldPromoteLocalToGlobal(
const GlobalValue *SGV) { const GlobalValue *SGV) {
assert(SGV->hasLocalLinkage()); assert(SGV->hasLocalLinkage());
// Both the imported references and the original local variable must // Both the imported references and the original local variable must
@ -193,9 +193,9 @@ FunctionImportGlobalProcessing::getLinkage(const GlobalValue *SGV,
void FunctionImportGlobalProcessing::processGlobalForThinLTO(GlobalValue &GV) { void FunctionImportGlobalProcessing::processGlobalForThinLTO(GlobalValue &GV) {
bool DoPromote = false; bool DoPromote = false;
if (GV.hasLocalLinkage() && if (GV.hasLocalLinkage() &&
((DoPromote = doPromoteLocalToGlobal(&GV)) || isPerformingImport())) { ((DoPromote = shouldPromoteLocalToGlobal(&GV)) || isPerformingImport())) {
// Once we change the name or linkage it is difficult to determine // Once we change the name or linkage it is difficult to determine
// again whether we should promote since doPromoteLocalToGlobal needs // again whether we should promote since shouldPromoteLocalToGlobal needs
// to locate the summary (based on GUID from name and linkage). Therefore, // to locate the summary (based on GUID from name and linkage). Therefore,
// use DoPromote result saved above. // use DoPromote result saved above.
GV.setName(getName(&GV, DoPromote)); GV.setName(getName(&GV, DoPromote));