RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-11-27 13:40:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix assert when emitting llvm.pow.f86.

Browse Source 
This occurred due to introducing the invalid i64 type after type
legalization had already finished, in an attempt to workaround bitcast
f64 -> v2i32 not doing constant folding.

The *right* thing is to actually fix bitcast, but that has other
complications. So, for now, just get rid of the broken workaround, and
check in a test-case showing that it doesn't crash, with TODOs for
emitting proper code.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@249908 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
James Y Knight 2015-10-09 21:36:19 +00:00
parent cfb92b1bfd
commit 84477d1390
2 changed files with 45 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Target/Sparc/SparcISelLowering.cpp
View File

@ -854,11 +854,10 @@ SparcTargetLowering::LowerCall_32(TargetLowering::CallLoweringInfo &CLI,
// Move from the float value from float registers into the
// integer registers.
// TODO: this conversion is done in two steps, because
// f64->i64 conversion is done efficiently, and i64->v2i32 is
// basically a no-op. But f64->v2i32 is NOT done efficiently
// for some reason.
Arg = DAG.getNode(ISD::BITCAST, dl, MVT::i64, Arg);
// TODO: The f64 -> v2i32 conversion is super-inefficient for
// constants: it sticks them in the constant pool, then loads
// to a fp register, then stores to temp memory, then loads to
// integer registers.
Arg = DAG.getNode(ISD::BITCAST, dl, MVT::v2i32, Arg);
}

41
test/CodeGen/SPARC/float-constants.ll Normal file
View File

@ -0,0 +1,41 @@
; RUN: llc < %s -march=sparc | FileCheck %s
; TODO: actually fix the codegen to be optimal. At least we don't
; crash for now, though...
;; Bitcast should not do a runtime conversion, but rather emit a
;; constant into integer registers directly.
; CHECK-LABEL: bitcast:
; TODO-CHECK: sethi 1049856, %o0
; TODO-CHECK: sethi 0, %o1
define <2 x i32> @bitcast() {
%1 = bitcast double 5.0 to <2 x i32>
ret <2 x i32> %1
}
;; Same thing for a call using a double (which gets passed in integer
;; registers)
; CHECK-LABEL: test_call
; TODO-CHECK: sethi 1049856, %o0
; TODO-CHECK: sethi 0, %o1
declare void @a(double)
define void @test_call() {
call void @a(double 5.0)
ret void
}
;; And for a libcall emitted from the pow intrinsic. (libcall
;; emission happens after SelectionDAG type legalization, so is a bit
;; different than a normal function call. This was crashing before,
;; due to an earlier broken workaround for this issue.)
; CHECK-LABEL: test_intrins_call
; TODO-CHECK: sethi 1049856, %o0
; TODO-CHECK: sethi 0, %o1
declare double @llvm.pow.f64(double, double)
define double @test_intrins_call() {
%1 = call double @llvm.pow.f64(double 2.0, double 2.0)
ret double %1
}