[AMDGPU] Enable absolute expression initializer for amd_kernel_code_t fields.

Differential Revision: http://reviews.llvm.org/D21380

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@273561 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Valery Pykhtin 2016-06-23 14:13:06 +00:00
parent c1faee3baa
commit 85d254114e
5 changed files with 155 additions and 23 deletions

View File

@ -1277,7 +1277,7 @@ bool AMDGPUAsmParser::ParseAMDKernelCodeTValue(StringRef ID,
amd_kernel_code_t &Header) {
SmallString<40> ErrStr;
raw_svector_ostream Err(ErrStr);
if (!parseAmdKernelCodeField(ID, getLexer(), Header, Err)) {
if (!parseAmdKernelCodeField(ID, getParser(), Header, Err)) {
return TokError(Err.str());
}
Lex();
@ -1291,9 +1291,6 @@ bool AMDGPUAsmParser::ParseDirectiveAMDKernelCodeT() {
while (true) {
if (getLexer().isNot(AsmToken::EndOfStatement))
return TokError("amd_kernel_code_t values must begin on a new line");
// Lex EndOfStatement. This is in a while loop, because lexing a comment
// will set the current token to EndOfStatement.
while(getLexer().is(AsmToken::EndOfStatement))

View File

@ -37,15 +37,15 @@
// have to define these lambdas because of Set/GetMacro
#define PRINTCOMP(GetMacro, Shift) \
[](StringRef Name, const amd_kernel_code_t& C, raw_ostream& OS) { \
[](StringRef Name, const amd_kernel_code_t &C, raw_ostream &OS) { \
printName(OS, Name) << \
(int)GetMacro(C.compute_pgm_resource_registers >> Shift); \
}
#define PARSECOMP(SetMacro, Shift) \
[](amd_kernel_code_t& C, MCAsmLexer& Lexer, raw_ostream& Err) { \
if (!expectEqualInt(Lexer, Err)) \
[](amd_kernel_code_t &C, MCAsmParser &MCParser, raw_ostream &Err) { \
int64_t Value = 0; \
if (!expectAbsExpression(MCParser, Value, Err)) \
return false; \
const uint64_t Value = Lexer.getTok().getIntVal(); \
C.compute_pgm_resource_registers |= SetMacro(Value) << Shift; \
return true; \
}

View File

@ -16,6 +16,7 @@
#include "AMDKernelCodeTUtils.h"
#include "SIDefines.h"
#include <llvm/MC/MCParser/MCAsmLexer.h>
#include <llvm/MC/MCParser/MCAsmParser.h>
#include <llvm/Support/raw_ostream.h>
using namespace llvm;
@ -101,41 +102,45 @@ void llvm::dumpAmdKernelCode(const amd_kernel_code_t *C,
// Field parsing
static bool expectEqualInt(MCAsmLexer &Lexer, raw_ostream &Err) {
if (Lexer.isNot(AsmToken::Equal)) {
static bool expectAbsExpression(MCAsmParser &MCParser, int64_t &Value, raw_ostream& Err) {
if (MCParser.getLexer().isNot(AsmToken::Equal)) {
Err << "expected '='";
return false;
}
Lexer.Lex();
if (Lexer.isNot(AsmToken::Integer)) {
Err << "integer literal expected";
MCParser.getLexer().Lex();
if (MCParser.parseAbsoluteExpression(Value)) {
Err << "integer absolute expression expected";
return false;
}
return true;
}
template <typename T, T amd_kernel_code_t::*ptr>
static bool parseField(amd_kernel_code_t &C, MCAsmLexer &Lexer,
static bool parseField(amd_kernel_code_t &C, MCAsmParser &MCParser,
raw_ostream &Err) {
if (!expectEqualInt(Lexer, Err))
int64_t Value = 0;
if (!expectAbsExpression(MCParser, Value, Err))
return false;
C.*ptr = (T)Lexer.getTok().getIntVal();
C.*ptr = (T)Value;
return true;
}
template <typename T, T amd_kernel_code_t::*ptr, int shift, int width = 1>
static bool parseBitField(amd_kernel_code_t &C, MCAsmLexer &Lexer,
static bool parseBitField(amd_kernel_code_t &C, MCAsmParser &MCParser,
raw_ostream &Err) {
if (!expectEqualInt(Lexer, Err))
int64_t Value = 0;
if (!expectAbsExpression(MCParser, Value, Err))
return false;
const uint64_t Mask = ((UINT64_C(1) << width) - 1) << shift;
C.*ptr &= (T)~Mask;
C.*ptr |= (T)((Lexer.getTok().getIntVal() << shift) & Mask);
C.*ptr |= (T)((Value << shift) & Mask);
return true;
}
typedef bool(*ParseFx)(amd_kernel_code_t &,
MCAsmLexer &Lexer,
MCAsmParser &MCParser,
raw_ostream &Err);
static ArrayRef<ParseFx> getParserTable() {
@ -148,7 +153,7 @@ static ArrayRef<ParseFx> getParserTable() {
}
bool llvm::parseAmdKernelCodeField(StringRef ID,
MCAsmLexer &Lexer,
MCAsmParser &MCParser,
amd_kernel_code_t &C,
raw_ostream &Err) {
const int Idx = get_amd_kernel_code_t_FieldIndex(ID);
@ -157,5 +162,5 @@ bool llvm::parseAmdKernelCodeField(StringRef ID,
return false;
}
auto Parser = getParserTable()[Idx];
return Parser ? Parser(C, Lexer, Err) : false;
return Parser ? Parser(C, MCParser, Err) : false;
}

View File

@ -17,6 +17,7 @@
namespace llvm {
class MCAsmLexer;
class MCAsmParser;
class raw_ostream;
class StringRef;
@ -29,7 +30,7 @@ void dumpAmdKernelCode(const amd_kernel_code_t *C,
const char *tab);
bool parseAmdKernelCodeField(StringRef ID,
MCAsmLexer &Lexer,
MCAsmParser &Parser,
amd_kernel_code_t &C,
raw_ostream &Err);

129
test/MC/AMDGPU/hsa-exp.s Normal file
View File

@ -0,0 +1,129 @@
// RUN: llvm-mc -triple amdgcn--amdhsa -mcpu=kaveri -show-encoding %s | FileCheck %s --check-prefix=ASM
// RUN: llvm-mc -filetype=obj -triple amdgcn--amdhsa -mcpu=kaveri -show-encoding %s | llvm-readobj -symbols -s -sd | FileCheck %s --check-prefix=ELF
// ELF: Section {
// ELF: Name: .text
// ELF: Type: SHT_PROGBITS (0x1)
// ELF: Flags [ (0x6)
// ELF: SHF_ALLOC (0x2)
// ELF: SHF_EXECINSTR (0x4)
// ELF: SHT_NOTE
// ELF: 0000: 04000000 08000000 01000000 414D4400
// ELF: 0010: 02000000 00000000 04000000 1B000000
// ELF: 0020: 03000000 414D4400 04000700 07000000
// ELF: 0030: 00000000 00000000 414D4400 414D4447
// ELF: 0040: 50550000
// ELF: Symbol {
// ELF: Name: amd_kernel_code_t_minimal
// ELF: Type: AMDGPU_HSA_KERNEL (0xA)
// ELF: Section: .text
// ELF: }
.text
// ASM: .text
.hsa_code_object_version 2,0
// ASM: .hsa_code_object_version 2,0
.hsa_code_object_isa 7,0,0,"AMD","AMDGPU"
// ASM: .hsa_code_object_isa 7,0,0,"AMD","AMDGPU"
.amdgpu_hsa_kernel amd_kernel_code_t_minimal
.set my_is_ptr64, 1
.if my_is_ptr64 == 0
.set my_kernarg_segment_byte_size, 32
.else
.set my_kernarg_segment_byte_size, 16
.endif
.set my_sgpr, 8
amd_kernel_code_t_minimal:
.amd_kernel_code_t
kernel_code_version_major = .option.machine_version_major
enable_sgpr_kernarg_segment_ptr = 1
is_ptr64 = my_is_ptr64
compute_pgm_rsrc1_vgprs = 1
compute_pgm_rsrc1_sgprs = 1+(my_sgpr-1)/8
compute_pgm_rsrc2_user_sgpr = 2
kernarg_segment_byte_size = my_kernarg_segment_byte_size
wavefront_sgpr_count = my_sgpr
// wavefront_sgpr_count = 7
; wavefront_sgpr_count = 7
// Make sure a blank line won't break anything:
// Make sure a line with whitespace won't break anything:
workitem_vgpr_count = 16
.end_amd_kernel_code_t
// ASM-LABEL: {{^}}amd_kernel_code_t_minimal:
// ASM: .amd_kernel_code_t
// ASM: kernel_code_version_major = 7
// ASM: kernel_code_version_minor = 0
// ASM: machine_kind = 1
// ASM: machine_version_major = 7
// ASM: machine_version_minor = 0
// ASM: machine_version_stepping = 0
// ASM: kernel_code_entry_byte_offset = 256
// ASM: kernel_code_prefetch_byte_size = 0
// ASM: max_scratch_backing_memory_byte_size = 0
// ASM: compute_pgm_rsrc1_vgprs = 1
// ASM: compute_pgm_rsrc1_sgprs = 1
// ASM: compute_pgm_rsrc1_priority = 0
// ASM: compute_pgm_rsrc1_float_mode = 0
// ASM: compute_pgm_rsrc1_priv = 0
// ASM: compute_pgm_rsrc1_dx10_clamp = 0
// ASM: compute_pgm_rsrc1_debug_mode = 0
// ASM: compute_pgm_rsrc1_ieee_mode = 0
// ASM: compute_pgm_rsrc2_scratch_en = 0
// ASM: compute_pgm_rsrc2_user_sgpr = 2
// ASM: compute_pgm_rsrc2_tgid_x_en = 0
// ASM: compute_pgm_rsrc2_tgid_y_en = 0
// ASM: compute_pgm_rsrc2_tgid_z_en = 0
// ASM: compute_pgm_rsrc2_tg_size_en = 0
// ASM: compute_pgm_rsrc2_tidig_comp_cnt = 0
// ASM: compute_pgm_rsrc2_excp_en_msb = 0
// ASM: compute_pgm_rsrc2_lds_size = 0
// ASM: compute_pgm_rsrc2_excp_en = 0
// ASM: enable_sgpr_private_segment_buffer = 0
// ASM: enable_sgpr_dispatch_ptr = 0
// ASM: enable_sgpr_queue_ptr = 0
// ASM: enable_sgpr_kernarg_segment_ptr = 1
// ASM: enable_sgpr_dispatch_id = 0
// ASM: enable_sgpr_flat_scratch_init = 0
// ASM: enable_sgpr_private_segment_size = 0
// ASM: enable_sgpr_grid_workgroup_count_x = 0
// ASM: enable_sgpr_grid_workgroup_count_y = 0
// ASM: enable_sgpr_grid_workgroup_count_z = 0
// ASM: enable_ordered_append_gds = 0
// ASM: private_element_size = 0
// ASM: is_ptr64 = 1
// ASM: is_dynamic_callstack = 0
// ASM: is_debug_enabled = 0
// ASM: is_xnack_enabled = 0
// ASM: workitem_private_segment_byte_size = 0
// ASM: workgroup_group_segment_byte_size = 0
// ASM: gds_segment_byte_size = 0
// ASM: kernarg_segment_byte_size = 16
// ASM: workgroup_fbarrier_count = 0
// ASM: wavefront_sgpr_count = 8
// ASM: workitem_vgpr_count = 16
// ASM: reserved_vgpr_first = 0
// ASM: reserved_vgpr_count = 0
// ASM: reserved_sgpr_first = 0
// ASM: reserved_sgpr_count = 0
// ASM: debug_wavefront_private_segment_offset_sgpr = 0
// ASM: debug_private_segment_buffer_sgpr = 0
// ASM: kernarg_segment_alignment = 4
// ASM: group_segment_alignment = 4
// ASM: private_segment_alignment = 4
// ASM: wavefront_size = 6
// ASM: call_convention = 0
// ASM: runtime_loader_kernel_symbol = 0
// ASM: .end_amd_kernel_code_t