RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-11-28 14:10:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Propagate Undef in llvm.cos Intrinsic

Browse Source 
Summary:
The llvm cos intrinsic currently does not propagate undef's. This change
transforms cos(undef) to null value or 0.

There are 2 test cases added as well.

Patch by Anna Thomas!

Reviewers: sanjoy

Subscribers: majnemer, llvm-commits

Differential Revision: http://reviews.llvm.org/D18863

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@265825 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Sanjoy Das 2016-04-08 18:21:11 +00:00
parent df06a070e7
commit 8731336ad2
2 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Analysis/ConstantFolding.cpp
View File

@ -1443,6 +1443,11 @@ Constant *ConstantFoldScalarCall(StringRef Name, unsigned IntrinsicID, Type *Ty,
ArrayRef<Constant *> Operands, ArrayRef<Constant *> Operands,
const TargetLibraryInfo *TLI) { const TargetLibraryInfo *TLI) {
if (Operands.size() == 1) { if (Operands.size() == 1) {
if (isa<UndefValue>(Operands[0])) {
// cosine(arg) is between -1 and 1. cosine(invalid arg) is NaN
if (IntrinsicID == Intrinsic::cos)
return Constant::getNullValue(Ty);
}
if (ConstantFP *Op = dyn_cast<ConstantFP>(Operands[0])) { if (ConstantFP *Op = dyn_cast<ConstantFP>(Operands[0])) {
if (IntrinsicID == Intrinsic::convert_to_fp16) { if (IntrinsicID == Intrinsic::convert_to_fp16) {
APFloat Val(Op->getValueAPF()); APFloat Val(Op->getValueAPF());

26
test/Transforms/InstCombine/cos-intrinsic.ll Normal file
View File

@ -0,0 +1,26 @@
; RUN: opt < %s -instcombine -S | FileCheck %s
; This test makes sure that the undef is propagated for the cos instrinsic
declare double @llvm.cos.f64(double %Val)
declare float @llvm.cos.f32(float %Val)
; Function Attrs: nounwind readnone
define double @test1() {
; CHECK-LABEL: define double @test1(
; CHECK-NEXT: ret double 0.000000e+00
%1 = call double @llvm.cos.f64(double undef)
ret double %1
}
; Function Attrs: nounwind readnone
define float @test2(float %d) {
; CHECK-LABEL: define float @test2(
; CHECK-NEXT: %cosval = call float @llvm.cos.f32(float %d)
%cosval = call float @llvm.cos.f32(float %d)
%cosval2 = call float @llvm.cos.f32(float undef)
%fsum = fadd float %cosval2, %cosval
ret float %fsum
; CHECK-NEXT: %fsum
; CHECK: ret float %fsum
}