Fix a bug in legalize where it would emit two calls to libcalls that return

i64 values on targets that need that expanded to 32-bit registers.  This fixes
PowerPC/2005-09-02-LegalizeDuplicatesCalls.ll and speeds up 189.lucas from
taking 122.72s to 81.96s on my desktop.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@23228 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2005-09-02 20:26:58 +00:00
parent c789701360
commit 99c25b86aa

View File

@ -1996,7 +1996,7 @@ SDOperand SelectionDAGLegalize::PromoteOp(SDOperand Op) {
SDOperand Result; SDOperand Result;
SDNode *Node = Op.Val; SDNode *Node = Op.Val;
if (!Node->hasOneUse()) { if (1 || !Node->hasOneUse()) {
std::map<SDOperand, SDOperand>::iterator I = PromotedNodes.find(Op); std::map<SDOperand, SDOperand>::iterator I = PromotedNodes.find(Op);
if (I != PromotedNodes.end()) return I->second; if (I != PromotedNodes.end()) return I->second;
} else { } else {
@ -2709,21 +2709,24 @@ SDOperand SelectionDAGLegalize::ExpandLibCall(const char *Name, SDNode *Node,
std::pair<SDOperand,SDOperand> CallInfo = std::pair<SDOperand,SDOperand> CallInfo =
TLI.LowerCallTo(InChain, RetTy, false, CallingConv::C, false, TLI.LowerCallTo(InChain, RetTy, false, CallingConv::C, false,
Callee, Args, DAG); Callee, Args, DAG);
SpliceCallInto(CallInfo.second, OutChain);
NeedsAnotherIteration = true;
SDOperand Result;
switch (getTypeAction(CallInfo.first.getValueType())) { switch (getTypeAction(CallInfo.first.getValueType())) {
default: assert(0 && "Unknown thing"); default: assert(0 && "Unknown thing");
case Legal: case Legal:
return CallInfo.first; Result = CallInfo.first;
break;
case Promote: case Promote:
assert(0 && "Cannot promote this yet!"); assert(0 && "Cannot promote this yet!");
case Expand: case Expand:
SDOperand Lo; ExpandOp(CallInfo.first, Result, Hi);
ExpandOp(CallInfo.first, Lo, Hi); CallInfo.second = LegalizeOp(CallInfo.second);
return Lo; break;
} }
SpliceCallInto(CallInfo.second, OutChain);
NeedsAnotherIteration = true;
return Result;
} }
@ -2845,7 +2848,7 @@ void SelectionDAGLegalize::ExpandOp(SDOperand Op, SDOperand &Lo, SDOperand &Hi){
// If there is more than one use of this, see if we already expanded it. // If there is more than one use of this, see if we already expanded it.
// There is no use remembering values that only have a single use, as the map // There is no use remembering values that only have a single use, as the map
// entries will never be reused. // entries will never be reused.
if (!Node->hasOneUse()) { if (1 || !Node->hasOneUse()) {
std::map<SDOperand, std::pair<SDOperand, SDOperand> >::iterator I std::map<SDOperand, std::pair<SDOperand, SDOperand> >::iterator I
= ExpandedNodes.find(Op); = ExpandedNodes.find(Op);
if (I != ExpandedNodes.end()) { if (I != ExpandedNodes.end()) {
@ -3259,7 +3262,7 @@ void SelectionDAGLegalize::ExpandOp(SDOperand Op, SDOperand &Lo, SDOperand &Hi){
} }
// Remember in a map if the values will be reused later. // Remember in a map if the values will be reused later.
if (!Node->hasOneUse()) { if (1 || !Node->hasOneUse()) {
bool isNew = ExpandedNodes.insert(std::make_pair(Op, bool isNew = ExpandedNodes.insert(std::make_pair(Op,
std::make_pair(Lo, Hi))).second; std::make_pair(Lo, Hi))).second;
assert(isNew && "Value already expanded?!?"); assert(isNew && "Value already expanded?!?");