add FIXME comment; NFC

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@265970 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Sanjay Patel 2016-04-11 17:35:57 +00:00
parent c19ec77e20
commit a05380c564

View File

@ -62,7 +62,7 @@ static bool canEvaluateShiftedShift(unsigned FirstShiftAmt,
Instruction *SecondShift, InstCombiner &IC,
Instruction *CxtI) {
assert(SecondShift->isLogicalShift() && "Unexpected instruction type");
// We need constant shifts.
auto *SecondShiftConst = dyn_cast<ConstantInt>(SecondShift->getOperand(1));
if (!SecondShiftConst)
@ -256,6 +256,8 @@ static Value *GetShiftedValue(Value *V, unsigned NumBits, bool isLeftShift,
BO->setHasNoSignedWrap(false);
return BO;
}
// FIXME: This is almost identical to the SHL case. Refactor both cases into
// a helper function.
case Instruction::LShr: {
BinaryOperator *BO = cast<BinaryOperator>(I);
unsigned TypeWidth = BO->getType()->getScalarSizeInBits();