RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-11-30 15:10:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

IntervalMap iterators are heavyweight, so avoid copying them around and use

Browse Source 
references instead.

Similarly, IntervalMap::begin() is almost as expensive as find(), so use find(x)
instead of begin().advanceTo(x);

This makes RegAllocBasic run another 5% faster.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@121344 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Jakob Stoklund Olesen 2010-12-09 01:06:52 +00:00
parent 0a29c270b5
commit a35cce1a14
2 changed files with 25 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
lib/CodeGen/LiveIntervalUnion.cpp
View File

@ -144,12 +144,29 @@ void LiveIntervalUnion::Query::findIntersection(InterferenceResult &IR) const {
// Find the first intersection, and cache interference info // Find the first intersection, and cache interference info
// (retain segment iterators into both VirtReg and LiveUnion). // (retain segment iterators into both VirtReg and LiveUnion).
LiveIntervalUnion::InterferenceResult const LiveIntervalUnion::InterferenceResult &
LiveIntervalUnion::Query::firstInterference() { LiveIntervalUnion::Query::firstInterference() {
if (FirstInterference != LiveIntervalUnion::InterferenceResult()) { if (CheckedFirstInterference)
return FirstInterference; return FirstInterference;
CheckedFirstInterference = true;
InterferenceResult &IR = FirstInterference;
// Quickly skip interference check for empty sets.
if (VirtReg->empty() || LiveUnion->empty()) {
IR.VirtRegI = VirtReg->end();
} else if (VirtReg->beginIndex() < LiveUnion->startIndex()) {
// VirtReg starts first, perform double binary search.
IR.VirtRegI = VirtReg->find(LiveUnion->startIndex());
if (IR.VirtRegI != VirtReg->end())
IR.LiveUnionI = LiveUnion->find(IR.VirtRegI->start);
} else {
// LiveUnion starts first, perform double binary search.
IR.LiveUnionI = LiveUnion->find(VirtReg->beginIndex());
if (IR.LiveUnionI.valid())
IR.VirtRegI = VirtReg->find(IR.LiveUnionI.start());
else
IR.VirtRegI = VirtReg->end();
} }
FirstInterference = InterferenceResult(VirtReg->begin(), LiveUnion->begin());
findIntersection(FirstInterference); findIntersection(FirstInterference);
return FirstInterference; return FirstInterference;
} }

7
lib/CodeGen/LiveIntervalUnion.h
View File

@ -75,7 +75,9 @@ public:
// by their starting position. // by their starting position.
SegmentIter begin() { return Segments.begin(); } SegmentIter begin() { return Segments.begin(); }
SegmentIter end() { return Segments.end(); } SegmentIter end() { return Segments.end(); }
SegmentIter find(SlotIndex x) { return Segments.find(x); }
bool empty() { return Segments.empty(); } bool empty() { return Segments.empty(); }
SlotIndex startIndex() { return Segments.start(); }
// Add a live virtual register to this union and merge its segments. // Add a live virtual register to this union and merge its segments.
void unify(LiveInterval &VirtReg); void unify(LiveInterval &VirtReg);
@ -135,6 +137,7 @@ public:
LiveInterval *VirtReg; LiveInterval *VirtReg;
InterferenceResult FirstInterference; InterferenceResult FirstInterference;
SmallVector<LiveInterval*,4> InterferingVRegs; SmallVector<LiveInterval*,4> InterferingVRegs;
bool CheckedFirstInterference;
bool SeenAllInterferences; bool SeenAllInterferences;
bool SeenUnspillableVReg; bool SeenUnspillableVReg;
@ -149,8 +152,8 @@ public:
void clear() { void clear() {
LiveUnion = NULL; LiveUnion = NULL;
VirtReg = NULL; VirtReg = NULL;
FirstInterference = InterferenceResult();
InterferingVRegs.clear(); InterferingVRegs.clear();
CheckedFirstInterference = false;
SeenAllInterferences = false; SeenAllInterferences = false;
SeenUnspillableVReg = false; SeenUnspillableVReg = false;
} }
@ -187,7 +190,7 @@ public:
// Get the first pair of interfering segments, or a noninterfering result. // Get the first pair of interfering segments, or a noninterfering result.
// This initializes the firstInterference_ cache. // This initializes the firstInterference_ cache.
InterferenceResult firstInterference(); const InterferenceResult &firstInterference();
// Treat the result as an iterator and advance to the next interfering pair // Treat the result as an iterator and advance to the next interfering pair
// of segments. Visiting each unique interfering pairs means that the same // of segments. Visiting each unique interfering pairs means that the same