*try* to use a better name to describe how common symbols are marked on the elf object file.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@79029 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Bruno Cardoso Lopes 2009-08-14 19:45:38 +00:00
parent 5ee3ba2f9e
commit abd7514a68
3 changed files with 9 additions and 5 deletions

View File

@ -52,8 +52,10 @@ public:
/// ShouldPrintSectionType - Only prints the section type if supported
bool ShouldPrintSectionType(unsigned Ty) const;
/// IsCommon - True if this section contains only common symbols
bool IsCommon() const;
/// HasCommonSymbols - True if this section holds common symbols, this is
/// indicated on the ELF object file by a symbol with SHN_COMMON section
/// header index.
bool HasCommonSymbols() const;
/// These are the section type and flags fields. An ELF section can have
/// only one Type, but can have more than one of the flags specified.

View File

@ -356,7 +356,7 @@ void ELFWriter::EmitGlobal(const GlobalValue *GV) {
unsigned Size = TD->getTypeAllocSize(GVar->getInitializer()->getType());
GblSym->Size = Size;
if (S->IsCommon()) { // Symbol must go to a common section
if (S->HasCommonSymbols()) { // Symbol must go to a common section
GblSym->SectionIdx = ELFSection::SHN_COMMON;
// A new linkonce section is created for each global in the

View File

@ -122,8 +122,10 @@ void MCSectionELF::PrintSwitchToSection(const TargetAsmInfo &TAI,
OS << '\n';
}
// IsCommon - True if this section contains only common symbols
bool MCSectionELF::IsCommon() const {
// HasCommonSymbols - True if this section holds common symbols, this is
// indicated on the ELF object file by a symbol with SHN_COMMON section
// header index.
bool MCSectionELF::HasCommonSymbols() const {
if (strncmp(SectionName.c_str(), ".gnu.linkonce.", 14) == 0)
return true;