RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2025-01-30 17:02:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[AArch64] Fix incorrect CSEL node created

Browse Source 
Under -enable-unsafe-fp-math, SELECT_CC lowering in AArch64
transforms floating point comparisons of the form "a == 0.0 ? 0.0 : x" to
"a == 0.0 ? a : x". But it incorrectly assumes that 'x' and 'a' have
the same type which can lead to a wrong CSEL node that crashes later
due to nonsensical copies.

Differential Revision: https://reviews.llvm.org/D26394



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@286231 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Roger Ferrer Ibanez 2016-11-08 13:34:41 +00:00
parent 00b1a65d84
commit b576a606d4
2 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Target/AArch64/AArch64ISelLowering.cpp
View File

@ -4106,10 +4106,11 @@ SDValue AArch64TargetLowering::LowerSELECT_CC(ISD::CondCode CC, SDValue LHS,
ConstantFPSDNode *CTVal = dyn_cast<ConstantFPSDNode>(TVal); ConstantFPSDNode *CTVal = dyn_cast<ConstantFPSDNode>(TVal);
if ((CC == ISD::SETEQ || CC == ISD::SETOEQ || CC == ISD::SETUEQ) && if ((CC == ISD::SETEQ || CC == ISD::SETOEQ || CC == ISD::SETUEQ) &&
CTVal && CTVal->isZero()) CTVal && CTVal->isZero() && TVal.getValueType() == LHS.getValueType())
TVal = LHS; TVal = LHS;
else if ((CC == ISD::SETNE || CC == ISD::SETONE || CC == ISD::SETUNE) && else if ((CC == ISD::SETNE || CC == ISD::SETONE || CC == ISD::SETUNE) &&
CFVal && CFVal->isZero()) CFVal && CFVal->isZero() &&
FVal.getValueType() == LHS.getValueType())
FVal = LHS; FVal = LHS;
} }
} }

15
test/CodeGen/AArch64/csel-zero-float.ll Normal file
View File

@ -0,0 +1,15 @@
; RUN: llc -mtriple=aarch64-none-linux-gnu -enable-unsafe-fp-math < %s
; There is no invocation to FileCheck as this
; caused a crash in "Post-RA pseudo instruction expansion"
define double @foo(float *%user, float %t17) {
%t16 = load float, float* %user, align 8
%conv = fpext float %t16 to double
%cmp26 = fcmp fast oeq float %t17, 0.000000e+00
%div = fdiv fast float %t16, %t17
%div.op = fmul fast float %div, 1.000000e+02
%t18 = fpext float %div.op to double
%conv31 = select i1 %cmp26, double 0.000000e+00, double %t18
ret double %conv31
}