From bae951d00e70383c801d5e3277783d081efa2ac5 Mon Sep 17 00:00:00 2001 From: Sanjay Patel Date: Fri, 20 Jan 2017 20:14:11 +0000 Subject: [PATCH] [x86] add tests to show missed min/max vector codegen (PR31693) git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@292640 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/CodeGen/X86/vec_minmax_match.ll | 85 ++++++++++++++++++++++++---- 1 file changed, 73 insertions(+), 12 deletions(-) diff --git a/test/CodeGen/X86/vec_minmax_match.ll b/test/CodeGen/X86/vec_minmax_match.ll index af4410a898e..6644d5dc84b 100644 --- a/test/CodeGen/X86/vec_minmax_match.ll +++ b/test/CodeGen/X86/vec_minmax_match.ll @@ -1,3 +1,4 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx | FileCheck %s @@ -11,7 +12,6 @@ define <4 x i32> @smin_vec1(<4 x i32> %x) { ; CHECK-NEXT: vpxor %xmm1, %xmm0, %xmm0 ; CHECK-NEXT: vpminsd %xmm1, %xmm0, %xmm0 ; CHECK-NEXT: retq -; %not_x = xor <4 x i32> %x, %cmp = icmp sgt <4 x i32> %x, zeroinitializer %sel = select <4 x i1> %cmp, <4 x i32> %not_x, <4 x i32> @@ -25,7 +25,6 @@ define <4 x i32> @smin_vec2(<4 x i32> %x) { ; CHECK-NEXT: vpxor %xmm1, %xmm0, %xmm0 ; CHECK-NEXT: vpminsd %xmm1, %xmm0, %xmm0 ; CHECK-NEXT: retq -; %not_x = xor <4 x i32> %x, %cmp = icmp slt <4 x i32> %x, zeroinitializer %sel = select <4 x i1> %cmp, <4 x i32> , <4 x i32> %not_x @@ -41,7 +40,6 @@ define <4 x i32> @smin_vec3(<4 x i32> %x, <4 x i32> %y) { ; CHECK-NEXT: vpxor %xmm1, %xmm1, %xmm1 ; CHECK-NEXT: vpminsd %xmm1, %xmm0, %xmm0 ; CHECK-NEXT: retq -; %sub = sub nsw <4 x i32> %x, %y %cmp = icmp sgt <4 x i32> %x, %y %sel = select <4 x i1> %cmp, <4 x i32> zeroinitializer, <4 x i32> %sub @@ -57,7 +55,6 @@ define <4 x i32> @smin_vec4(<4 x i32> %x, <4 x i32> %y) { ; CHECK-NEXT: vpxor %xmm1, %xmm1, %xmm1 ; CHECK-NEXT: vpminsd %xmm1, %xmm0, %xmm0 ; CHECK-NEXT: retq -; %sub = sub nsw <4 x i32> %x, %y %cmp = icmp slt <4 x i32> %x, %y %sel = select <4 x i1> %cmp, <4 x i32> %sub, <4 x i32> zeroinitializer @@ -71,7 +68,6 @@ define <4 x i32> @smax_vec1(<4 x i32> %x) { ; CHECK-NEXT: vpxor %xmm1, %xmm0, %xmm0 ; CHECK-NEXT: vpmaxsd %xmm1, %xmm0, %xmm0 ; CHECK-NEXT: retq -; %not_x = xor <4 x i32> %x, %cmp = icmp slt <4 x i32> %x, zeroinitializer %sel = select <4 x i1> %cmp, <4 x i32> %not_x, <4 x i32> @@ -85,7 +81,6 @@ define <4 x i32> @smax_vec2(<4 x i32> %x) { ; CHECK-NEXT: vpxor %xmm1, %xmm0, %xmm0 ; CHECK-NEXT: vpmaxsd %xmm1, %xmm0, %xmm0 ; CHECK-NEXT: retq -; %not_x = xor <4 x i32> %x, %cmp = icmp sgt <4 x i32> %x, zeroinitializer %sel = select <4 x i1> %cmp, <4 x i32> , <4 x i32> %not_x @@ -101,7 +96,6 @@ define <4 x i32> @smax_vec3(<4 x i32> %x, <4 x i32> %y) { ; CHECK-NEXT: vpxor %xmm1, %xmm1, %xmm1 ; CHECK-NEXT: vpmaxsd %xmm1, %xmm0, %xmm0 ; CHECK-NEXT: retq -; %sub = sub nsw <4 x i32> %x, %y %cmp = icmp slt <4 x i32> %x, %y %sel = select <4 x i1> %cmp, <4 x i32> zeroinitializer, <4 x i32> %sub @@ -117,7 +111,6 @@ define <4 x i32> @smax_vec4(<4 x i32> %x, <4 x i32> %y) { ; CHECK-NEXT: vpxor %xmm1, %xmm1, %xmm1 ; CHECK-NEXT: vpmaxsd %xmm1, %xmm0, %xmm0 ; CHECK-NEXT: retq -; %sub = sub nsw <4 x i32> %x, %y %cmp = icmp sgt <4 x i32> %x, %y %sel = select <4 x i1> %cmp, <4 x i32> %sub, <4 x i32> zeroinitializer @@ -129,7 +122,6 @@ define <4 x i32> @umax_vec1(<4 x i32> %x) { ; CHECK: # BB#0: ; CHECK-NEXT: vpmaxud {{.*}}(%rip), %xmm0, %xmm0 ; CHECK-NEXT: retq -; %cmp = icmp slt <4 x i32> %x, zeroinitializer %sel = select <4 x i1> %cmp, <4 x i32> %x, <4 x i32> ret <4 x i32> %sel @@ -140,7 +132,6 @@ define <4 x i32> @umax_vec2(<4 x i32> %x) { ; CHECK: # BB#0: ; CHECK-NEXT: vpmaxud {{.*}}(%rip), %xmm0, %xmm0 ; CHECK-NEXT: retq -; %cmp = icmp sgt <4 x i32> %x, %sel = select <4 x i1> %cmp, <4 x i32> , <4 x i32> %x ret <4 x i32> %sel @@ -151,7 +142,6 @@ define <4 x i32> @umin_vec1(<4 x i32> %x) { ; CHECK: # BB#0: ; CHECK-NEXT: vpminud {{.*}}(%rip), %xmm0, %xmm0 ; CHECK-NEXT: retq -; %cmp = icmp slt <4 x i32> %x, zeroinitializer %sel = select <4 x i1> %cmp, <4 x i32> , <4 x i32> %x ret <4 x i32> %sel @@ -162,9 +152,80 @@ define <4 x i32> @umin_vec2(<4 x i32> %x) { ; CHECK: # BB#0: ; CHECK-NEXT: vpminud {{.*}}(%rip), %xmm0, %xmm0 ; CHECK-NEXT: retq -; %cmp = icmp sgt <4 x i32> %x, %sel = select <4 x i1> %cmp, <4 x i32> %x, <4 x i32> ret <4 x i32> %sel } +; The next 4 tests are value clamping with constants: +; https://llvm.org/bugs/show_bug.cgi?id=31693 + +; (X SMAX(SMIN(X, C2), C1) + +define <4 x i32> @clamp_signed1(<4 x i32> %x) { +; CHECK-LABEL: clamp_signed1: +; CHECK: # BB#0: +; CHECK-NEXT: vpminsd {{.*}}(%rip), %xmm0, %xmm1 +; CHECK-NEXT: vmovdqa {{.*#+}} xmm2 = [15,15,15,15] +; CHECK-NEXT: vpcmpgtd %xmm0, %xmm2, %xmm0 +; CHECK-NEXT: vblendvps %xmm0, %xmm2, %xmm1, %xmm0 +; CHECK-NEXT: retq + %cmp2 = icmp slt <4 x i32> %x, + %min = select <4 x i1> %cmp2, <4 x i32> %x, <4 x i32> + %cmp1 = icmp slt <4 x i32> %x, + %r = select <4 x i1> %cmp1, <4 x i32>, <4 x i32> %min + ret <4 x i32> %r +} + +; (X >s C1) ? C1 : SMAX(X, C2) ==> SMIN(SMAX(X, C2), C1) + +define <4 x i32> @clamp_signed2(<4 x i32> %x) { +; CHECK-LABEL: clamp_signed2: +; CHECK: # BB#0: +; CHECK-NEXT: vpmaxsd {{.*}}(%rip), %xmm0, %xmm1 +; CHECK-NEXT: vmovdqa {{.*#+}} xmm2 = [255,255,255,255] +; CHECK-NEXT: vpcmpgtd %xmm2, %xmm0, %xmm0 +; CHECK-NEXT: vblendvps %xmm0, %xmm2, %xmm1, %xmm0 +; CHECK-NEXT: retq + %cmp2 = icmp sgt <4 x i32> %x, + %max = select <4 x i1> %cmp2, <4 x i32> %x, <4 x i32> + %cmp1 = icmp sgt <4 x i32> %x, + %r = select <4 x i1> %cmp1, <4 x i32>, <4 x i32> %max + ret <4 x i32> %r +} + +; (X UMAX(UMIN(X, C2), C1) + +define <4 x i32> @clamp_unsigned1(<4 x i32> %x) { +; CHECK-LABEL: clamp_unsigned1: +; CHECK: # BB#0: +; CHECK-NEXT: vpminud {{.*}}(%rip), %xmm0, %xmm1 +; CHECK-NEXT: vpxor {{.*}}(%rip), %xmm0, %xmm0 +; CHECK-NEXT: vmovdqa {{.*#+}} xmm2 = [2147483663,2147483663,2147483663,2147483663] +; CHECK-NEXT: vpcmpgtd %xmm0, %xmm2, %xmm0 +; CHECK-NEXT: vblendvps %xmm0, {{.*}}(%rip), %xmm1, %xmm0 +; CHECK-NEXT: retq + %cmp2 = icmp ult <4 x i32> %x, + %min = select <4 x i1> %cmp2, <4 x i32> %x, <4 x i32> + %cmp1 = icmp ult <4 x i32> %x, + %r = select <4 x i1> %cmp1, <4 x i32>, <4 x i32> %min + ret <4 x i32> %r +} + +; (X >u C1) ? C1 : UMAX(X, C2) ==> UMIN(UMAX(X, C2), C1) + +define <4 x i32> @clamp_unsigned2(<4 x i32> %x) { +; CHECK-LABEL: clamp_unsigned2: +; CHECK: # BB#0: +; CHECK-NEXT: vpmaxud {{.*}}(%rip), %xmm0, %xmm1 +; CHECK-NEXT: vpxor {{.*}}(%rip), %xmm0, %xmm0 +; CHECK-NEXT: vpcmpgtd {{.*}}(%rip), %xmm0, %xmm0 +; CHECK-NEXT: vblendvps %xmm0, {{.*}}(%rip), %xmm1, %xmm0 +; CHECK-NEXT: retq + %cmp2 = icmp ugt <4 x i32> %x, + %max = select <4 x i1> %cmp2, <4 x i32> %x, <4 x i32> + %cmp1 = icmp ugt <4 x i32> %x, + %r = select <4 x i1> %cmp1, <4 x i32>, <4 x i32> %max + ret <4 x i32> %r +} +