RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-12-12 06:06:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

IMPLICIT_DEF was not the beautiful elegant solution I thought it was going

Browse Source 
to be.  In fact, it made stuff worse.  :(


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@6013 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2003-05-07 19:21:28 +00:00
parent dff780f046
commit c248903b2a
5 changed files with 8 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Target/X86/InstSelectSimple.cpp
View File

@ -79,9 +79,6 @@ namespace {
BB = &F->front();
// Declare that the stack pointer is live on entrance to the function
BuildMI(BB, X86::IMPLICIT_DEF, 0, X86::ESP);
// Copy incoming arguments off of the stack...
LoadArgumentsToVirtualRegs(Fn);
@ -677,18 +674,18 @@ void ISel::visitReturnInst(ReturnInst &I) {
case cInt:
promote32(X86::EAX, ValueRecord(RetReg, RetVal->getType()));
// Declare that EAX is live on exit
BuildMI(BB, X86::IMPLICIT_USE, 1).addReg(X86::EAX);
BuildMI(BB, X86::IMPLICIT_USE, 2).addReg(X86::EAX).addReg(X86::ESP);
break;
case cFP: // Floats & Doubles: Return in ST(0)
BuildMI(BB, X86::FpSETRESULT, 1).addReg(RetReg);
// Declare that top-of-stack is live on exit
BuildMI(BB, X86::IMPLICIT_USE, 1).addReg(X86::ST0);
BuildMI(BB, X86::IMPLICIT_USE, 2).addReg(X86::ST0).addReg(X86::ESP);
break;
case cLong:
BuildMI(BB, X86::MOVrr32, 1, X86::EAX).addReg(RetReg);
BuildMI(BB, X86::MOVrr32, 1, X86::EDX).addReg(RetReg+1);
// Declare that EAX & EDX are live on exit
BuildMI(BB, X86::IMPLICIT_USE, 2).addReg(X86::EAX).addReg(X86::EDX);
BuildMI(BB, X86::IMPLICIT_USE, 3).addReg(X86::EAX).addReg(X86::EDX).addReg(X86::ESP);
break;
default:
visitInstruction(I);

2
lib/Target/X86/MachineCodeEmitter.cpp
View File

@ -259,7 +259,7 @@ void Emitter::emitInstruction(MachineInstr &MI) {
switch (Desc.TSFlags & X86II::FormMask) {
default: assert(0 && "Unknown FormMask value in X86 MachineCodeEmitter!");
case X86II::Pseudo:
if (Opcode != X86::IMPLICIT_DEF && Opcode != X86::IMPLICIT_USE)
if (Opcode != X86::IMPLICIT_USE)
std::cerr << "X86 Machine Code Emitter: No 'form', not emitting: " << MI;
break;

2
lib/Target/X86/X86CodeEmitter.cpp
View File

@ -259,7 +259,7 @@ void Emitter::emitInstruction(MachineInstr &MI) {
switch (Desc.TSFlags & X86II::FormMask) {
default: assert(0 && "Unknown FormMask value in X86 MachineCodeEmitter!");
case X86II::Pseudo:
if (Opcode != X86::IMPLICIT_DEF && Opcode != X86::IMPLICIT_USE)
if (Opcode != X86::IMPLICIT_USE)
std::cerr << "X86 Machine Code Emitter: No 'form', not emitting: " << MI;
break;

9
lib/Target/X86/X86ISelSimple.cpp
View File

@ -79,9 +79,6 @@ namespace {
BB = &F->front();
// Declare that the stack pointer is live on entrance to the function
BuildMI(BB, X86::IMPLICIT_DEF, 0, X86::ESP);
// Copy incoming arguments off of the stack...
LoadArgumentsToVirtualRegs(Fn);
@ -677,18 +674,18 @@ void ISel::visitReturnInst(ReturnInst &I) {
case cInt:
promote32(X86::EAX, ValueRecord(RetReg, RetVal->getType()));
// Declare that EAX is live on exit
BuildMI(BB, X86::IMPLICIT_USE, 1).addReg(X86::EAX);
BuildMI(BB, X86::IMPLICIT_USE, 2).addReg(X86::EAX).addReg(X86::ESP);
break;
case cFP: // Floats & Doubles: Return in ST(0)
BuildMI(BB, X86::FpSETRESULT, 1).addReg(RetReg);
// Declare that top-of-stack is live on exit
BuildMI(BB, X86::IMPLICIT_USE, 1).addReg(X86::ST0);
BuildMI(BB, X86::IMPLICIT_USE, 2).addReg(X86::ST0).addReg(X86::ESP);
break;
case cLong:
BuildMI(BB, X86::MOVrr32, 1, X86::EAX).addReg(RetReg);
BuildMI(BB, X86::MOVrr32, 1, X86::EDX).addReg(RetReg+1);
// Declare that EAX & EDX are live on exit
BuildMI(BB, X86::IMPLICIT_USE, 2).addReg(X86::EAX).addReg(X86::EDX);
BuildMI(BB, X86::IMPLICIT_USE, 3).addReg(X86::EAX).addReg(X86::EDX).addReg(X86::ESP);
break;
default:
visitInstruction(I);

6
lib/Target/X86/X86InstrInfo.def
View File

@ -79,12 +79,6 @@ I(ADJCALLSTACKDOWN, "adjcallstackdown", 0, 0, X86II::Pseudo, NoIR,
// instruction after the call.
I(ADJCALLSTACKUP , "adjcallstackup" , 0, 0, X86II::Pseudo, NoIR, NoIR)
// This pseudo-instruction is used to record implicit definitions of physical
// registers: registers that are live on input to the function (currently just
// the stack pointer, eventually could include arguments passed in registers).
//
I(IMPLICIT_DEF, "implicit_def", 0, 0, X86II::Pseudo, NoIR, NoIR)
// This pseudo-instruction is used to record implicit uses of physical registers
// at the end of the function. This ensures that bad things aren't done to
// registes that are live on exit from the function (for example, EAX).