RPCSX/llvm
1
0
Fork 0
mirror of https://github.com/RPCSX/llvm.git synced 2024-12-02 00:36:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make sign extension work correctly for unusual bit widths.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@36635 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Reid Spencer 2007-05-02 02:17:41 +00:00
parent 67cf561b7f
commit cee7ba389e
1 changed files with 100 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

126
lib/Target/CBackend/CBackend.cpp
View File

@ -412,6 +412,29 @@ CWriter::printSimpleType(std::ostream &Out, const Type *Ty, bool isSigned,
} }
} }
#define IMPL_SIGN_EXTENSION(OpTy, Func) { \
const IntegerType* IntTy = cast<IntegerType>(OpTy); \
unsigned BitWidth = IntTy->getBitWidth(); \
if (BitWidth != 8 && BitWidth != 16 && BitWidth != 32 && \
BitWidth != 64 && BitWidth != 128) { \
const char * Suffix; \
if (BitWidth <=32)\
Suffix = "U"; \
else \
Suffix = "ULL"; \
Out << "("; \
Func; \
Out << " & (1" << Suffix << " << " << BitWidth - 1 << " ) ? "; \
Func; \
Out << " | " << (~IntTy->getBitMask()) << Suffix << " : "; \
Func; \
Out << " & " << IntTy->getBitMask() << Suffix; \
Out << ")";\
} \
else \
Func; \
}
// Pass the Type* and the variable name and this prints out the variable // Pass the Type* and the variable name and this prints out the variable
// declaration. // declaration.
// //
@ -711,23 +734,39 @@ void CWriter::printConstant(Constant *CPV) {
case Instruction::BitCast: case Instruction::BitCast:
Out << "("; Out << "(";
printCast(CE->getOpcode(), CE->getOperand(0)->getType(), CE->getType()); printCast(CE->getOpcode(), CE->getOperand(0)->getType(), CE->getType());
if (CE->getOpcode() == Instruction::SExt && if (CE->getOpcode() == Instruction::Trunc ||
CE->getOperand(0)->getType() == Type::Int1Ty) {
// Make sure we really sext from bool here by subtracting from 0
Out << "0-";
}
printConstant(CE->getOperand(0));
if (CE->getType() == Type::Int1Ty &&
(CE->getOpcode() == Instruction::Trunc ||
CE->getOpcode() == Instruction::FPToUI || CE->getOpcode() == Instruction::FPToUI ||
CE->getOpcode() == Instruction::FPToSI || CE->getOpcode() == Instruction::FPToSI ||
CE->getOpcode() == Instruction::PtrToInt)) { CE->getOpcode() == Instruction::PtrToInt) {
// Make sure we really truncate to bool here by anding with 1 if (const IntegerType* IntTy = dyn_cast<IntegerType>(CE->getType())) {
Out << "&1u"; uint64_t BitMask = IntTy->getBitMask();
printConstant(CE->getOperand(0));
Out << "&" << BitMask << (IntTy->getBitWidth() <=32 ? "U": "ULL");
}
} }
Out << ')'; else if (CE->getOpcode() == Instruction::SExt &&
CE->getOperand(0)->getType() == Type::Int1Ty) {
// Make sure we really sext from bool here by subtracting from 0
Out << "0-";
printConstant(CE->getOperand(0));
}
else if (CE->getOpcode() == Instruction::SExt &&
CE->getOperand(0)->getType()->getTypeID() == Type::IntegerTyID) {
IMPL_SIGN_EXTENSION(CE->getOperand(0)->getType(),
printConstant(CE->getOperand(0)));
}
else if (CE->getOpcode() == Instruction::ZExt &&
CE->getOperand(0)->getType()->getTypeID() == Type::IntegerTyID){
const IntegerType* IntTy =
cast<IntegerType>(CE->getOperand(0)->getType());
uint64_t BitMask = IntTy->getBitMask();
writeOperand(CE->getOperand(0));
Out << "&" << BitMask << (IntTy->getBitWidth() <=32 ? "U": "ULL");
}
else
printConstant(CE->getOperand(0));
Out << ")";
return; return;
case Instruction::GetElementPtr: case Instruction::GetElementPtr:
Out << "(&("; Out << "(&(";
printIndexingExpression(CE->getOperand(0), gep_type_begin(CPV), printIndexingExpression(CE->getOperand(0), gep_type_begin(CPV),
@ -1228,7 +1267,11 @@ void CWriter::writeOperandWithCast(Value* Operand, unsigned Opcode) {
Out << "(("; Out << "((";
printSimpleType(Out, OpTy, castIsSigned); printSimpleType(Out, OpTy, castIsSigned);
Out << ")"; Out << ")";
writeOperand(Operand); if (castIsSigned && OpTy->getTypeID() == Type::IntegerTyID) {
IMPL_SIGN_EXTENSION(OpTy, writeOperand(Operand));
}
else
writeOperand(Operand);
Out << ")"; Out << ")";
} else } else
writeOperand(Operand); writeOperand(Operand);
@ -1254,6 +1297,8 @@ void CWriter::writeOperandWithCast(Value* Operand, ICmpInst::Predicate predicate
default: default:
// for eq and ne, it doesn't matter // for eq and ne, it doesn't matter
break; break;
case ICmpInst::ICMP_EQ:
case ICmpInst::ICMP_NE:
case ICmpInst::ICMP_UGT: case ICmpInst::ICMP_UGT:
case ICmpInst::ICMP_UGE: case ICmpInst::ICMP_UGE:
case ICmpInst::ICMP_ULT: case ICmpInst::ICMP_ULT:
@ -1278,10 +1323,25 @@ void CWriter::writeOperandWithCast(Value* Operand, ICmpInst::Predicate predicate
else else
printType(Out, OpTy); // not integer, sign doesn't matter printType(Out, OpTy); // not integer, sign doesn't matter
Out << ")"; Out << ")";
writeOperand(Operand); if(castIsSigned && OpTy->getTypeID() == Type::IntegerTyID) {
IMPL_SIGN_EXTENSION(OpTy, writeOperand(Operand));
} else {
writeOperand(Operand);
if(OpTy->getTypeID() == Type::IntegerTyID){
const IntegerType * IntTy = cast<IntegerType>(OpTy);
uint64_t BitMask = IntTy->getBitMask();
Out << "&" << BitMask << (IntTy->getBitWidth() <=32 ? "U": "ULL");
}
}
Out << ")"; Out << ")";
} else } else {
writeOperand(Operand); writeOperand(Operand);
if(OpTy->getTypeID() == Type::IntegerTyID){
const IntegerType * IntTy = cast<IntegerType>(OpTy);
uint64_t BitMask = IntTy->getBitMask();
Out << "&" << BitMask << (IntTy->getBitWidth() <=32 ? "U": "ULL");
}
}
} }
// generateCompilerSpecificCode - This is where we add conditional compilation // generateCompilerSpecificCode - This is where we add conditional compilation
@ -2346,21 +2406,33 @@ void CWriter::visitCastInst(CastInst &I) {
<< getFloatBitCastField(I.getType()); << getFloatBitCastField(I.getType());
} else { } else {
printCast(I.getOpcode(), SrcTy, DstTy); printCast(I.getOpcode(), SrcTy, DstTy);
if (I.getOpcode() == Instruction::SExt && SrcTy == Type::Int1Ty) { if (I.getOpcode() == Instruction::Trunc ||
I.getOpcode() == Instruction::FPToUI ||
I.getOpcode() == Instruction::FPToSI ||
I.getOpcode() == Instruction::PtrToInt) {
if (const IntegerType* IntTy = dyn_cast<IntegerType>(DstTy)){
uint64_t BitMask = IntTy->getBitMask();
writeOperand(I.getOperand(0));
Out << "&" << BitMask << (IntTy->getBitWidth() <=32 ? "U": "ULL");
}
} else if (I.getOpcode() == Instruction::SExt && SrcTy == Type::Int1Ty) {
// Make sure we really get a sext from bool by subtracing the bool from 0 // Make sure we really get a sext from bool by subtracing the bool from 0
Out << "0-"; Out << "0-";
writeOperand(I.getOperand(0));
} else if (I.getOpcode() == Instruction::SExt &&
SrcTy->getTypeID() == Type::IntegerTyID) {
IMPL_SIGN_EXTENSION(SrcTy, writeOperand(I.getOperand(0)) );
} else if (I.getOpcode() == Instruction::ZExt &&
SrcTy->getTypeID() == Type::IntegerTyID) {
const IntegerType* IntTy = cast<IntegerType>(SrcTy);
uint64_t BitMask = IntTy->getBitMask();
writeOperand(I.getOperand(0));
Out << "&" << BitMask << (IntTy->getBitWidth() <=32 ? "U": "ULL");
} }
writeOperand(I.getOperand(0)); else
if (DstTy == Type::Int1Ty && writeOperand(I.getOperand(0));
(I.getOpcode() == Instruction::Trunc ||
I.getOpcode() == Instruction::FPToUI ||
I.getOpcode() == Instruction::FPToSI ||
I.getOpcode() == Instruction::PtrToInt)) {
// Make sure we really get a trunc to bool by anding the operand with 1
Out << "&1u";
}
} }
Out << ')'; Out << ")";
} }
void CWriter::visitSelectInst(SelectInst &I) { void CWriter::visitSelectInst(SelectInst &I) {